| Message ID | 20231209160505.237843-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [net-next] dt-bindings: net: wireless: brcm,bcm4329-fmac: allow local-mac-address | expand |
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> writes: > Some boards come with local-mac-address property. Allow it, and > mac-address as well, to fix dtbs_check warnings like: > > apple/t8103-j456.dtb: network@0,0: Unevaluated properties are not allowed ('local-mac-address' was unexpected) > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml | 5 +++++ > 1 file changed, 5 insertions(+) Wireless patches go to wireless-next, not net-next. But no need to resend because of this.
On 11/12/2023 14:19, Kalle Valo wrote: > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> writes: > >> Some boards come with local-mac-address property. Allow it, and >> mac-address as well, to fix dtbs_check warnings like: >> >> apple/t8103-j456.dtb: network@0,0: Unevaluated properties are not allowed ('local-mac-address' was unexpected) >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> .../devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml | 5 +++++ >> 1 file changed, 5 insertions(+) > > Wireless patches go to wireless-next, not net-next. But no need to > resend because of this. I keep forgetting this... I'll write a note for myself. Best regards, Krzysztof
On Sat, Dec 09, 2023 at 05:05:05PM +0100, Krzysztof Kozlowski wrote: > Some boards come with local-mac-address property. Allow it, and > mac-address as well, to fix dtbs_check warnings like: > > apple/t8103-j456.dtb: network@0,0: Unevaluated properties are not allowed ('local-mac-address' was unexpected) > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml > index 4aa521f1be8c..4c8a7950c83e 100644 > --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml > +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml > @@ -67,6 +67,9 @@ properties: > description: Name for the OOB IRQ, this must be set to "host-wake". > const: host-wake > > + local-mac-address: true > + mac-address: true This doesn't work because the schema for these properties are never applied. There was some work to split them out from ethernet-controller.yaml to a network device schema[1]. Perhaps you can revive that. Rob [1] https://lore.kernel.org/all/20230203-dt-bindings-network-class-v2-0-499686795073@jannau.net/#t
diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml index 4aa521f1be8c..4c8a7950c83e 100644 --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml @@ -67,6 +67,9 @@ properties: description: Name for the OOB IRQ, this must be set to "host-wake". const: host-wake + local-mac-address: true + mac-address: true + brcm,drive-strength: $ref: /schemas/types.yaml#/definitions/uint32 description: Drive strength used for the SDIO pins on the device in mA. @@ -148,6 +151,8 @@ examples: interrupt-parent = <&gpio>; interrupts = <24 IRQ_TYPE_EDGE_FALLING>; interrupt-names = "host-wake"; + /* To be filled by the bootloader */ + local-mac-address = [00 00 00 00 00 00]; reset-gpios = <&gpio 23 GPIO_ACTIVE_LOW>; brcm,ccode-map = "JP-JP-78", "US-Q2-86"; };
Some boards come with local-mac-address property. Allow it, and mac-address as well, to fix dtbs_check warnings like: apple/t8103-j456.dtb: network@0,0: Unevaluated properties are not allowed ('local-mac-address' was unexpected) Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml | 5 +++++ 1 file changed, 5 insertions(+)