From patchwork Wed Dec 13 05:14:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Antipov X-Patchwork-Id: 13490352 X-Patchwork-Delegate: kvalo@adurom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=yandex.ru header.i=@yandex.ru header.b="l0P5TSw0" Received: from forward101c.mail.yandex.net (forward101c.mail.yandex.net [178.154.239.212]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC273CF for ; Tue, 12 Dec 2023 21:16:00 -0800 (PST) Received: from mail-nwsmtp-smtp-production-main-59.iva.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-59.iva.yp-c.yandex.net [IPv6:2a02:6b8:c0c:319f:0:640:2485:0]) by forward101c.mail.yandex.net (Yandex) with ESMTP id D01EA60A78; Wed, 13 Dec 2023 08:15:57 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-59.iva.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id uFbMwoMXueA0-IcbID8SR; Wed, 13 Dec 2023 08:15:57 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1702444557; bh=AKtpUD4MttzDaNOer4++Hl0rSP6BYC5B80tifDB1dqM=; h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From; b=l0P5TSw0LNY1w3wxyYSaHUTPvXiLg5XRREsaIGhCicmVtL9kqCOug2RFkxJNVf045 J/tQUU/yySpNoSCet21yzJKUc7tFCHxNxz+Jfuc7+c9cfO0t5IXvGcCjpsPubr6EqK Nwle2f7wT47KTKFB15B2cS7mc+FNNcDYEVrO17Mk= Authentication-Results: mail-nwsmtp-smtp-production-main-59.iva.yp-c.yandex.net; dkim=pass header.i=@yandex.ru From: Dmitry Antipov To: Kalle Valo Cc: Stanislaw Gruszka , lvc-project@linuxtesting.org, linux-wireless@vger.kernel.org, Dmitry Antipov Subject: [PATCH] [v2] wifi: rt2x00: remove useless code in rt2x00queue_create_tx_descriptor() Date: Wed, 13 Dec 2023 08:14:43 +0300 Message-ID: <20231213051449.126963-1-dmantipov@yandex.ru> X-Mailer: git-send-email 2.43.0 In-Reply-To: <87il53nvqc.fsf@kernel.org> References: <87il53nvqc.fsf@kernel.org> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In 'rt2x00queue_create_tx_descriptor()', there is no need to call 'ieee80211_get_rts_cts_rate()' while checking for RTS/CTS frame since this function returns NULL or pointer to internal bitrate table entry, and the return value is not actually used. Compile tested only. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Dmitry Antipov Acked-by: Stanislaw Gruszka --- v2: avoid scoped locals (Kalle Valo) --- drivers/net/wireless/ralink/rt2x00/rt2x00queue.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00queue.c b/drivers/net/wireless/ralink/rt2x00/rt2x00queue.c index 98df0aef8168..013003777fee 100644 --- a/drivers/net/wireless/ralink/rt2x00/rt2x00queue.c +++ b/drivers/net/wireless/ralink/rt2x00/rt2x00queue.c @@ -416,9 +416,6 @@ static void rt2x00queue_create_tx_descriptor(struct rt2x00_dev *rt2x00dev, __set_bit(ENTRY_TXD_RTS_FRAME, &txdesc->flags); else __set_bit(ENTRY_TXD_CTS_FRAME, &txdesc->flags); - if (tx_info->control.rts_cts_rate_idx >= 0) - rate = - ieee80211_get_rts_cts_rate(rt2x00dev->hw, tx_info); } /*