| Message ID | 20231220141831.10063-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6aeaa379291bac24be568808da5e305d975d8860 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [next] wifi: rtw89: mac: Fix spelling mistakes "notfify" -> "notify" | expand |
> -----Original Message----- > From: Colin Ian King <colin.i.king@gmail.com> > Sent: Wednesday, December 20, 2023 10:19 PM > To: Ping-Ke Shih <pkshih@realtek.com>; Kalle Valo <kvalo@kernel.org>; linux-wireless@vger.kernel.org > Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH][next] wifi: rtw89: mac: Fix spelling mistakes "notfify" -> "notify" > > There are two spelling mistakes in rtw89_err error messages. Fix these > and also add space between [ERR] and message text. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Acked-by: Ping-Ke Shih <pkshih@realtek.com> Thanks for the correctness. Could I know the tool you used to find out these typo? Ping-Ke
On 22/12/2023 00:19, Ping-Ke Shih wrote: > > >> -----Original Message----- >> From: Colin Ian King <colin.i.king@gmail.com> >> Sent: Wednesday, December 20, 2023 10:19 PM >> To: Ping-Ke Shih <pkshih@realtek.com>; Kalle Valo <kvalo@kernel.org>; linux-wireless@vger.kernel.org >> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org >> Subject: [PATCH][next] wifi: rtw89: mac: Fix spelling mistakes "notfify" -> "notify" >> >> There are two spelling mistakes in rtw89_err error messages. Fix these >> and also add space between [ERR] and message text. >> >> Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > > Acked-by: Ping-Ke Shih <pkshih@realtek.com> > > Thanks for the correctness. Could I know the tool you used to find out these > typo? Sure, https://github.com/ColinIanKing/kernelscan It needs the american dictionary, installed in /usr/share/dict e.g. apt-get install wamerican and then spellcheck with: ./kernelscan -k path-to-code-you-want-to-scan I run kernelscan on the entire linux-next source daily and diff the days's results with the previous day using the meld diff tool. Colin > > Ping-Ke > >
> -----Original Message----- > From: Colin King (gmail) <colin.i.king@gmail.com> > Sent: Friday, December 22, 2023 8:09 PM > To: Ping-Ke Shih <pkshih@realtek.com>; Kalle Valo <kvalo@kernel.org>; linux-wireless@vger.kernel.org > Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH][next] wifi: rtw89: mac: Fix spelling mistakes "notfify" -> "notify" > > On 22/12/2023 00:19, Ping-Ke Shih wrote: > > > > > >> -----Original Message----- > >> From: Colin Ian King <colin.i.king@gmail.com> > >> Sent: Wednesday, December 20, 2023 10:19 PM > >> To: Ping-Ke Shih <pkshih@realtek.com>; Kalle Valo <kvalo@kernel.org>; linux-wireless@vger.kernel.org > >> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org > >> Subject: [PATCH][next] wifi: rtw89: mac: Fix spelling mistakes "notfify" -> "notify" > >> > >> There are two spelling mistakes in rtw89_err error messages. Fix these > >> and also add space between [ERR] and message text. > >> > >> Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > > > > Acked-by: Ping-Ke Shih <pkshih@realtek.com> > > > > Thanks for the correctness. Could I know the tool you used to find out these > > typo? > > Sure, > > https://github.com/ColinIanKing/kernelscan > > It needs the american dictionary, installed in /usr/share/dict e.g. > apt-get install wamerican > > and then spellcheck with: > > ./kernelscan -k path-to-code-you-want-to-scan Thanks for the tool. :-) I will try to scan my driver before sending out patches. Ping-Ke
Colin Ian King <colin.i.king@gmail.com> wrote: > There are two spelling mistakes in rtw89_err error messages. Fix these > and also add space between [ERR] and message text. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > Acked-by: Ping-Ke Shih <pkshih@realtek.com> Patch applied to wireless-next.git, thanks. 6aeaa379291b wifi: rtw89: mac: Fix spelling mistakes "notfify" -> "notify"
diff --git a/drivers/net/wireless/realtek/rtw89/mac_be.c b/drivers/net/wireless/realtek/rtw89/mac_be.c index be30c9346293..4befbe06cd15 100644 --- a/drivers/net/wireless/realtek/rtw89/mac_be.c +++ b/drivers/net/wireless/realtek/rtw89/mac_be.c @@ -1616,7 +1616,7 @@ static int dbcc_enable_be(struct rtw89_dev *rtwdev, bool enable) if (test_bit(RTW89_FLAG_FW_RDY, rtwdev->flags)) { ret = rtw89_fw_h2c_notify_dbcc(rtwdev, true); if (ret) { - rtw89_err(rtwdev, "%s:[ERR]notfify dbcc1 fail %d\n", + rtw89_err(rtwdev, "%s:[ERR] notify dbcc1 fail %d\n", __func__, ret); return ret; } @@ -1625,7 +1625,7 @@ static int dbcc_enable_be(struct rtw89_dev *rtwdev, bool enable) if (test_bit(RTW89_FLAG_FW_RDY, rtwdev->flags)) { ret = rtw89_fw_h2c_notify_dbcc(rtwdev, false); if (ret) { - rtw89_err(rtwdev, "%s:[ERR]notfify dbcc1 fail %d\n", + rtw89_err(rtwdev, "%s:[ERR] notify dbcc1 fail %d\n", __func__, ret); return ret; }
There are two spelling mistakes in rtw89_err error messages. Fix these and also add space between [ERR] and message text. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/net/wireless/realtek/rtw89/mac_be.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)