| Message ID | 20240130040303.370590-2-quic_kangyang@quicinc.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4f684533afe2317b5338209cbad4551bae7949a2 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wifi: ath12k: P2P support for WCN7850 | expand |
On 1/29/2024 8:02 PM, Kang Yang wrote: > Current structure wmi_vdev_create_cmd is not matched to the firmware > definition. So update it. > > And update vdev_stats_id_valid for vdev_stats_id. > > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Kang Yang <quic_kangyang@quicinc.com> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com> Note that if you respin a series, and if a given patch has not been substantially modified, you should add any previously given tags to the new patch since they are not automatically carried forward in patchwork. That saves the reviewers the overhead of revisiting patches they've already approved.
Kang Yang <quic_kangyang@quicinc.com> writes: > Current structure wmi_vdev_create_cmd is not matched to the firmware > definition. So update it. > > And update vdev_stats_id_valid for vdev_stats_id. > > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Kang Yang <quic_kangyang@quicinc.com> > --- > > v6: position adjustment. > v5: no change. > v4: no change. > v3: no change. > v2: > 1. add Tested-on tag of QCN9274. > 2. update copyright. BTW it's quite a lot of work to add changelog to every patch, especially if there are 11 patches. It's totally fine to have the list of changes between versions in the cover letter, no need to add them individually to every patch. Though this is not a problem, just trying to reduce your workload. > --- > drivers/net/wireless/ath/ath12k/wmi.c | 3 +++ > drivers/net/wireless/ath/ath12k/wmi.h | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/drivers/net/wireless/ath/ath12k/wmi.c b/drivers/net/wireless/ath/ath12k/wmi.c > index 2fa724e5851a..d8ebaf4b8359 100644 > --- a/drivers/net/wireless/ath/ath12k/wmi.c > +++ b/drivers/net/wireless/ath/ath12k/wmi.c > @@ -826,6 +826,9 @@ int ath12k_wmi_vdev_create(struct ath12k *ar, u8 *macaddr, > cmd->vdev_stats_id = cpu_to_le32(args->if_stats_id); > ether_addr_copy(cmd->vdev_macaddr.addr, macaddr); > > + if (args->if_stats_id != ATH12K_INVAL_VDEV_STATS_ID) > + cmd->vdev_stats_id_valid = cpu_to_le32(true); Using 'true' in a firmware interface looks odd to me and I think what we mean is BIT(0), right? I'll change this in the pending branch.
Kang Yang <quic_kangyang@quicinc.com> wrote: > Current structure wmi_vdev_create_cmd is not matched to the firmware > definition. So update it. > > And update vdev_stats_id_valid for vdev_stats_id. > > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Kang Yang <quic_kangyang@quicinc.com> > Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com> > Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> 11 patches applied to ath-next branch of ath.git, thanks. 4f684533afe2 wifi: ath12k: fix broken structure wmi_vdev_create_cmd 019b58dcb6ed wifi: ath12k: fix incorrect logic of calculating vdev_stats_id ef860c6a3adf wifi: ath12k: change interface combination for P2P mode 575ec73cb880 wifi: ath12k: add P2P IE in beacon template 9411eecb60cb wifi: ath12k: implement handling of P2P NoA event 2830bc9e784f wifi: ath12k: implement remain on channel for P2P mode 28035a88f8b3 wifi: ath12k: change WLAN_SCAN_PARAMS_MAX_IE_LEN from 256 to 512 32e7b12e2611 wifi: ath12k: allow specific mgmt frame tx while vdev is not up c9e4e41e71ff wifi: ath12k: move peer delete after vdev stop of station for WCN7850 cf0425eead75 wifi: ath12k: designating channel frequency for ROC scan e65a63986575 wifi: ath12k: advertise P2P dev support for WCN7850
diff --git a/drivers/net/wireless/ath/ath12k/wmi.c b/drivers/net/wireless/ath/ath12k/wmi.c index 2fa724e5851a..d8ebaf4b8359 100644 --- a/drivers/net/wireless/ath/ath12k/wmi.c +++ b/drivers/net/wireless/ath/ath12k/wmi.c @@ -826,6 +826,9 @@ int ath12k_wmi_vdev_create(struct ath12k *ar, u8 *macaddr, cmd->vdev_stats_id = cpu_to_le32(args->if_stats_id); ether_addr_copy(cmd->vdev_macaddr.addr, macaddr); + if (args->if_stats_id != ATH12K_INVAL_VDEV_STATS_ID) + cmd->vdev_stats_id_valid = cpu_to_le32(true); + ptr = skb->data + sizeof(*cmd); len = WMI_NUM_SUPPORTED_BAND_MAX * sizeof(*txrx_streams); diff --git a/drivers/net/wireless/ath/ath12k/wmi.h b/drivers/net/wireless/ath/ath12k/wmi.h index 06e5b9b4049b..4afc6ca15c91 100644 --- a/drivers/net/wireless/ath/ath12k/wmi.h +++ b/drivers/net/wireless/ath/ath12k/wmi.h @@ -2716,6 +2716,9 @@ struct wmi_vdev_create_cmd { struct ath12k_wmi_mac_addr_params vdev_macaddr; __le32 num_cfg_txrx_streams; __le32 pdev_id; + __le32 mbssid_flags; + __le32 mbssid_tx_vdev_id; + __le32 vdev_stats_id_valid; __le32 vdev_stats_id; } __packed;
Current structure wmi_vdev_create_cmd is not matched to the firmware definition. So update it. And update vdev_stats_id_valid for vdev_stats_id. Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 Signed-off-by: Kang Yang <quic_kangyang@quicinc.com> --- v6: position adjustment. v5: no change. v4: no change. v3: no change. v2: 1. add Tested-on tag of QCN9274. 2. update copyright. --- drivers/net/wireless/ath/ath12k/wmi.c | 3 +++ drivers/net/wireless/ath/ath12k/wmi.h | 3 +++ 2 files changed, 6 insertions(+)