| Message ID | 20240207044559.2717200-1-davidm@egauge.net (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [v5] wifi: wilc1000: validate chip id during bus probe | expand |
On 2/7/24 05:49, David Mosberger-Tang wrote: > Previously, the driver created a net device (typically wlan0) as soon > as the module was loaded. This commit changes the driver to follow > normal Linux convention of creating the net device only when bus > probing detects a supported chip. Running your series on my platform showed some new warnings in the nominal case (ie when module is correctly wired onto the SPI bus), but after digging a bit, I doubt it is due to your patch. Applying some specific reverts makes me think that the issue is somewhere around recent XDMAC PM runtime support, especially 650b0e990cbd ("dmaengine: at_xdmac: add runtime pm support") (Ccing Claudiu Beznea for a second opinion, + traces below) So ignoring that, LGTM, and wlan0 indeed does not appear after boot when I mess with the module wiring on the bus. Tested-by: Alexis Lothoré <alexis.lothore@bootlin.com> --- Traces of the locking warnings, observed on SAMA5D27-WLSOM1-EVK: BUG: sleeping function called from invalid context at drivers/base/power/runtime.c:1164 in_atomic(): 1, irqs_disabled(): 128, non_block: 0, pid: 1, name: swapper preempt_count: 1, expected: 0 4 locks held by swapper/1: #0: c4bc7878 (&dev->mutex){....}-{3:3}, at: __driver_attach+0x218/0x5d4 #1: c43ee3a8 (&ctlr->bus_lock_mutex){+.+.}-{3:3}, at: spi_sync+0x50/0xa8 #2: c43ee2f4 (&ctlr->io_mutex){+.+.}-{3:3}, at: __spi_sync+0x8ac/0xf78 #3: c4128304 (&atchan->lock){....}-{2:2}, at: at_xdmac_issue_pending+0x34/0x164 irq event stamp: 112350 hardirqs last enabled at (112349): [<c1a63dc0>] _raw_spin_unlock_irqrestore+0x8c/0xa8 hardirqs last disabled at (112350): [<c1a639e4>] _raw_spin_lock_irqsave+0xa0/0xac softirqs last enabled at (112326): [<c0101b68>] __do_softirq+0x754/0xad4 softirqs last disabled at (112317): [<c015814c>] __irq_exit_rcu+0x28c/0x34c CPU: 0 PID: 1 Comm: swapper Not tainted 6.8.0-rc1+ #87 Hardware name: Atmel SAMA5 unwind_backtrace from show_stack+0x18/0x1c show_stack from dump_stack_lvl+0x34/0x58 dump_stack_lvl from __might_resched+0x38c/0x598 __might_resched from __pm_runtime_resume+0x108/0x120 __pm_runtime_resume from at_xdmac_chan_is_enabled+0x88/0x230 at_xdmac_chan_is_enabled from at_xdmac_issue_pending+0x40/0x164 at_xdmac_issue_pending from atmel_spi_one_transfer+0xac0/0x38d4 atmel_spi_one_transfer from spi_transfer_one_message+0xbb4/0x1e20 spi_transfer_one_message from __spi_pump_transfer_message+0xa44/0x1a40 __spi_pump_transfer_message from __spi_sync+0x924/0xf78 __spi_sync from spi_sync+0x5c/0xa8 spi_sync from wilc_spi_tx_rx+0x178/0x1ec wilc_spi_tx_rx from wilc_spi_single_read+0x1b4/0x5f8 wilc_spi_single_read from spi_internal_read+0xc0/0x158 spi_internal_read from wilc_spi_configure_bus_protocol+0x1e4/0x464 wilc_spi_configure_bus_protocol from wilc_bus_probe+0x4fc/0x838 wilc_bus_probe from spi_probe+0x158/0x1b0 spi_probe from really_probe+0x270/0xdf4 really_probe from __driver_probe_device+0x1dc/0x580 __driver_probe_device from driver_probe_device+0x60/0x140 driver_probe_device from __driver_attach+0x228/0x5d4 __driver_attach from bus_for_each_dev+0x13c/0x1a8 bus_for_each_dev from bus_add_driver+0x2a0/0x608 bus_add_driver from driver_register+0x24c/0x578 driver_register from do_one_initcall+0x180/0x310 do_one_initcall from kernel_init_freeable+0x424/0x484 kernel_init_freeable from kernel_init+0x20/0x148 kernel_init from ret_from_fork+0x14/0x28 Exception stack(0xc396bfb0 to 0xc396bff8) bfa0: 00000000 00000000 00000000 00000000 bfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 bfe0: 00000000 00000000 00000000 00000000 00000013 00000000 ================================ WARNING: inconsistent lock state 6.8.0-rc1+ #87 Tainted: G W -------------------------------- inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage. swapper/1 [HC0[0]:SC1[1]:HE0:SE0] takes: c4128220 (&atchan->lock){+.?.}-{2:2}, at: at_xdmac_tasklet+0x108/0x1350 {SOFTIRQ-ON-W} state was registered at: lockdep_hardirqs_on_prepare+0x338/0x5c4 trace_hardirqs_on+0xdc/0x368 _raw_spin_unlock_irq+0x28/0x7c __rpm_callback+0x160/0x370 rpm_callback+0x118/0x148 rpm_resume+0xbac/0x1438 __pm_runtime_resume+0xb8/0x120 at_xdmac_chan_is_enabled+0x88/0x230 at_xdmac_issue_pending+0x40/0x164 atmel_spi_one_transfer+0xac0/0x38d4 spi_transfer_one_message+0xbb4/0x1e20 __spi_pump_transfer_message+0xa44/0x1a40 __spi_sync+0x924/0xf78 spi_sync+0x5c/0xa8 wilc_spi_tx_rx+0x178/0x1ec wilc_spi_single_read+0x1b4/0x5f8 spi_internal_read+0xc0/0x158 wilc_spi_configure_bus_protocol+0x1e4/0x464 wilc_bus_probe+0x4fc/0x838 spi_probe+0x158/0x1b0 really_probe+0x270/0xdf4 __driver_probe_device+0x1dc/0x580 driver_probe_device+0x60/0x140 __driver_attach+0x228/0x5d4 bus_for_each_dev+0x13c/0x1a8 bus_add_driver+0x2a0/0x608 driver_register+0x24c/0x578 do_one_initcall+0x180/0x310 kernel_init_freeable+0x424/0x484 kernel_init+0x20/0x148 ret_from_fork+0x14/0x28 irq event stamp: 112385 hardirqs last enabled at (112384): [<c015888c>] tasklet_action_common+0xa4/0xbdc hardirqs last disabled at (112385): [<c1a63938>] _raw_spin_lock_irq+0x9c/0xa8 softirqs last enabled at (112368): [<c0101b68>] __do_softirq+0x754/0xad4 softirqs last disabled at (112381): [<c015814c>] __irq_exit_rcu+0x28c/0x34c other info that might help us debug this: Possible unsafe locking scenario: CPU0 ---- lock(&atchan->lock); <Interrupt> lock(&atchan->lock); *** DEADLOCK *** 3 locks held by swapper/1: #0: c4bc7878 (&dev->mutex){....}-{3:3}, at: __driver_attach+0x218/0x5d4 #1: c43ee3a8 (&ctlr->bus_lock_mutex){+.+.}-{3:3}, at: spi_sync+0x50/0xa8 #2: c43ee2f4 (&ctlr->io_mutex){+.+.}-{3:3}, at: __spi_sync+0x8ac/0xf78 stack backtrace: CPU: 0 PID: 1 Comm: swapper Tainted: G W 6.8.0-rc1+ #87 Hardware name: Atmel SAMA5 unwind_backtrace from show_stack+0x18/0x1c show_stack from dump_stack_lvl+0x34/0x58 dump_stack_lvl from mark_lock+0x21c8/0x3628 mark_lock from __lock_acquire+0x14e4/0x54bc __lock_acquire from lock_acquire.part.0+0x1a0/0x420 lock_acquire.part.0 from _raw_spin_lock_irq+0x88/0xa8 _raw_spin_lock_irq from at_xdmac_tasklet+0x108/0x1350 at_xdmac_tasklet from tasklet_action_common+0x4a8/0xbdc tasklet_action_common from __do_softirq+0x2f4/0xad4 __do_softirq from __irq_exit_rcu+0x28c/0x34c __irq_exit_rcu from irq_exit+0x10/0x28 irq_exit from call_with_stack+0x18/0x20 call_with_stack from __irq_svc+0x80/0x9c Exception stack(0xc396b4c0 to 0xc396b508) b4c0: 00000080 00000001 00011fb2 200000d3 60000053 c4128210 c4128244 c4128160 b4e0: d08cd028 00000013 b782502c c396b900 00000000 c396b510 c1a45fbc c1a63d74 b500: 20000053 ffffffff __irq_svc from _raw_spin_unlock_irqrestore+0x40/0xa8 _raw_spin_unlock_irqrestore from atmel_spi_one_transfer+0xb34/0x38d4 atmel_spi_one_transfer from spi_transfer_one_message+0xbb4/0x1e20 spi_transfer_one_message from __spi_pump_transfer_message+0xa44/0x1a40 __spi_pump_transfer_message from __spi_sync+0x924/0xf78 __spi_sync from spi_sync+0x5c/0xa8 spi_sync from wilc_spi_tx_rx+0x178/0x1ec wilc_spi_tx_rx from wilc_spi_single_read+0x1b4/0x5f8 wilc_spi_single_read from spi_internal_read+0xc0/0x158 spi_internal_read from wilc_spi_configure_bus_protocol+0x1e4/0x464 wilc_spi_configure_bus_protocol from wilc_bus_probe+0x4fc/0x838 wilc_bus_probe from spi_probe+0x158/0x1b0 spi_probe from really_probe+0x270/0xdf4 really_probe from __driver_probe_device+0x1dc/0x580 __driver_probe_device from driver_probe_device+0x60/0x140 driver_probe_device from __driver_attach+0x228/0x5d4 __driver_attach from bus_for_each_dev+0x13c/0x1a8 bus_for_each_dev from bus_add_driver+0x2a0/0x608 bus_add_driver from driver_register+0x24c/0x578 driver_register from do_one_initcall+0x180/0x310 do_one_initcall from kernel_init_freeable+0x424/0x484 kernel_init_freeable from kernel_init+0x20/0x148 kernel_init from ret_from_fork+0x14/0x28 Exception stack(0xc396bfb0 to 0xc396bff8) bfa0: 00000000 00000000 00000000 00000000 bfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 bfe0: 00000000 00000000 00000000 00000000 00000013 00000000
David Mosberger-Tang <davidm@egauge.net> writes: > Previously, the driver created a net device (typically wlan0) as soon > as the module was loaded. This commit changes the driver to follow > normal Linux convention of creating the net device only when bus > probing detects a supported chip. > > Signed-off-by: David Mosberger-Tang <davidm@egauge.net> > --- > drivers/net/wireless/microchip/wilc1000/spi.c | 69 +++++++++++++++---- > .../net/wireless/microchip/wilc1000/wlan.c | 3 +- > .../net/wireless/microchip/wilc1000/wlan.h | 1 + > 3 files changed, 57 insertions(+), 16 deletions(-) [...] > --- a/drivers/net/wireless/microchip/wilc1000/wlan.c > +++ b/drivers/net/wireless/microchip/wilc1000/wlan.c > @@ -12,10 +12,11 @@ > > #define WAKE_UP_TRIAL_RETRY 10000 > > -static inline bool is_wilc1000(u32 id) > +bool is_wilc1000(u32 id) > { > return (id & (~WILC_CHIP_REV_FIELD)) == WILC_1000_BASE_ID; > } > +EXPORT_SYMBOL_GPL(is_wilc1000); > > static inline void acquire_bus(struct wilc *wilc, enum bus_acquire acquire) > { > diff --git a/drivers/net/wireless/microchip/wilc1000/wlan.h b/drivers/net/wireless/microchip/wilc1000/wlan.h > index f02775f7e41f..ebdfb0afaf71 100644 > --- a/drivers/net/wireless/microchip/wilc1000/wlan.h > +++ b/drivers/net/wireless/microchip/wilc1000/wlan.h > @@ -409,6 +409,7 @@ struct wilc_cfg_rsp { > > struct wilc_vif; > > +bool is_wilc1000(u32 id); I was about to apply this but then noticed the new EXPORT_SYMBOL_GPL(). The overhead for such tiny function sounds too much, much better to move the static inline function to wlan.h.
On Mon, 2024-02-12 at 17:15 +0200, Kalle Valo wrote: > David Mosberger-Tang <davidm@egauge.net> writes: > > > Previously, the driver created a net device (typically wlan0) as soon > > as the module was loaded. This commit changes the driver to follow > > normal Linux convention of creating the net device only when bus > > probing detects a supported chip. > > > > Signed-off-by: David Mosberger-Tang <davidm@egauge.net> > > --- > > drivers/net/wireless/microchip/wilc1000/spi.c | 69 +++++++++++++++---- > > .../net/wireless/microchip/wilc1000/wlan.c | 3 +- > > .../net/wireless/microchip/wilc1000/wlan.h | 1 + > > 3 files changed, 57 insertions(+), 16 deletions(-) > > [...] > > > --- a/drivers/net/wireless/microchip/wilc1000/wlan.c > > +++ b/drivers/net/wireless/microchip/wilc1000/wlan.c > > @@ -12,10 +12,11 @@ > > > > #define WAKE_UP_TRIAL_RETRY 10000 > > > > -static inline bool is_wilc1000(u32 id) > > +bool is_wilc1000(u32 id) > > { > > return (id & (~WILC_CHIP_REV_FIELD)) == WILC_1000_BASE_ID; > > } > > +EXPORT_SYMBOL_GPL(is_wilc1000); > > > > static inline void acquire_bus(struct wilc *wilc, enum bus_acquire acquire) > > { > > diff --git a/drivers/net/wireless/microchip/wilc1000/wlan.h b/drivers/net/wireless/microchip/wilc1000/wlan.h > > index f02775f7e41f..ebdfb0afaf71 100644 > > --- a/drivers/net/wireless/microchip/wilc1000/wlan.h > > +++ b/drivers/net/wireless/microchip/wilc1000/wlan.h > > @@ -409,6 +409,7 @@ struct wilc_cfg_rsp { > > > > struct wilc_vif; > > > > +bool is_wilc1000(u32 id); > > I was about to apply this but then noticed the new EXPORT_SYMBOL_GPL(). > The overhead for such tiny function sounds too much, much better to move > the static inline function to wlan.h. Good point. I just sent V6 which has the inline function moved to wlan.h. Thanks, --david
diff --git a/drivers/net/wireless/microchip/wilc1000/spi.c b/drivers/net/wireless/microchip/wilc1000/spi.c index 7eb0f8a421a3..fdbd46b882b9 100644 --- a/drivers/net/wireless/microchip/wilc1000/spi.c +++ b/drivers/net/wireless/microchip/wilc1000/spi.c @@ -42,7 +42,7 @@ MODULE_PARM_DESC(enable_crc16, #define WILC_SPI_RSP_HDR_EXTRA_DATA 8 struct wilc_spi { - bool isinit; /* true if SPI protocol has been configured */ + bool isinit; /* true if wilc_spi_init was successful */ bool probing_crc; /* true if we're probing chip's CRC config */ bool crc7_enabled; /* true if crc7 is currently enabled */ bool crc16_enabled; /* true if crc16 is currently enabled */ @@ -55,6 +55,8 @@ struct wilc_spi { static const struct wilc_hif_func wilc_hif_spi; static int wilc_spi_reset(struct wilc *wilc); +static int wilc_spi_configure_bus_protocol(struct wilc *wilc); +static int wilc_validate_chipid(struct wilc *wilc); /******************************************** * @@ -232,8 +234,27 @@ static int wilc_bus_probe(struct spi_device *spi) } clk_prepare_enable(wilc->rtc_clk); + dev_info(&spi->dev, "Selected CRC config: crc7=%s, crc16=%s\n", + enable_crc7 ? "on" : "off", enable_crc16 ? "on" : "off"); + + /* we need power to configure the bus protocol and to read the chip id: */ + + wilc_wlan_power(wilc, true); + + ret = wilc_spi_configure_bus_protocol(wilc); + if (ret) + goto power_down; + + ret = wilc_validate_chipid(wilc); + if (ret) + goto power_down; + + wilc_wlan_power(wilc, false); return 0; +power_down: + clk_disable_unprepare(wilc->rtc_clk); + wilc_wlan_power(wilc, false); netdev_cleanup: wilc_netdev_cleanup(wilc); free: @@ -1101,26 +1122,34 @@ static int wilc_spi_deinit(struct wilc *wilc) static int wilc_spi_init(struct wilc *wilc, bool resume) { - struct spi_device *spi = to_spi_device(wilc->dev); struct wilc_spi *spi_priv = wilc->bus_data; - u32 reg; - u32 chipid; - int ret, i; + int ret; if (spi_priv->isinit) { /* Confirm we can read chipid register without error: */ - ret = wilc_spi_read_reg(wilc, WILC_CHIPID, &chipid); - if (ret == 0) + if (wilc_validate_chipid(wilc) == 0) return 0; - - dev_err(&spi->dev, "Fail cmd read chip id...\n"); } wilc_wlan_power(wilc, true); - /* - * configure protocol - */ + ret = wilc_spi_configure_bus_protocol(wilc); + if (ret) { + wilc_wlan_power(wilc, false); + return ret; + } + + spi_priv->isinit = true; + + return 0; +} + +static int wilc_spi_configure_bus_protocol(struct wilc *wilc) +{ + struct spi_device *spi = to_spi_device(wilc->dev); + struct wilc_spi *spi_priv = wilc->bus_data; + u32 reg; + int ret, i; /* * Infer the CRC settings that are currently in effect. This @@ -1172,6 +1201,15 @@ static int wilc_spi_init(struct wilc *wilc, bool resume) spi_priv->probing_crc = false; + return 0; +} + +static int wilc_validate_chipid(struct wilc *wilc) +{ + struct spi_device *spi = to_spi_device(wilc->dev); + u32 chipid; + int ret; + /* * make sure can read chip id without protocol error */ @@ -1180,9 +1218,10 @@ static int wilc_spi_init(struct wilc *wilc, bool resume) dev_err(&spi->dev, "Fail cmd read chip id...\n"); return ret; } - - spi_priv->isinit = true; - + if (!is_wilc1000(chipid)) { + dev_err(&spi->dev, "Unknown chip id 0x%x\n", chipid); + return -ENODEV; + } return 0; } diff --git a/drivers/net/wireless/microchip/wilc1000/wlan.c b/drivers/net/wireless/microchip/wilc1000/wlan.c index 6b2f2269ddf8..3130a3ea8d71 100644 --- a/drivers/net/wireless/microchip/wilc1000/wlan.c +++ b/drivers/net/wireless/microchip/wilc1000/wlan.c @@ -12,10 +12,11 @@ #define WAKE_UP_TRIAL_RETRY 10000 -static inline bool is_wilc1000(u32 id) +bool is_wilc1000(u32 id) { return (id & (~WILC_CHIP_REV_FIELD)) == WILC_1000_BASE_ID; } +EXPORT_SYMBOL_GPL(is_wilc1000); static inline void acquire_bus(struct wilc *wilc, enum bus_acquire acquire) { diff --git a/drivers/net/wireless/microchip/wilc1000/wlan.h b/drivers/net/wireless/microchip/wilc1000/wlan.h index f02775f7e41f..ebdfb0afaf71 100644 --- a/drivers/net/wireless/microchip/wilc1000/wlan.h +++ b/drivers/net/wireless/microchip/wilc1000/wlan.h @@ -409,6 +409,7 @@ struct wilc_cfg_rsp { struct wilc_vif; +bool is_wilc1000(u32 id); int wilc_wlan_firmware_download(struct wilc *wilc, const u8 *buffer, u32 buffer_size); int wilc_wlan_start(struct wilc *wilc);
Previously, the driver created a net device (typically wlan0) as soon as the module was loaded. This commit changes the driver to follow normal Linux convention of creating the net device only when bus probing detects a supported chip. Signed-off-by: David Mosberger-Tang <davidm@egauge.net> --- drivers/net/wireless/microchip/wilc1000/spi.c | 69 +++++++++++++++---- .../net/wireless/microchip/wilc1000/wlan.c | 3 +- .../net/wireless/microchip/wilc1000/wlan.h | 1 + 3 files changed, 57 insertions(+), 16 deletions(-) --- changelog: V1: original version V2: Add missing forward declarations V3: Add missing forward declarations, actually :-( V4: - rearranged function order to improve readability - now relative to wireless-next repository - avoid change error return value and have lower-level functions directly return -ENODEV instead - removed any mention of WILC3000 - export and use existing is_wilc1000() for chipid validation - replaced strbool() function with open code V5: - add clk_disable_unprepare() to power_down path as suggested by Ajay - don't re-write error codes as suggested by Alexi drivers/net/wireless/microchip/wilc1000/spi.c | 74 ++++++++++++++----- .../net/wireless/microchip/wilc1000/wlan.c | 3 +- .../net/wireless/microchip/wilc1000/wlan.h | 1 + 3 files changed, 59 insertions(+), 19 deletions(-)