Message ID | 20240220165842.917CDC433F1@smtp.kernel.org (mailing list archive) |
---|---|
State | Not Applicable |
Delegated to: | Kalle Valo |
Headers | show |
Series | pull-request: wireless-next-2024-02-20 | expand |
Kalle Valo <kvalo@kernel.org> writes: > Hi, > > here's a pull request to net-next tree, more info below. Please let me know if > there are any problems. > > Kalle > > The following changes since commit b7198383ef2debe748118996f627452281cf27d7: > > wifi: iwlwifi: mvm: fix a crash when we run out of stations (2024-02-08 14:55:39 +0100) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git tags/wireless-next-2024-02-20 > > for you to fetch changes up to dd66185c23f71af36397bebfc99ede608dca07b6: > > wifi: wilc1000: add missing read critical sections around vif list traversal (2024-02-19 18:21:36 +0200) > > ---------------------------------------------------------------- > wireless-next patches for v6.9 > > The second "new features" pull request for v6.9. Lots of iwlwifi and > stack changes this time. And naturally smaller changes to other drivers. > > We also twice merged wireless into wireless-next to avoid conflicts > between the trees. > [...] > drivers/net/dsa/mt7530.c | 34 +- > drivers/net/ethernet/engleder/tsnep_main.c | 4 +- > drivers/net/ethernet/google/gve/gve.h | 144 +- > drivers/net/ethernet/google/gve/gve_dqo.h | 18 +- > drivers/net/ethernet/google/gve/gve_main.c | 862 +++--- > drivers/net/ethernet/google/gve/gve_rx.c | 135 +- > drivers/net/ethernet/google/gve/gve_rx_dqo.c | 91 +- > drivers/net/ethernet/google/gve/gve_tx.c | 128 +- > drivers/net/ethernet/google/gve/gve_tx_dqo.c | 108 +- > drivers/net/ethernet/google/gve/gve_utils.c | 31 + > drivers/net/ethernet/google/gve/gve_utils.h | 5 + This diffstat shows extra (non-wireless) changes like the ones above but then actually pulling the these are not shown. I assume 'git pull-request' got again confused due to merging wireless into wireless-next.
Hello: This pull request was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Tue, 20 Feb 2024 16:58:42 +0000 (UTC) you wrote: > Hi, > > here's a pull request to net-next tree, more info below. Please let me know if > there are any problems. > > Kalle > > [...] Here is the summary with links: - pull-request: wireless-next-2024-02-20 https://git.kernel.org/netdev/net-next/c/e199c4ba8260 You are awesome, thank you!
On Tue, 20 Feb 2024 16:58:42 +0000 (UTC) Kalle Valo wrote: > Hi, > > here's a pull request to net-next tree, more info below. Please let me know if > there are any problems. > > Kalle > > The following changes since commit b7198383ef2debe748118996f627452281cf27d7: > > wifi: iwlwifi: mvm: fix a crash when we run out of stations (2024-02-08 14:55:39 +0100) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git tags/wireless-next-2024-02-20 > > for you to fetch changes up to dd66185c23f71af36397bebfc99ede608dca07b6: > > wifi: wilc1000: add missing read critical sections around vif list traversal (2024-02-19 18:21:36 +0200) > > ---------------------------------------------------------------- > wireless-next patches for v6.9 > > The second "new features" pull request for v6.9. Lots of iwlwifi and > stack changes this time. And naturally smaller changes to other drivers. > > We also twice merged wireless into wireless-next to avoid conflicts > between the trees. > > Major changes: > > stack > > * mac80211: negotiated TTLM request support > > * SPP A-MSDU support > > * mac80211: wider bandwidth OFDMA config support > > iwlwifi > > * kunit tests > > * bump FW API to 89 for AX/BZ/SC devices > > * enable SPP A-MSDUs > > * support for new devices > > ath12k > > * refactoring in preparation for Multi-Link Operation (MLO) support > > * 1024 Block Ack window size support > > * provide firmware wmi logs via a trace event > > ath11k > > * 36 bit DMA mask support > > * support 6 GHz station power modes: Low Power Indoor (LPI), Standard > Power) SP and Very Low Power (VLP) > > rtl8xxxu > > * TP-Link TL-WN823N V2 support I'm getting these on a normal (i.e. non-W=1) clang build today: ../drivers/net/wireless/ath/ath12k/mac.c:8000:9: warning: variable 'ret' is uninitialized when used here [-Wuninitialized] 8000 | return ret; | ^~~ ../drivers/net/wireless/ath/ath12k/mac.c:7962:9: note: initialize the variable 'ret' to silence this warning 7962 | int ret, i, j; | ^ | = 0
On 2/21/2024 2:35 PM, Jakub Kicinski wrote: > On Tue, 20 Feb 2024 16:58:42 +0000 (UTC) Kalle Valo wrote: >> Hi, >> >> here's a pull request to net-next tree, more info below. Please let me know if >> there are any problems. >> >> Kalle >> >> The following changes since commit b7198383ef2debe748118996f627452281cf27d7: >> >> wifi: iwlwifi: mvm: fix a crash when we run out of stations (2024-02-08 14:55:39 +0100) >> >> are available in the Git repository at: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git tags/wireless-next-2024-02-20 >> >> for you to fetch changes up to dd66185c23f71af36397bebfc99ede608dca07b6: >> >> wifi: wilc1000: add missing read critical sections around vif list traversal (2024-02-19 18:21:36 +0200) >> >> ---------------------------------------------------------------- >> wireless-next patches for v6.9 >> >> The second "new features" pull request for v6.9. Lots of iwlwifi and >> stack changes this time. And naturally smaller changes to other drivers. >> >> We also twice merged wireless into wireless-next to avoid conflicts >> between the trees. >> >> Major changes: >> >> stack >> >> * mac80211: negotiated TTLM request support >> >> * SPP A-MSDU support >> >> * mac80211: wider bandwidth OFDMA config support >> >> iwlwifi >> >> * kunit tests >> >> * bump FW API to 89 for AX/BZ/SC devices >> >> * enable SPP A-MSDUs >> >> * support for new devices >> >> ath12k >> >> * refactoring in preparation for Multi-Link Operation (MLO) support >> >> * 1024 Block Ack window size support >> >> * provide firmware wmi logs via a trace event >> >> ath11k >> >> * 36 bit DMA mask support >> >> * support 6 GHz station power modes: Low Power Indoor (LPI), Standard >> Power) SP and Very Low Power (VLP) >> >> rtl8xxxu >> >> * TP-Link TL-WN823N V2 support > > I'm getting these on a normal (i.e. non-W=1) clang build today: > > ../drivers/net/wireless/ath/ath12k/mac.c:8000:9: warning: variable 'ret' is uninitialized when used here [-Wuninitialized] > 8000 | return ret; > | ^~~ > ../drivers/net/wireless/ath/ath12k/mac.c:7962:9: note: initialize the variable 'ret' to silence this warning > 7962 | int ret, i, j; > | ^ > | = 0 > definitely a flaw in 6db6e70a17f6 ("wifi: ath12k: Introduce the container for mac80211 hw") my setup is using gcc which isn't flagging this :( Karthikeyan, can you submit a patch? /jeff
On 2/21/2024 3:34 PM, Jeff Johnson wrote: > On 2/21/2024 2:35 PM, Jakub Kicinski wrote: >> On Tue, 20 Feb 2024 16:58:42 +0000 (UTC) Kalle Valo wrote: >>> Hi, >>> >>> here's a pull request to net-next tree, more info below. Please let me know if >>> there are any problems. >>> >>> Kalle >>> >>> The following changes since commit b7198383ef2debe748118996f627452281cf27d7: >>> >>> wifi: iwlwifi: mvm: fix a crash when we run out of stations (2024-02-08 14:55:39 +0100) >>> >>> are available in the Git repository at: >>> >>> git://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git tags/wireless-next-2024-02-20 >>> >>> for you to fetch changes up to dd66185c23f71af36397bebfc99ede608dca07b6: >>> >>> wifi: wilc1000: add missing read critical sections around vif list traversal (2024-02-19 18:21:36 +0200) >>> >>> ---------------------------------------------------------------- >>> wireless-next patches for v6.9 >>> >>> The second "new features" pull request for v6.9. Lots of iwlwifi and >>> stack changes this time. And naturally smaller changes to other drivers. >>> >>> We also twice merged wireless into wireless-next to avoid conflicts >>> between the trees. >>> >>> Major changes: >>> >>> stack >>> >>> * mac80211: negotiated TTLM request support >>> >>> * SPP A-MSDU support >>> >>> * mac80211: wider bandwidth OFDMA config support >>> >>> iwlwifi >>> >>> * kunit tests >>> >>> * bump FW API to 89 for AX/BZ/SC devices >>> >>> * enable SPP A-MSDUs >>> >>> * support for new devices >>> >>> ath12k >>> >>> * refactoring in preparation for Multi-Link Operation (MLO) support >>> >>> * 1024 Block Ack window size support >>> >>> * provide firmware wmi logs via a trace event >>> >>> ath11k >>> >>> * 36 bit DMA mask support >>> >>> * support 6 GHz station power modes: Low Power Indoor (LPI), Standard >>> Power) SP and Very Low Power (VLP) >>> >>> rtl8xxxu >>> >>> * TP-Link TL-WN823N V2 support >> >> I'm getting these on a normal (i.e. non-W=1) clang build today: >> >> ../drivers/net/wireless/ath/ath12k/mac.c:8000:9: warning: variable 'ret' is uninitialized when used here [-Wuninitialized] >> 8000 | return ret; >> | ^~~ >> ../drivers/net/wireless/ath/ath12k/mac.c:7962:9: note: initialize the variable 'ret' to silence this warning >> 7962 | int ret, i, j; >> | ^ >> | = 0 >> > > definitely a flaw in 6db6e70a17f6 ("wifi: ath12k: Introduce the > container for mac80211 hw") > > my setup is using gcc which isn't flagging this :( > > Karthikeyan, can you submit a patch? > > /jeff > I see this was already fixed by: 04edb5dc68f4 ("wifi: ath12k: Fix uninitialized use of ret in ath12k_mac_allocate()")
On Wed, 21 Feb 2024 17:18:41 -0800 Jeff Johnson wrote: > > definitely a flaw in 6db6e70a17f6 ("wifi: ath12k: Introduce the > > container for mac80211 hw") > > > > my setup is using gcc which isn't flagging this :( > > > > Karthikeyan, can you submit a patch? > > I see this was already fixed by: > 04edb5dc68f4 ("wifi: ath12k: Fix uninitialized use of ret in > ath12k_mac_allocate()") In wireless-next? Could you do a quick follow up PR so that it gets into net-next before the warning propagates into more of the networking sub-trees?
Jakub Kicinski <kuba@kernel.org> writes: > On Wed, 21 Feb 2024 17:18:41 -0800 Jeff Johnson wrote: >> > definitely a flaw in 6db6e70a17f6 ("wifi: ath12k: Introduce the >> > container for mac80211 hw") >> > >> > my setup is using gcc which isn't flagging this :( >> > >> > Karthikeyan, can you submit a patch? >> >> I see this was already fixed by: >> 04edb5dc68f4 ("wifi: ath12k: Fix uninitialized use of ret in >> ath12k_mac_allocate()") > > In wireless-next? Could you do a quick follow up PR so that > it gets into net-next before the warning propagates into more > of the networking sub-trees? The fix is in ath-next but I'll pull ath-next into wireless-next and then send a wireless-next pull request. So you should have the pull request in few hours. Sorry about this, I somehow understood this was a W=1 warning and didn't prioritise the fix. After re-reading the commit message I can't understand why I made that assumption, my bad. What worries me is that the kbuild bot didn't warn this at all (or I missed that as well). Is it using older clang version or what?
Kalle Valo <kvalo@kernel.org> writes: > Jakub Kicinski <kuba@kernel.org> writes: > >> On Wed, 21 Feb 2024 17:18:41 -0800 Jeff Johnson wrote: >>> > definitely a flaw in 6db6e70a17f6 ("wifi: ath12k: Introduce the >>> > container for mac80211 hw") >>> > >>> > my setup is using gcc which isn't flagging this :( >>> > >>> > Karthikeyan, can you submit a patch? >>> >>> I see this was already fixed by: >>> 04edb5dc68f4 ("wifi: ath12k: Fix uninitialized use of ret in >>> ath12k_mac_allocate()") >> >> In wireless-next? Could you do a quick follow up PR so that >> it gets into net-next before the warning propagates into more >> of the networking sub-trees? > > The fix is in ath-next but I'll pull ath-next into wireless-next and > then send a wireless-next pull request. So you should have the pull > request in few hours. The pull request is sent: https://patchwork.kernel.org/project/netdevbpf/patch/20240222105205.CEC54C433F1@smtp.kernel.org/ Of course the ath patches haven't been in linux-next yet so let's hope that we are not introducing new problems. We need to add ath-next into linux-next to catch problems as early as possible.
On Thu, 22 Feb 2024 12:59:08 +0200 Kalle Valo wrote: > The pull request is sent: > > https://patchwork.kernel.org/project/netdevbpf/patch/20240222105205.CEC54C433F1@smtp.kernel.org/ Thank you, much appreciated.