| Message ID | 20240306112558.163415-1-rand.sec96@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [v2] ssb: Fix potential NULL pointer dereference in ssb_device_uevent | expand |
Rand Deeb <rand.sec96@gmail.com> writes: > Hi Kalle, > > It seems there's been a mix-up in applying the patch. The previous patch > was intended for the linux-5.10.y branch, not the master branch. I > appreciate your attention to detail. > > The following patch has been tailored for the master branch and should > resolve the issue properly. Thank you for your understanding. This text should be below '---' line so that it's not included to the git history and you should restore the original commit message. Please submit v3 with the correct commit message and please also read the wiki link below.
diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c index b9934b9c2d70..070a99a4180c 100644 --- a/drivers/ssb/main.c +++ b/drivers/ssb/main.c @@ -341,11 +341,13 @@ static int ssb_bus_match(struct device *dev, struct device_driver *drv) static int ssb_device_uevent(const struct device *dev, struct kobj_uevent_env *env) { - const struct ssb_device *ssb_dev = dev_to_ssb_dev(dev); + const struct ssb_device *ssb_dev; if (!dev) return -ENODEV; + ssb_dev = dev_to_ssb_dev(dev); + return add_uevent_var(env, "MODALIAS=ssb:v%04Xid%04Xrev%02X", ssb_dev->id.vendor, ssb_dev->id.coreid,
Hi Kalle, It seems there's been a mix-up in applying the patch. The previous patch was intended for the linux-5.10.y branch, not the master branch. I appreciate your attention to detail. The following patch has been tailored for the master branch and should resolve the issue properly. Thank you for your understanding. Signed-off-by: Rand Deeb <rand.sec96@gmail.com> --- drivers/ssb/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)