| Message ID | 20240320182449.3757215-2-kvalo@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ed769314f55cef504e1a1fe505ef98c45185f371 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wifi: ath: fix remaining sparse warnings (excluding ath9k) | expand |
Kalle Valo <kvalo@kernel.org> wrote: > Sparse warns: > > drivers/net/wireless/ath/ath6kl/htc_pipe.c:241:17: warning: incorrect type in assignment (different base types) > drivers/net/wireless/ath/ath6kl/htc_pipe.c:241:17: expected restricted __le16 x > drivers/net/wireless/ath/ath6kl/htc_pipe.c:241:17: got unsigned short [usertype] > drivers/net/wireless/ath/ath6kl/htc_mbox.c:368:9: warning: incorrect type in assignment (different base types) > drivers/net/wireless/ath/ath6kl/htc_mbox.c:368:9: expected restricted __le16 x > drivers/net/wireless/ath/ath6kl/htc_mbox.c:368:9: got unsigned short [usertype] > > Use put_unaligned_le16() so that the value is converted to little endian before > storing it to the header. > > Compile tested only. > > Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> 4 patches applied to ath-next branch of ath.git, thanks. ed769314f55c wifi: ath6kl: fix sparse warnings fba52950e59d wifi: wcn36xx: buff_to_be(): fix sparse warnings 1eb2ac4a9f3f wifi: wcn36xx: main: fix sparse warnings 1f4672fd1648 wifi: wil6210: fix sparse warnings
diff --git a/drivers/net/wireless/ath/ath6kl/htc_mbox.c b/drivers/net/wireless/ath/ath6kl/htc_mbox.c index 1963d3145481..fb5144e2d86c 100644 --- a/drivers/net/wireless/ath/ath6kl/htc_mbox.c +++ b/drivers/net/wireless/ath/ath6kl/htc_mbox.c @@ -364,8 +364,7 @@ static void ath6kl_htc_tx_prep_pkt(struct htc_packet *packet, u8 flags, packet->buf -= HTC_HDR_LENGTH; hdr = (struct htc_frame_hdr *)packet->buf; - /* Endianess? */ - put_unaligned((u16)packet->act_len, &hdr->payld_len); + put_unaligned_le16(packet->act_len, &hdr->payld_len); hdr->flags = flags; hdr->eid = packet->endpoint; hdr->ctrl[0] = ctrl0; diff --git a/drivers/net/wireless/ath/ath6kl/htc_pipe.c b/drivers/net/wireless/ath/ath6kl/htc_pipe.c index 9b88d96bfe96..2f2edfe43761 100644 --- a/drivers/net/wireless/ath/ath6kl/htc_pipe.c +++ b/drivers/net/wireless/ath/ath6kl/htc_pipe.c @@ -237,8 +237,7 @@ static int htc_issue_packets(struct htc_target *target, packet->info.tx.flags |= HTC_FLAGS_TX_FIXUP_NETBUF; - /* Endianess? */ - put_unaligned((u16) payload_len, &htc_hdr->payld_len); + put_unaligned_le16(payload_len, &htc_hdr->payld_len); htc_hdr->flags = packet->info.tx.flags; htc_hdr->eid = (u8) packet->endpoint; htc_hdr->ctrl[0] = 0;