From patchwork Fri Mar 29 17:10:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13610841 X-Patchwork-Delegate: kvalo@adurom.com Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0ACA1327F5 for ; Fri, 29 Mar 2024 17:10:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711732234; cv=none; b=jfUeb0ajLGpYwuCjaMXvuHjVUcfk6U/H2GF3zlckp3sTFguDo22MWrbDDm8gyjoZbwEyfE1s7o6P6KVgVZuv8jKQIXzLhj1M5xZJWQJoByeLdedcS4TUl2/8HuuBbFi2Pa7aPQLvPvSxS9NuAR/ZkSonqd6I+yJwcdSaF3VAN94= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711732234; c=relaxed/simple; bh=8PHeUGU+ZRvrLa0WyO7pGv+/fClxC3Ext0tzuOtYQUQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=nuL6VHFfulD386nKLVWbdqHvzHy0ELwVrxuI8xjPCcWyep/nZTPlVgjzc7JB+H6v4xA4AV9vjH250+v69AtzePwDpzNTZCtaS6lDhwbe0jHW1Q+HnspBGPHh99hBy139UrX9ffsB9Iymrif6GrmACQPMwdClHaXNORouvnAXMA4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=cUmmw78W; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cUmmw78W" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-415446af364so10214265e9.0 for ; Fri, 29 Mar 2024 10:10:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711732231; x=1712337031; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xXP8LCcnnVa9d+y1k6oL+GlmX9060FPKOT56CxvkCmk=; b=cUmmw78WVNZx/+hCd2kDLwk3hExyp5chDzgNFU59CWAfjgvb9pzWBdsBKdtb3qIqik EeQz2f2R/73UGAofqdr/PqZ/PjKMm6kCJk8jcMTDXwHRZW5XHMlsoQkS0TkysKJ6F8kD 6bO08tCh+VSh5yWG8pk9bShZT+35/yu63F94/DKZZ4FO7jaLXVkHmLTuvMW3DVIEBvMN kx7ceuk4Q/6NRAMGuzcB9UEcJQDEzAApY4UrZfAwy1p09ST743MARw+UikY0cavfxzRy mZPtCY4GElNeWvhL6lLLIoJ4il3Cy08tlbhNLP7zm0U8dUSL4cBx7kAVWcMzU3j0kbHx MJ5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711732231; x=1712337031; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xXP8LCcnnVa9d+y1k6oL+GlmX9060FPKOT56CxvkCmk=; b=N3CbelgP6WiPvZ+OHYXv3IyeQm7j1lwNRh3ElhFIdhd6GDWA54CSEd1DiIyrjIAekx 90zkTLPrSGtMmLfOBTgXBr/7FTIcdyairIusP9jzXqvMWCxjflfmLKQQDMAawaYbds1p 8ww6qK7JQWAb63twafdpt4bJAEiEokkI9sAFPQJCN/ScNWjhmadIiFh/ozdEdjm1QF2l YOJa9hGd4HBDcYfTtGfGhiDMh2EvxQcO09DhFvwr5pDAWk6PJzhAOk+3cwSCe2oi3FWm G8i78RPskseGqGLQJqv4at6hKtsBbWhAR+2+FuFgST1fcWIDNQ10EOMh1PnSoLBdpPHk x0qg== X-Forwarded-Encrypted: i=1; AJvYcCVer49hwQOtvM7t0Y8taCqm9FmlyQ2/4Izn89phqqbsTXs3mrgMP8yiI4+mOyoN6jHIL2QOTqdDRXeimtY8s9XP2/blJV1zyrF5E4diAp0= X-Gm-Message-State: AOJu0YxIW1R30QAs6wsRfIA8VvxkKWWn4RWTWiS/l0XTBCT348d6iCfd pLlDjC4gQyCPRQZqyu43VfYoCxznWC+tpmXOwtVkzqmplBPZp0sftxhkAAJp5gg= X-Google-Smtp-Source: AGHT+IGESeQn/WY+9sDt6AYXXFEGPsBJDLNgHvdN9tKgNTMhMDCcaxBcRgMFF4AuYYmG6bqCbcDOXw== X-Received: by 2002:a05:600c:4e94:b0:413:fdc2:d9da with SMTP id f20-20020a05600c4e9400b00413fdc2d9damr2587780wmq.12.1711732231217; Fri, 29 Mar 2024 10:10:31 -0700 (PDT) Received: from krzk-bin.. ([178.197.223.16]) by smtp.gmail.com with ESMTPSA id o17-20020a5d6851000000b0033ec9936909sm4577665wrw.39.2024.03.29.10.10.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Mar 2024 10:10:30 -0700 (PDT) From: Krzysztof Kozlowski To: Kalle Valo , Jeff Johnson , Brian Norris , Ajay Singh , Claudiu Beznea , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 3/6] wifi: rsi: sdio: simplify module initialization Date: Fri, 29 Mar 2024 18:10:16 +0100 Message-Id: <20240329171019.63836-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240329171019.63836-1-krzysztof.kozlowski@linaro.org> References: <20240329171019.63836-1-krzysztof.kozlowski@linaro.org> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This driver's initialization functions do not perform any custom code, except printing messages. Printing messages on modules loading/unloading is discouraged because it pollutes the dmesg regardless whether user actually has this device. Core kernel code already gives tools to investigate whether module was loaded or not. Drop the printing messages which allows to replace open-coded module_sdio_driver(). Signed-off-by: Krzysztof Kozlowski --- drivers/net/wireless/rsi/rsi_91x_sdio.c | 31 +------------------------ 1 file changed, 1 insertion(+), 30 deletions(-) diff --git a/drivers/net/wireless/rsi/rsi_91x_sdio.c b/drivers/net/wireless/rsi/rsi_91x_sdio.c index 8e7b757475d2..1e578533e473 100644 --- a/drivers/net/wireless/rsi/rsi_91x_sdio.c +++ b/drivers/net/wireless/rsi/rsi_91x_sdio.c @@ -1519,36 +1519,7 @@ static struct sdio_driver rsi_driver = { } #endif }; - -/** - * rsi_module_init() - This function registers the sdio module. - * @void: Void. - * - * Return: 0 on success. - */ -static int rsi_module_init(void) -{ - int ret; - - ret = sdio_register_driver(&rsi_driver); - rsi_dbg(INIT_ZONE, "%s: Registering driver\n", __func__); - return ret; -} - -/** - * rsi_module_exit() - This function unregisters the sdio module. - * @void: Void. - * - * Return: None. - */ -static void rsi_module_exit(void) -{ - sdio_unregister_driver(&rsi_driver); - rsi_dbg(INFO_ZONE, "%s: Unregistering driver\n", __func__); -} - -module_init(rsi_module_init); -module_exit(rsi_module_exit); +module_sdio_driver(rsi_driver); MODULE_AUTHOR("Redpine Signals Inc"); MODULE_DESCRIPTION("Common SDIO layer for RSI drivers");