| Message ID | 20240711020344.98040-2-quic_bqiang@quicinc.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d50886b27850447d90c0cd40c725238097909d1e |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wifi: ath10k: fix invalid VHT parameters | expand |
On 7/10/2024 7:03 PM, Baochen Qiang wrote: > In supported_vht_mcs_rate_nss1, the rate for MCS9 & VHT20 is defined as > {780, 867}, this does not align with firmware's definition and therefore > fails the verification in ath10k_mac_get_rate_flags_vht(): > > invalid vht params rate 960 100kbps nss 1 mcs 9 > > Change it to {865, 960} to align with firmware, so this issue could be > fixed. > > Since ath10k_hw_params::supports_peer_stats_info is enabled only for > QCA6174, this change does not affect other chips. > > Tested-on: QCA6174 hw3.2 PCI WLAN.RM.4.4.1-00309-QCARMSWPZ-1 > > Fixes: 3344b99d69ab ("ath10k: add bitrate parse for peer stats info") > Reported-by: Paul Menzel <pmenzel@molgen.mpg.de> > Closes: https://lore.kernel.org/lkml/fba24cd3-4a1e-4072-8585-8402272788ff@molgen.mpg.de/ > Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Baochen Qiang <quic_bqiang@quicinc.com> wrote: > In supported_vht_mcs_rate_nss1, the rate for MCS9 & VHT20 is defined as > {780, 867}, this does not align with firmware's definition and therefore > fails the verification in ath10k_mac_get_rate_flags_vht(): > > invalid vht params rate 960 100kbps nss 1 mcs 9 > > Change it to {865, 960} to align with firmware, so this issue could be > fixed. > > Since ath10k_hw_params::supports_peer_stats_info is enabled only for > QCA6174, this change does not affect other chips. > > Tested-on: QCA6174 hw3.2 PCI WLAN.RM.4.4.1-00309-QCARMSWPZ-1 > > Fixes: 3344b99d69ab ("ath10k: add bitrate parse for peer stats info") > Reported-by: Paul Menzel <pmenzel@molgen.mpg.de> > Closes: https://lore.kernel.org/lkml/fba24cd3-4a1e-4072-8585-8402272788ff@molgen.mpg.de/ > Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com> > Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com> > Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> 2 patches applied to ath-next branch of ath.git, thanks. d50886b27850 wifi: ath10k: fix invalid VHT parameters in supported_vht_mcs_rate_nss1 52db16ec5bae wifi: ath10k: fix invalid VHT parameters in supported_vht_mcs_rate_nss2
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index a5da32e87106..3c34f3d8e555 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -9121,7 +9121,7 @@ static const struct ath10k_index_vht_data_rate_type supported_vht_mcs_rate_nss1[ {6, {2633, 2925}, {1215, 1350}, {585, 650} }, {7, {2925, 3250}, {1350, 1500}, {650, 722} }, {8, {3510, 3900}, {1620, 1800}, {780, 867} }, - {9, {3900, 4333}, {1800, 2000}, {780, 867} } + {9, {3900, 4333}, {1800, 2000}, {865, 960} } }; /*MCS parameters with Nss = 2 */
In supported_vht_mcs_rate_nss1, the rate for MCS9 & VHT20 is defined as {780, 867}, this does not align with firmware's definition and therefore fails the verification in ath10k_mac_get_rate_flags_vht(): invalid vht params rate 960 100kbps nss 1 mcs 9 Change it to {865, 960} to align with firmware, so this issue could be fixed. Since ath10k_hw_params::supports_peer_stats_info is enabled only for QCA6174, this change does not affect other chips. Tested-on: QCA6174 hw3.2 PCI WLAN.RM.4.4.1-00309-QCARMSWPZ-1 Fixes: 3344b99d69ab ("ath10k: add bitrate parse for peer stats info") Reported-by: Paul Menzel <pmenzel@molgen.mpg.de> Closes: https://lore.kernel.org/lkml/fba24cd3-4a1e-4072-8585-8402272788ff@molgen.mpg.de/ Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com> --- drivers/net/wireless/ath/ath10k/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)