| Message ID | 20240719062414.21953-7-pkshih@realtek.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Ping-Ke Shih |
| Headers | show |
| Series | wifi: rtw89: 8852bt: enable 8852BE-VT | expand |
Hi Ping-Ke,
kernel test robot noticed the following build warnings:
[auto build test WARNING on wireless-next/main]
[also build test WARNING on linus/master next-20240719]
[cannot apply to wireless/main v6.10]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Ping-Ke-Shih/wifi-rtw89-8852bt-add-set_channel_rf/20240719-161236
base: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
patch link: https://lore.kernel.org/r/20240719062414.21953-7-pkshih%40realtek.com
patch subject: [PATCH v2 6/6] wifi: rtw89: 8852bt: add 8852BE-VT to Makefile and Kconfig
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240720/202407200741.dMG9uvHU-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240720/202407200741.dMG9uvHU-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407200741.dMG9uvHU-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/net/wireless/realtek/rtw89/rtw8852bt_rfk.c:1827:46: warning: operator '?:' has lower precedence than '&'; '&' will be evaluated first [-Wbitwise-conditional-parentheses]
1827 | kidx, dpk->is_dpk_enable & off_reverse ? "enable" : "disable");
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
drivers/net/wireless/realtek/rtw89/rtw8852bt_rfk.c:1827:46: note: place parentheses around the '&' expression to silence this warning
1827 | kidx, dpk->is_dpk_enable & off_reverse ? "enable" : "disable");
| ^
| ( )
drivers/net/wireless/realtek/rtw89/rtw8852bt_rfk.c:1827:46: note: place parentheses around the '?:' expression to evaluate it first
1827 | kidx, dpk->is_dpk_enable & off_reverse ? "enable" : "disable");
| ^
| ( )
1 warning generated.
vim +1827 drivers/net/wireless/realtek/rtw89/rtw8852bt_rfk.c
f77c5179bc9f6f Ping-Ke Shih 2024-06-27 1807
5b8c61b82eec9e Ping-Ke Shih 2024-06-21 1808 static void _dpk_onoff(struct rtw89_dev *rtwdev, enum rtw89_rf_path path, bool off)
5b8c61b82eec9e Ping-Ke Shih 2024-06-21 1809 {
5b8c61b82eec9e Ping-Ke Shih 2024-06-21 1810 struct rtw89_dpk_info *dpk = &rtwdev->dpk;
5b8c61b82eec9e Ping-Ke Shih 2024-06-21 1811 u8 val, kidx = dpk->cur_idx[path];
5b8c61b82eec9e Ping-Ke Shih 2024-06-21 1812 bool off_reverse;
5b8c61b82eec9e Ping-Ke Shih 2024-06-21 1813
5b8c61b82eec9e Ping-Ke Shih 2024-06-21 1814 val = dpk->is_dpk_enable && !off && dpk->bp[path][kidx].path_ok;
5b8c61b82eec9e Ping-Ke Shih 2024-06-21 1815
5b8c61b82eec9e Ping-Ke Shih 2024-06-21 1816 if (off)
5b8c61b82eec9e Ping-Ke Shih 2024-06-21 1817 off_reverse = false;
5b8c61b82eec9e Ping-Ke Shih 2024-06-21 1818 else
5b8c61b82eec9e Ping-Ke Shih 2024-06-21 1819 off_reverse = true;
5b8c61b82eec9e Ping-Ke Shih 2024-06-21 1820
5b8c61b82eec9e Ping-Ke Shih 2024-06-21 1821 val = dpk->is_dpk_enable & off_reverse & dpk->bp[path][kidx].path_ok;
5b8c61b82eec9e Ping-Ke Shih 2024-06-21 1822
5b8c61b82eec9e Ping-Ke Shih 2024-06-21 1823 rtw89_phy_write32_mask(rtwdev, R_DPD_CH0A + (path << 8) + (kidx << 2),
5b8c61b82eec9e Ping-Ke Shih 2024-06-21 1824 BIT(24), val);
5b8c61b82eec9e Ping-Ke Shih 2024-06-21 1825
5b8c61b82eec9e Ping-Ke Shih 2024-06-21 1826 rtw89_debug(rtwdev, RTW89_DBG_RFK, "[DPK] S%d[%d] DPK %s !!!\n", path,
5b8c61b82eec9e Ping-Ke Shih 2024-06-21 @1827 kidx, dpk->is_dpk_enable & off_reverse ? "enable" : "disable");
5b8c61b82eec9e Ping-Ke Shih 2024-06-21 1828 }
5b8c61b82eec9e Ping-Ke Shih 2024-06-21 1829
On Sat, 2024-07-20 at 08:09 +0800, kernel test robot wrote: > > > > drivers/net/wireless/realtek/rtw89/rtw8852bt_rfk.c:1827:46: warning: operator '?:' has lower > > > precedence than '&'; '&' will be evaluated first [-Wbitwise-conditional-parentheses] > 1827 | kidx, dpk->is_dpk_enable & off_reverse ? "enable" : "disable"); > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ > drivers/net/wireless/realtek/rtw89/rtw8852bt_rfk.c:1827:46: note: place parentheses around the > '&' expression to silence this warning > 1827 | kidx, dpk->is_dpk_enable & off_reverse ? "enable" : "disable"); > | ^ > | ( ) > drivers/net/wireless/realtek/rtw89/rtw8852bt_rfk.c:1827:46: note: place parentheses around the > '?:' expression to evaluate it first > 1827 | kidx, dpk->is_dpk_enable & off_reverse ? "enable" : "disable"); > | ^ > | ( ) > 1 warning generated. In v3, I will correct this by 'str_enable_disable(dpk->is_dpk_enable & off_reverse)' with a new patch.
diff --git a/drivers/net/wireless/realtek/rtw89/Kconfig b/drivers/net/wireless/realtek/rtw89/Kconfig index 3c9f864805b1..17965487992e 100644 --- a/drivers/net/wireless/realtek/rtw89/Kconfig +++ b/drivers/net/wireless/realtek/rtw89/Kconfig @@ -28,6 +28,9 @@ config RTW89_8852B_COMMON config RTW89_8852B tristate +config RTW89_8852BT + tristate + config RTW89_8852C tristate @@ -68,6 +71,18 @@ config RTW89_8852BE 802.11ax PCIe wireless network (Wi-Fi 6) adapter +config RTW89_8852BTE + tristate "Realtek 8852BE-VT PCI wireless network (Wi-Fi 6) adapter" + depends on PCI + select RTW89_CORE + select RTW89_PCI + select RTW89_8852BT + select RTW89_8852B_COMMON + help + Select this option will enable support for 8852BE-VT chipset + + 802.11ax PCIe wireless network (Wi-Fi 6) adapter + config RTW89_8852CE tristate "Realtek 8852CE PCI wireless network (Wi-Fi 6E) adapter" depends on PCI diff --git a/drivers/net/wireless/realtek/rtw89/Makefile b/drivers/net/wireless/realtek/rtw89/Makefile index 1f1050a7a89d..c751013e811e 100644 --- a/drivers/net/wireless/realtek/rtw89/Makefile +++ b/drivers/net/wireless/realtek/rtw89/Makefile @@ -52,6 +52,14 @@ rtw89_8852b-objs := rtw8852b.o \ obj-$(CONFIG_RTW89_8852BE) += rtw89_8852be.o rtw89_8852be-objs := rtw8852be.o +obj-$(CONFIG_RTW89_8852BT) += rtw89_8852bt.o +rtw89_8852bt-objs := rtw8852bt.o \ + rtw8852bt_rfk.o \ + rtw8852bt_rfk_table.o + +obj-$(CONFIG_RTW89_8852BTE) += rtw89_8852bte.o +rtw89_8852bte-objs := rtw8852bte.o + obj-$(CONFIG_RTW89_8852C) += rtw89_8852c.o rtw89_8852c-objs := rtw8852c.o \ rtw8852c_table.o \
RTL8852BE-VT is a WiFi 6 2x2 chip, which can operate on 2/5 GHz channels and 80MHz bandwidth. Signed-off-by: Ping-Ke Shih <pkshih@realtek.com> --- v2: add missing RTW89_8852BT --- drivers/net/wireless/realtek/rtw89/Kconfig | 15 +++++++++++++++ drivers/net/wireless/realtek/rtw89/Makefile | 8 ++++++++ 2 files changed, 23 insertions(+)