| Message ID | 20240722194146.1736608-1-quic_vjakkam@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Johannes Berg |
| Headers | show |
| Series | wifi: cfg80211: fix reporting failed MLO links status with cfg80211_connect_done | expand |
On Tue, Jul 23, 2024 at 01:11:46AM +0530, Veerendranath Jakkam wrote: > Individual MLO links connection status not copied to > EVENT_CONNECT_RESULT data while processing the connect response > information in cfg80211_connect_done(). Due to this failed links also > indicated with success status in EVENT_CONNECT_RESULT. > > To fix this, copy the individual MLO links status to > EVENT_CONNECT_RESULT data. Does this need a Fixes: tag then? > > Signed-off-by: Veerendranath Jakkam <quic_vjakkam@quicinc.com> > --- > net/wireless/sme.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/wireless/sme.c b/net/wireless/sme.c > index e419aa8c4a5a..d9d7bf8bb5c1 100644 > --- a/net/wireless/sme.c > +++ b/net/wireless/sme.c > @@ -1045,6 +1045,7 @@ void cfg80211_connect_done(struct net_device *dev, > cfg80211_hold_bss( > bss_from_pub(params->links[link].bss)); > ev->cr.links[link].bss = params->links[link].bss; > + ev->cr.links[link].status = params->links[link].status; > > if (params->links[link].addr) { > ev->cr.links[link].addr = next; > -- > 2.34.1 >
On 7/23/2024 9:28 PM, Carlos Llamas wrote: > On Tue, Jul 23, 2024 at 01:11:46AM +0530, Veerendranath Jakkam wrote: >> Individual MLO links connection status not copied to >> EVENT_CONNECT_RESULT data while processing the connect response >> information in cfg80211_connect_done(). Due to this failed links also >> indicated with success status in EVENT_CONNECT_RESULT. >> >> To fix this, copy the individual MLO links status to >> EVENT_CONNECT_RESULT data. > Does this need a Fixes: tag then? Sent v2 patch with "Fixes:" tag. Thanks, Veeru
diff --git a/net/wireless/sme.c b/net/wireless/sme.c index e419aa8c4a5a..d9d7bf8bb5c1 100644 --- a/net/wireless/sme.c +++ b/net/wireless/sme.c @@ -1045,6 +1045,7 @@ void cfg80211_connect_done(struct net_device *dev, cfg80211_hold_bss( bss_from_pub(params->links[link].bss)); ev->cr.links[link].bss = params->links[link].bss; + ev->cr.links[link].status = params->links[link].status; if (params->links[link].addr) { ev->cr.links[link].addr = next;
Individual MLO links connection status not copied to EVENT_CONNECT_RESULT data while processing the connect response information in cfg80211_connect_done(). Due to this failed links also indicated with success status in EVENT_CONNECT_RESULT. To fix this, copy the individual MLO links status to EVENT_CONNECT_RESULT data. Signed-off-by: Veerendranath Jakkam <quic_vjakkam@quicinc.com> --- net/wireless/sme.c | 1 + 1 file changed, 1 insertion(+)