| Message ID | 20240828-wireless-mainline-v13-3-9998b19cfe7e@wesion.com (mailing list archive) |
|---|---|
| State | Deferred |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | Add AP6276P wireless support | expand |
On 28/08/2024 10:49, Jacobe Zang wrote: > Add "brcm,bcm4329-fmac" as fallback compatible for wireless devices that > used PCI ID based compatible. So that can pass the compatible check in > driver. Driver? Why this has to pass compatible check? I think I asked to provide proper rationale based on hardware... if not, then let me ask here: Please provide proper rationale explaining how this hardware is compatible, especially considering these are entirely different buses (SDIO and PCI!). It feels you patch up bindings and DTS, because of buggy driver. Sorry no, fix the driver. Best regards, Krzysztof
On 2024/8/28 21:04, Krzysztof Kozlowski wrote: > On 28/08/2024 10:49, Jacobe Zang wrote: >> Add "brcm,bcm4329-fmac" as fallback compatible for wireless devices that >> used PCI ID based compatible. So that can pass the compatible check in >> driver. > > Driver? Why this has to pass compatible check? > > I think I asked to provide proper rationale based on hardware... if not, > then let me ask here: Please provide proper rationale explaining how > this hardware is compatible, especially considering these are entirely > different buses (SDIO and PCI!). > > It feels you patch up bindings and DTS, because of buggy driver. Sorry > no, fix the driver. > All right. Anyway after discussion in the other series, this patch should be dropped, and driver also need to fix.
diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml index a3607d55ef367..4870caed5f75e 100644 --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml @@ -27,7 +27,6 @@ properties: - brcm,bcm4341b0-fmac - brcm,bcm4341b4-fmac - brcm,bcm4341b5-fmac - - brcm,bcm4329-fmac - brcm,bcm4330-fmac - brcm,bcm4334-fmac - brcm,bcm43340-fmac @@ -46,14 +45,17 @@ properties: - cypress,cyw43012-fmac - infineon,cyw43439-fmac - const: brcm,bcm4329-fmac - - enum: - - brcm,bcm4329-fmac - - pci14e4,43dc # BCM4355 - - pci14e4,4464 # BCM4364 - - pci14e4,4488 # BCM4377 - - pci14e4,4425 # BCM4378 - - pci14e4,4433 # BCM4387 - - pci14e4,449d # BCM43752 + - items: + - enum: + - brcm,bcm4329-fmac + - pci14e4,43dc # BCM4355 + - pci14e4,4464 # BCM4364 + - pci14e4,4488 # BCM4377 + - pci14e4,4425 # BCM4378 + - pci14e4,4433 # BCM4387 + - pci14e4,449d # BCM43752 + - const: brcm,bcm4329-fmac + - const: brcm,bcm4329-fmac reg: description: SDIO function number for the device (for most cases
Add "brcm,bcm4329-fmac" as fallback compatible for wireless devices that used PCI ID based compatible. So that can pass the compatible check in driver. Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com> --- .../bindings/net/wireless/brcm,bcm4329-fmac.yaml | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-)