| Message ID | 20240927084317.96687-1-dmantipov@yandex.ru (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d0847e16ca2a98ef53b631e78d83d5a7f7e27295 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [1/2] wifi: mwifiex: cleanup struct mwifiex_auto_tdls_peer | expand |
Hello Dmitry, thanks for your patch. On Fri, Sep 27, 2024 at 11:43:16AM +0300, Dmitry Antipov wrote: > Remove set but otherwise unused 'do_setup' member of > 'struct mwifiex_auto_tdls_peer'. Compile tested only. > > Fixes: 9927baa3c724 ("mwifiex: add auto TDLS support") > Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru> It looks like you are not having in Cc: the right people, please verify your workflow. In addition I do not think that such kind of patches should have a Fixes tag. As you correctly wrote in the subject this is a clean-up, not a fix. I personally prefer to have a cover letter anytime you have more than 1 patch. These applies to both the patches in this series. Francesco
Dmitry Antipov <dmantipov@yandex.ru> wrote: > Remove set but otherwise unused 'do_setup' member of > 'struct mwifiex_auto_tdls_peer'. Compile tested only. > > Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru> 2 patches applied to wireless-next.git, thanks. d0847e16ca2a wifi: mwifiex: cleanup struct mwifiex_auto_tdls_peer 6dc944577254 wifi: mwifiex: cleanup struct mwifiex_private
diff --git a/drivers/net/wireless/marvell/mwifiex/main.h b/drivers/net/wireless/marvell/mwifiex/main.h index 566adce3413c..92a1cab6e750 100644 --- a/drivers/net/wireless/marvell/mwifiex/main.h +++ b/drivers/net/wireless/marvell/mwifiex/main.h @@ -802,7 +802,6 @@ struct mwifiex_auto_tdls_peer { unsigned long rssi_jiffies; u8 failure_count; u8 do_discover; - u8 do_setup; }; #define MWIFIEX_TYPE_AGGR_DATA_V2 11 diff --git a/drivers/net/wireless/marvell/mwifiex/tdls.c b/drivers/net/wireless/marvell/mwifiex/tdls.c index 7823e67694e8..0a5f340876c3 100644 --- a/drivers/net/wireless/marvell/mwifiex/tdls.c +++ b/drivers/net/wireless/marvell/mwifiex/tdls.c @@ -1306,7 +1306,6 @@ int mwifiex_tdls_check_tx(struct mwifiex_private *priv, struct sk_buff *skb) peer->mac_addr, NL80211_TDLS_SETUP, 0, GFP_ATOMIC); - peer->do_setup = false; priv->check_tdls_tx = false; } else if (peer->failure_count < MWIFIEX_TDLS_MAX_FAIL_COUNT && @@ -1465,7 +1464,6 @@ void mwifiex_check_auto_tdls(struct timer_list *t) tdls_peer->failure_count < MWIFIEX_TDLS_MAX_FAIL_COUNT) { priv->check_tdls_tx = true; - tdls_peer->do_setup = true; mwifiex_dbg(priv->adapter, INFO, "check TDLS with peer=%pM\t" "rssi=%d\n", tdls_peer->mac_addr,
Remove set but otherwise unused 'do_setup' member of 'struct mwifiex_auto_tdls_peer'. Compile tested only. Fixes: 9927baa3c724 ("mwifiex: add auto TDLS support") Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru> --- drivers/net/wireless/marvell/mwifiex/main.h | 1 - drivers/net/wireless/marvell/mwifiex/tdls.c | 2 -- 2 files changed, 3 deletions(-)