| Message ID | 20241115-converge-secs-to-jiffies-v2-2-911fb7595e79@linux.microsoft.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Johannes Berg |
| Headers | show |
| Series | Converge on using secs_to_jiffies() | expand |
Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : > Suggested-by: Anna-Maria Behnsen <anna-maria@linutronix.de> > Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com> > --- > scripts/coccinelle/misc/secs_to_jiffies.cocci | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/scripts/coccinelle/misc/secs_to_jiffies.cocci b/scripts/coccinelle/misc/secs_to_jiffies.cocci > new file mode 100644 > index 0000000000000000000000000000000000000000..af762b1c0aac8f044f21150bfaafd9efc834ee87 > --- /dev/null > +++ b/scripts/coccinelle/misc/secs_to_jiffies.cocci > @@ -0,0 +1,21 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/// > +/// Find usages of: > +/// - msecs_to_jiffies(value*1000) > +/// - msecs_to_jiffies(value*MSEC_PER_SEC) > +/// > +// Confidence: High > +// Copyright: (C) 2024 Easwar Hariharan Microsoft > +// > +// Keywords: secs, seconds, jiffies > +// > + > +@@ constant C; @@ > + > +- msecs_to_jiffies(C * 1000) > ++ secs_to_jiffies(C) > + > +@@ constant C; @@ > + > +- msecs_to_jiffies(C * MSEC_PER_SEC) > ++ secs_to_jiffies(C) > Hi, @@ constant C =~ "000"; @@ * msecs_to_jiffies(C) also spots things like msecs_to_jiffies(1000) I'm not sure that coccinelle is enable to capture part of the regex to automate the removal of the 000 when converting from ms to s. Just my 2c, CJ
Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : > [Vous ne recevez pas souvent de courriers de eahariha@linux.microsoft.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] > There should be some explaination in the commit message, what the script does for instance. > Suggested-by: Anna-Maria Behnsen <anna-maria@linutronix.de> > Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com> > --- > scripts/coccinelle/misc/secs_to_jiffies.cocci | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/scripts/coccinelle/misc/secs_to_jiffies.cocci b/scripts/coccinelle/misc/secs_to_jiffies.cocci > new file mode 100644 > index 0000000000000000000000000000000000000000..af762b1c0aac8f044f21150bfaafd9efc834ee87 > --- /dev/null > +++ b/scripts/coccinelle/misc/secs_to_jiffies.cocci > @@ -0,0 +1,21 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/// > +/// Find usages of: > +/// - msecs_to_jiffies(value*1000) > +/// - msecs_to_jiffies(value*MSEC_PER_SEC) > +/// > +// Confidence: High > +// Copyright: (C) 2024 Easwar Hariharan Microsoft > +// > +// Keywords: secs, seconds, jiffies > +// > + > +@@ constant C; @@ > + > +- msecs_to_jiffies(C * 1000) > ++ secs_to_jiffies(C) > + > +@@ constant C; @@ > + > +- msecs_to_jiffies(C * MSEC_PER_SEC) > ++ secs_to_jiffies(C) > > -- > 2.34.1 >
Why is a change description missing here? … > +++ b/scripts/coccinelle/misc/secs_to_jiffies.cocci > @@ -0,0 +1,21 @@ … > +/// Find usages of: > +/// - msecs_to_jiffies(value*1000) > +/// - msecs_to_jiffies(value*MSEC_PER_SEC) I suggest to take another look at corresponding development documentation. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/dev-tools/coccinelle.rst?h=v6.12-rc7#n71 Will the attention grow for the proper usage of operation modes according to the tool “coccicheck”? … > +// Copyright: (C) 2024 Easwar Hariharan Microsoft Should personal details and company names be better distinguished in such information? > +// > +// Keywords: secs, seconds, jiffies May a (blank) comment line be omitted here? > +@@ constant C; @@ > + > +- msecs_to_jiffies(C * 1000) > ++ secs_to_jiffies(C) > + > +@@ constant C; @@ > + > +- msecs_to_jiffies(C * MSEC_PER_SEC) > ++ secs_to_jiffies(C) I suggest to take a SmPL code variant (like the following) better into account. @depends on patch@ constant C; @@ -msecs_to_jiffies +secs_to_jiffies (C - * \( 1000 \| MSEC_PER_SEC \) ) Can any expressions become relevant besides “constants”? Regards, Markus
On 11/15/2024 10:05 PM, Christophe JAILLET wrote: > Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : >> Suggested-by: Anna-Maria Behnsen <anna-maria@linutronix.de> >> Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com> >> --- >> scripts/coccinelle/misc/secs_to_jiffies.cocci | 21 +++++++++++++++++++++ >> 1 file changed, 21 insertions(+) >> >> diff --git a/scripts/coccinelle/misc/secs_to_jiffies.cocci b/scripts/coccinelle/misc/secs_to_jiffies.cocci >> new file mode 100644 >> index 0000000000000000000000000000000000000000..af762b1c0aac8f044f21150bfaafd9efc834ee87 >> --- /dev/null >> +++ b/scripts/coccinelle/misc/secs_to_jiffies.cocci >> @@ -0,0 +1,21 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +/// >> +/// Find usages of: >> +/// - msecs_to_jiffies(value*1000) >> +/// - msecs_to_jiffies(value*MSEC_PER_SEC) >> +/// >> +// Confidence: High >> +// Copyright: (C) 2024 Easwar Hariharan Microsoft >> +// >> +// Keywords: secs, seconds, jiffies >> +// >> + >> +@@ constant C; @@ >> + >> +- msecs_to_jiffies(C * 1000) >> ++ secs_to_jiffies(C) >> + >> +@@ constant C; @@ >> + >> +- msecs_to_jiffies(C * MSEC_PER_SEC) >> ++ secs_to_jiffies(C) >> > Hi, > > @@ constant C =~ "000"; @@ > > * msecs_to_jiffies(C) > > also spots things like msecs_to_jiffies(1000) > > I'm not sure that coccinelle is enable to capture part of the regex to automate the removal of the 000 when converting from ms to s. > > Just my 2c, > > CJ Thank you, I'll try that rule for the later parts. Thank you all for helping with writing Coccinelle rules, I'm not familiar with metaprogramming in general and Coccinelle in particular, so these are super helpful. - Easwar
On 11/16/2024 1:52 AM, Christophe Leroy wrote: > > > Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : >> [Vous ne recevez pas souvent de courriers de >> eahariha@linux.microsoft.com. Découvrez pourquoi ceci est important à >> https://aka.ms/LearnAboutSenderIdentification ] >> > > There should be some explaination in the commit message, what the script > does for instance. > Thanks, will expand on this in v3. - Easwar
diff --git a/scripts/coccinelle/misc/secs_to_jiffies.cocci b/scripts/coccinelle/misc/secs_to_jiffies.cocci new file mode 100644 index 0000000000000000000000000000000000000000..af762b1c0aac8f044f21150bfaafd9efc834ee87 --- /dev/null +++ b/scripts/coccinelle/misc/secs_to_jiffies.cocci @@ -0,0 +1,21 @@ +// SPDX-License-Identifier: GPL-2.0-only +/// +/// Find usages of: +/// - msecs_to_jiffies(value*1000) +/// - msecs_to_jiffies(value*MSEC_PER_SEC) +/// +// Confidence: High +// Copyright: (C) 2024 Easwar Hariharan Microsoft +// +// Keywords: secs, seconds, jiffies +// + +@@ constant C; @@ + +- msecs_to_jiffies(C * 1000) ++ secs_to_jiffies(C) + +@@ constant C; @@ + +- msecs_to_jiffies(C * MSEC_PER_SEC) ++ secs_to_jiffies(C)
Suggested-by: Anna-Maria Behnsen <anna-maria@linutronix.de> Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com> --- scripts/coccinelle/misc/secs_to_jiffies.cocci | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)