| Message ID | 20250225-b-wifi-qcom-calibration-variant-v1-1-3b2aa3f89c53@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Jeff Johnson |
| Headers | show |
| Series | wifi: ath10k/ath11k/ath12k: Strip device prefix from calibration properties | expand |
On Tue, 25 Feb 2025 10:05:32 +0100, Krzysztof Kozlowski wrote: > Devicetree properties describing exactly the same thing should be > reusable between device bindings. All Qualcomm Atheros WiFi chips needs > certain calibration data, so properties should not be prefixed with > device family (ath10k). > > Deprecate qcom,ath10k-calibration-variant and alike, so we gradually > switch to a common property. This will also allow moving these > properties to common schema, if desired. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Why? Because people add qcom,ath12k-calibration-data and probably they > will add qcom,ath13k-calibration-data, qcom,ath14k-calibration-data and > so on. > --- > .../bindings/net/wireless/qcom,ath10k.yaml | 25 ++++++++++++++++++++-- > 1 file changed, 23 insertions(+), 2 deletions(-) > Acked-by: Rob Herring (Arm) <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml index aace072e2d52a6830b98dd3f52d61380105c8aa1..f2440d39b7ebcda77db592de85573bec902fb334 100644 --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml @@ -92,20 +92,41 @@ properties: ieee80211-freq-limit: true - qcom,ath10k-calibration-data: + qcom,calibration-data: $ref: /schemas/types.yaml#/definitions/uint8-array description: Calibration data + board-specific data as a byte array. The length can vary between hardware versions. - qcom,ath10k-calibration-variant: + qcom,ath10k-calibration-data: + $ref: /schemas/types.yaml#/definitions/uint8-array + deprecated: true + description: + Calibration data + board-specific data as a byte array. The length + can vary between hardware versions. + + qcom,calibration-variant: $ref: /schemas/types.yaml#/definitions/string description: Unique variant identifier of the calibration data in board-2.bin for designs with colliding bus and device specific ids + qcom,ath10k-calibration-variant: + $ref: /schemas/types.yaml#/definitions/string + deprecated: true + description: + Unique variant identifier of the calibration data in board-2.bin + for designs with colliding bus and device specific ids + + qcom,pre-calibration-data: + $ref: /schemas/types.yaml#/definitions/uint8-array + description: + Pre-calibration data as a byte array. The length can vary between + hardware versions. + qcom,ath10k-pre-calibration-data: $ref: /schemas/types.yaml#/definitions/uint8-array + deprecated: true description: Pre-calibration data as a byte array. The length can vary between hardware versions.
Devicetree properties describing exactly the same thing should be reusable between device bindings. All Qualcomm Atheros WiFi chips needs certain calibration data, so properties should not be prefixed with device family (ath10k). Deprecate qcom,ath10k-calibration-variant and alike, so we gradually switch to a common property. This will also allow moving these properties to common schema, if desired. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Why? Because people add qcom,ath12k-calibration-data and probably they will add qcom,ath13k-calibration-data, qcom,ath14k-calibration-data and so on. --- .../bindings/net/wireless/qcom,ath10k.yaml | 25 ++++++++++++++++++++-- 1 file changed, 23 insertions(+), 2 deletions(-)