| Message ID | 288fc9a0db6c292bc132e828611c41785b075078.1686486461.git.chunkeey@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [v1] dt-bindings: net: wireless: bcm4329-fmac: add ieee80211-freq-limit property | expand |
On 11/06/2023 14:37, Christian Lamparter wrote: > This is an existing optional property that ieee80211.yaml/cfg80211 > provides. It's useful to further restrict supported frequencies > for a specified device through device-tree. > > The driver supported this since ~2017 by > commit 0f83ff697356 ("brcmfmac: use wiphy_read_of_freq_limits to respect limits from DT") > > This property is already being used by: > arch/arm/dts/bcm4709-netgear-r8000.dts > > Signed-off-by: Christian Lamparter <chunkeey@gmail.com> > --- So this is superseded? Best regards, Krzysztof
On 2023-06-11 14:37, Christian Lamparter wrote: > This is an existing optional property that ieee80211.yaml/cfg80211 > provides. It's useful to further restrict supported frequencies > for a specified device through device-tree. > > The driver supported this since ~2017 by > commit 0f83ff697356 ("brcmfmac: use wiphy_read_of_freq_limits to > respect limits from DT") > > This property is already being used by: > arch/arm/dts/bcm4709-netgear-r8000.dts > > Signed-off-by: Christian Lamparter <chunkeey@gmail.com> I've already submitted patch for that: https://patchwork.kernel.org/project/linux-wireless/patch/20230602135925.14143-2-zajec5@gmail.com/ This patch isn't needed anymore. > --- > .../devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git > a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml > b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml > index fec1cc9b9a08..44e5f6677289 100644 > --- > a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml > +++ > b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml > @@ -15,6 +15,9 @@ description: > These chips also have a Bluetooth portion described in a separate > binding. > > +allOf: > + - $ref: ieee80211.yaml# FWIW: This isn't enough without changing additionalProperties to unevaluatedProperties. > properties: > compatible: > oneOf: > @@ -63,6 +66,8 @@ properties: > description: Name for the OOB IRQ, this must be set to > "host-wake". > const: host-wake > > + ieee80211-freq-limit: true FWIW: You don't need it here with allOf. > brcm,drive-strength: > $ref: /schemas/types.yaml#/definitions/uint32 > description: Drive strength used for the SDIO pins on the device > in mA.
diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml index fec1cc9b9a08..44e5f6677289 100644 --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml @@ -15,6 +15,9 @@ description: These chips also have a Bluetooth portion described in a separate binding. +allOf: + - $ref: ieee80211.yaml# + properties: compatible: oneOf: @@ -63,6 +66,8 @@ properties: description: Name for the OOB IRQ, this must be set to "host-wake". const: host-wake + ieee80211-freq-limit: true + brcm,drive-strength: $ref: /schemas/types.yaml#/definitions/uint32 description: Drive strength used for the SDIO pins on the device in mA.
This is an existing optional property that ieee80211.yaml/cfg80211 provides. It's useful to further restrict supported frequencies for a specified device through device-tree. The driver supported this since ~2017 by commit 0f83ff697356 ("brcmfmac: use wiphy_read_of_freq_limits to respect limits from DT") This property is already being used by: arch/arm/dts/bcm4709-netgear-r8000.dts Signed-off-by: Christian Lamparter <chunkeey@gmail.com> --- .../devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml | 5 +++++ 1 file changed, 5 insertions(+)