diff mbox series

[v3] wifi: rtl8xxxu: Add LED control code for RTL8723BU

Message ID 2e3b0b74-8bfc-4ff3-8a0c-ba1bbfa4d535@gmail.com (mailing list archive)
State Changes Requested
Delegated to: Ping-Ke Shih
Headers show
Series [v3] wifi: rtl8xxxu: Add LED control code for RTL8723BU | expand

Commit Message

Bitterblue Smith April 19, 2024, 12:02 p.m. UTC 
Software control (on/off) and hardware control (automatic blinking)
tested with EDUP EP-N8568.

Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
---
v3:
 - Remove unnecessary braces to silence checkpatch

v2:
 - More information in the commit message.
---
 .../realtek/rtl8xxxu/rtl8xxxu_8723b.c         | 22 +++++++++++++++++++
 1 file changed, 22 insertions(+)

Comments

Ping-Ke Shih April 22, 2024, 1:26 a.m. UTC | #1 
Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:

> Software control (on/off) and hardware control (automatic blinking)
> tested with EDUP EP-N8568.
> 
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>

Still warns:

  WARNING: Missing a blank line after declarations
  #28: FILE: drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c:1711:
  +	u8 ledcfg = rtl8xxxu_read8(priv, REG_LEDCFG2);
  +	ledcfg &= LEDCFG2_DPDT_SELECT;

Set patchset state to Changes Requested

[v3] wifi: rtl8xxxu: Add LED control code for RTL8723BU

---
https://github.com/pkshih/rtw.git
diff mbox series

Patch

diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c
index 9640c841d20a..de01e21589c5 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c
@@ -1701,6 +1701,27 @@  static s8 rtl8723b_cck_rssi(struct rtl8xxxu_priv *priv, struct rtl8723au_phy_sta
 	return rx_pwr_all;
 }
 
+static int rtl8723bu_led_brightness_set(struct led_classdev *led_cdev,
+					enum led_brightness brightness)
+{
+	struct rtl8xxxu_priv *priv = container_of(led_cdev,
+						  struct rtl8xxxu_priv,
+						  led_cdev);
+	u8 ledcfg = rtl8xxxu_read8(priv, REG_LEDCFG2);
+	ledcfg &= LEDCFG2_DPDT_SELECT;
+
+	if (brightness == LED_OFF)
+		ledcfg |= LEDCFG2_SW_LED_CONTROL | LEDCFG2_SW_LED_DISABLE;
+	else if (brightness == LED_ON)
+		ledcfg |= LEDCFG2_SW_LED_CONTROL;
+	else if (brightness == RTL8XXXU_HW_LED_CONTROL)
+		ledcfg |= LEDCFG2_HW_LED_CONTROL | LEDCFG2_HW_LED_ENABLE;
+
+	rtl8xxxu_write8(priv, REG_LEDCFG2, ledcfg);
+
+	return 0;
+}
+
 struct rtl8xxxu_fileops rtl8723bu_fops = {
 	.identify_chip = rtl8723bu_identify_chip,
 	.parse_efuse = rtl8723bu_parse_efuse,
@@ -1731,6 +1752,7 @@  struct rtl8xxxu_fileops rtl8723bu_fops = {
 	.fill_txdesc = rtl8xxxu_fill_txdesc_v2,
 	.set_crystal_cap = rtl8723a_set_crystal_cap,
 	.cck_rssi = rtl8723b_cck_rssi,
+	.led_classdev_brightness_set = rtl8723bu_led_brightness_set,
 	.writeN_block_size = 1024,
 	.tx_desc_size = sizeof(struct rtl8xxxu_txdesc40),
 	.rx_desc_size = sizeof(struct rtl8xxxu_rxdesc24),