diff mbox

mt76x2: remove warnings in mt76x2_mac_write_txwi()

Message ID 39ba1292cb67ee2d4bf0f2813af63786f4241df1.1517443974.git.lorenzo.bianconi@redhat.com (mailing list archive)
State Accepted
Commit 09e93f28aa8d37a07d0c2ad742d085a21d845cda
Delegated to: Kalle Valo
Headers show

Commit Message

Lorenzo Bianconi Feb. 1, 2018, 12:27 a.m. UTC
Fix following sparse warnings in mt76x2_mac_write_txwi:
- drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:201:26: warning:
  incorrect type in assignment (different base types)
- drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:201:26: expected
  restricted __le32 [usertype] iv
- drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:201:26: got unsigned
  int [unsigned] [usertype] <noident>
- drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:202:27: warning:
  incorrect type in assignment (different base types)
- drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:202:27: expected
  restricted __le32 [usertype] eiv
- drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:202:27: got unsigned
  int [unsigned] [usertype] <noident>

Fixes: 23405236460b ("mt76: fix transmission of encrypted management
frames")
Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
---
 drivers/net/wireless/mediatek/mt76/mt76x2_mac.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Kalle Valo Feb. 28, 2018, 2:54 p.m. UTC | #1
Lorenzo Bianconi <lorenzo.bianconi@redhat.com> wrote:

> Fix following sparse warnings in mt76x2_mac_write_txwi:
> - drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:201:26: warning:
>   incorrect type in assignment (different base types)
> - drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:201:26: expected
>   restricted __le32 [usertype] iv
> - drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:201:26: got unsigned
>   int [unsigned] [usertype] <noident>
> - drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:202:27: warning:
>   incorrect type in assignment (different base types)
> - drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:202:27: expected
>   restricted __le32 [usertype] eiv
> - drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:202:27: got unsigned
>   int [unsigned] [usertype] <noident>
> 
> Fixes: 23405236460b ("mt76: fix transmission of encrypted management frames")
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>

Patch applied to wireless-drivers-next.git, thanks.

09e93f28aa8d mt76x2: remove warnings in mt76x2_mac_write_txwi()
diff mbox

Patch

diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2_mac.c b/drivers/net/wireless/mediatek/mt76/mt76x2_mac.c
index 6c30b5eaa9ca..279cd8717806 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76x2_mac.c
+++ b/drivers/net/wireless/mediatek/mt76/mt76x2_mac.c
@@ -198,8 +198,8 @@  void mt76x2_mac_write_txwi(struct mt76x2_dev *dev, struct mt76x2_txwi *txwi,
 		ccmp_pn[5] = pn >> 24;
 		ccmp_pn[6] = pn >> 32;
 		ccmp_pn[7] = pn >> 40;
-		txwi->iv = *((u32 *) &ccmp_pn[0]);
-		txwi->eiv = *((u32 *) &ccmp_pn[1]);
+		txwi->iv = *((__le32 *)&ccmp_pn[0]);
+		txwi->eiv = *((__le32 *)&ccmp_pn[1]);
 	}
 
 	spin_lock_bh(&dev->mt76.lock);