From patchwork Fri Mar 18 02:25:13 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julian Calaby X-Patchwork-Id: 8615841 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 17AC49F3D1 for ; Fri, 18 Mar 2016 02:25:25 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 36E8020306 for ; Fri, 18 Mar 2016 02:25:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 51A83202FE for ; Fri, 18 Mar 2016 02:25:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752643AbcCRCZV (ORCPT ); Thu, 17 Mar 2016 22:25:21 -0400 Received: from mail-pf0-f170.google.com ([209.85.192.170]:34524 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751361AbcCRCZT (ORCPT ); Thu, 17 Mar 2016 22:25:19 -0400 Received: by mail-pf0-f170.google.com with SMTP id x3so145890620pfb.1 for ; Thu, 17 Mar 2016 19:25:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5Udq2Mew5IGdABOghSWGbJ3gvsAVUB8y+qxNLpmJT7w=; b=UrvnZewwZCPnwmTM1uZASQm64mviRPQqEYG0SQTHG60K+rqUIhmMafoOxG88LuQlli ECrCyUMfkLmQFz4txnThKi7f2EnFl+ysa7l7dv6sB2vL6AMv18t+OTYp1b3AkSLmcdd8 mRMbwXF8WPKoq3Wz+sMDCQGOO/aalu5fyIxANqCSbwn9vtwGscfw2v28SZPsr6pGTnBN 7uhgXdTaOrG9HyIwJUGF8wmSWE9JfqEpYTUGG/GGacKrzHPRjohu3UKs/TvrdI9DOHr+ izW8yPnA/B4TigvRHK214XRWb0nndHNblmbLPOwStnW6Ui0bIpL1MOOrUMMKM2CqxLtZ kH0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=5Udq2Mew5IGdABOghSWGbJ3gvsAVUB8y+qxNLpmJT7w=; b=U5WSH1u+fqOuNmj/gYBTPDbTxv7YYnhypMyLVwfirC5Tq095DJBfWvkoPDEvKkuM+D Vuw15BaLDv1AOCz0aHSE63BaLGGvj2P92N0ugphhgoA65pUF1BOIiyAtmglDZwMNOU4j hkTpXAZa4odfy5PXLygT8fZpoo2PzpbZT3NSvHhzL/PwhoC+ZI70ZPq3M+Gyy7MpC6cR T9FSSRzv9wAN9VG2+s3UsunhvdegTDpQDJLGbSx7dmdunGNMUwjF2gAVZUJhrO4oEGAK BehNPTtWjnLTcnYpYRWIvtm861ZYJlCUF9CMXHlaNvpo7FN+LeSGjxr1H0oJWdKKxltr 6X3g== X-Gm-Message-State: AD7BkJIPotw8g+3dQv2kuM1l7ZZ2RUXAUd1tbT48a1bB2Mp98PaoyacwWjXC4DUFCBzXuQ== X-Received: by 10.98.89.22 with SMTP id n22mr19974153pfb.55.1458267919191; Thu, 17 Mar 2016 19:25:19 -0700 (PDT) Received: from multimedia.lan (C-59-101-14-180.hay.connect.net.au. [59.101.14.180]) by smtp.gmail.com with ESMTPSA id q2sm16360876pfq.88.2016.03.17.19.25.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 17 Mar 2016 19:25:18 -0700 (PDT) From: Julian Calaby To: Kalle Valo Cc: Markus Elfring , linux-wireless@vger.kernel.org Subject: [PATCH DETAIL 12/19] rsi: Delete unnecessary variable initialisation Date: Fri, 18 Mar 2016 13:25:13 +1100 Message-Id: <3df80efb8bddfafb9222b6b03b088c0d85693da8.1458262312.git.julian.calaby@gmail.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: References: Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring In rsi_send_mgmt_pkt(), the following variables are assigned to before they're used: * wh - Assigned on line 161, first used on line 180 * bss - Assigned on line 160, first used on line 196 * msg - Assigned on line 168, first used on line 175 * extnd_size - Assigned on line 139, first used on line 142 Signed-off-by: Markus Elfring [Rewrote commit message] Signed-off-by: Julian Calaby --- drivers/net/wireless/rsi/rsi_91x_pkt.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/rsi/rsi_91x_pkt.c b/drivers/net/wireless/rsi/rsi_91x_pkt.c index 702593f..571eaba 100644 --- a/drivers/net/wireless/rsi/rsi_91x_pkt.c +++ b/drivers/net/wireless/rsi/rsi_91x_pkt.c @@ -123,15 +123,15 @@ int rsi_send_mgmt_pkt(struct rsi_common *common, struct sk_buff *skb) { struct rsi_hw *adapter = common->priv; - struct ieee80211_hdr *wh = NULL; + struct ieee80211_hdr *wh; struct ieee80211_tx_info *info; - struct ieee80211_bss_conf *bss = NULL; + struct ieee80211_bss_conf *bss; struct ieee80211_hw *hw = adapter->hw; struct ieee80211_conf *conf = &hw->conf; struct skb_info *tx_params; int status = -E2BIG; - __le16 *msg = NULL; - u8 extnd_size = 0; + __le16 *msg; + u8 extnd_size; u8 vap_id = 0; info = IEEE80211_SKB_CB(skb);