From patchwork Mon Feb 16 18:26:44 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Larry Finger X-Patchwork-Id: 5834351 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 6CB6D9F380 for ; Mon, 16 Feb 2015 18:26:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D68DC201FA for ; Mon, 16 Feb 2015 18:26:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3F58A20115 for ; Mon, 16 Feb 2015 18:26:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755799AbbBPS0r (ORCPT ); Mon, 16 Feb 2015 13:26:47 -0500 Received: from mail-ob0-f172.google.com ([209.85.214.172]:62292 "EHLO mail-ob0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755606AbbBPS0r (ORCPT ); Mon, 16 Feb 2015 13:26:47 -0500 Received: by mail-ob0-f172.google.com with SMTP id nt9so44955747obb.3 for ; Mon, 16 Feb 2015 10:26:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type; bh=9nt/WyizSEH8ot6w90a8kjS2LeTmRvSqSsAp9zSyoq8=; b=1Efp9zLWU0ow/KVLtUaS0t/nnw1KmqsAuGc86r68DCiVCwQ2rvM1SLis2oWT1m9zEG u37OpHJFHw8eBEZkwS8zhjj2qOY52plZEcIUlKmoy0E2LlTj8MxY+o6k3SAvbPV1bJIH Co2SyOHTxwFxSbPnmUyyHqbSwj00jfPQD8Q2IWhbqR3kieR1xDM7TYVAXgxYIu65I1Sx 6xPVUgJjv4D/KBmcETix5bUZf1PvNEMoUhCwMn041sfzic7QRJbY9rKPUC/M3nRTRRLJ EBwfC9TCh3aUNeQoFsnt0Kf85PL08NzHe006IXMK7Vq5heYvvgzyOS54K2m5rakjkMIm Aqnw== X-Received: by 10.202.205.67 with SMTP id d64mr15210260oig.1.1424111206475; Mon, 16 Feb 2015 10:26:46 -0800 (PST) Received: from linux.site ([69.76.245.152]) by mx.google.com with ESMTPSA id z142sm9582614oig.22.2015.02.16.10.26.45 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Feb 2015 10:26:45 -0800 (PST) Message-ID: <54E23664.70509@lwfinger.net> Date: Mon, 16 Feb 2015 12:26:44 -0600 From: Larry Finger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Alan Fisher , linux-wireless@vger.kernel.org, linville@tuxdriver.com Subject: Re: PROBLEM: rtlwifi drops most IPv6 packets References: <54E19DD6.9050704@unixcube.org> In-Reply-To: <54E19DD6.9050704@unixcube.org> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,T_TVD_MIME_EPI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 02/16/2015 01:35 AM, Alan Fisher wrote: Alan, I looked at the routine, and it is returning true for all IPv6 packets. Does the attached patch for 3.18 or 3.19 help? Larry Index: wireless-drivers-next/drivers/net/wireless/rtlwifi/base.c =================================================================== --- wireless-drivers-next.orig/drivers/net/wireless/rtlwifi/base.c +++ wireless-drivers-next/drivers/net/wireless/rtlwifi/base.c @@ -1347,7 +1347,7 @@ u8 rtl_is_special_data(struct ieee80211_ offset = mac_hdr_len + SNAP_SIZE + encrypt_header_len; ether_type = be16_to_cpup((__be16 *)(skb->data + offset)); - if (ETH_P_IP == ether_type) { + if (ETH_P_IP == ether_type || ETH_P_IPV6 == ether_type) { ip = (struct iphdr *)((u8 *)skb->data + offset + PROTOC_TYPE_SIZE); if (IPPROTO_UDP == ip->protocol) { @@ -1386,8 +1386,6 @@ u8 rtl_is_special_data(struct ieee80211_ } return true; - } else if (0x86DD == ether_type) { - return true; } end: