From patchwork Sat Jan 2 14:43:15 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 7940701 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 0B4AABEEE5 for ; Sat, 2 Jan 2016 14:43:29 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 32C78203B7 for ; Sat, 2 Jan 2016 14:43:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 62CB720411 for ; Sat, 2 Jan 2016 14:43:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751908AbcABOnY (ORCPT ); Sat, 2 Jan 2016 09:43:24 -0500 Received: from mout.web.de ([212.227.15.3]:54929 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751205AbcABOnW (ORCPT ); Sat, 2 Jan 2016 09:43:22 -0500 Received: from [192.168.1.2] ([77.181.40.156]) by smtp.web.de (mrweb002) with ESMTPSA (Nemesis) id 0MVcrf-1akNMR0aC7-00Z3YK; Sat, 02 Jan 2016 15:43:16 +0100 Subject: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt() To: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Kalle Valo References: <566ABCD9.1060404@users.sourceforge.net> <5687E169.4070704@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <5687E203.1070404@users.sourceforge.net> Date: Sat, 2 Jan 2016 15:43:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <5687E169.4070704@users.sourceforge.net> X-Provags-ID: V03:K0:9sj9MVnBJjJLG4IWmlGsx2Zgn4mbqQs0CYQjCtVMjbI+agjAr/w m2XnMgMUPPDcKrimhnSzw8iqM5jMfd8Cj18ATvEd0MngJkCbVuFUcSISaZoBM0mzf13poiI pmxZhUTMHW9O3TK6ejF6ZwWW8FRuzHygpzq8Jgun2rXf1MHO/sM6UioDW2HJEd/CNGw/vjd 4dc9KRF8MFa/RiLfrcf7A== X-UI-Out-Filterresults: notjunk:1; V01:K0:xCL1d32ZqEY=:VjZYvaLInhAH8ydrys1x4G 802U0CpDE45b3evA7edcQn5Wf4/qg+AaCoCVyXOn4gQ9mYgXUxqvTBfQLv6Z9REa0vnxMryxJ hpoELXMXOBMI70hYOEpQf6QwEIP5XFwgCJejQnO42+ZQBQkr6ZxTzMu2I3tkuIK0p4F9Vf0Fi vZ7ewxMMi2703MpMzIqkincjRFzFNuYG4bQaSKeCVtDHKhh3UFOh6LE1pWp2rQrg0oE0rBHRk RarJKeTKQhTfBzLl70kQrTUx1DgXj9eSy73iccmoAsl8eH041LJIBaIxDdSgOcQeqm0XYC2rS mQcdVY419kRoXRqfc+vHiHep+3YzaCchNkCLmQUYjMgdKXKu47TZqFWPP1WZF98HBfGiPKusv g0pl+K5SpwqSa4eAbzmZag3W33JHR8qQl+5Q27ifhRFi5qYG/EZdTiZSILhKZ6U1nbegY70gQ Esuu/xBwnwB17cFnyCug+V5knQIcyVUaSvn9CckSyB5IARJTHmuXsXJ8RTxDQAeMwzltH1vJA a+sMyt7pMvm9NsQnCtvnv37s3K+sVKH8SleUBeHApW7R4yw6HRhfL3/ni0UbEAZVlPpYsJZYi +n8c4WHuBHgAaruLby95Ss+q+YoHkvwOwjtfA//MnvW3uB2mH05hoP9wMtEGoiaAgW1TccLpB zcYp8hfOdiGs4NjkWBwYo46HlenaUAtZCrhtby8JU3ppw9FtD8v1Hjl72LTttShxCknjdhn75 1yzfDZwiIlzsqbxc0M+iX6UGeZ6+As/ygwwo1l0qTjUu7aDP3RfQVe3trHk9WWBa8u8bLp+rm ppb4UYD Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Sat, 2 Jan 2016 14:54:30 +0100 Omit explicit initialisation at the beginning for five local variables which are redefined before their first use. Signed-off-by: Markus Elfring --- drivers/net/wireless/rsi/rsi_91x_pkt.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/rsi/rsi_91x_pkt.c b/drivers/net/wireless/rsi/rsi_91x_pkt.c index 702593f..ee98f5b 100644 --- a/drivers/net/wireless/rsi/rsi_91x_pkt.c +++ b/drivers/net/wireless/rsi/rsi_91x_pkt.c @@ -123,15 +123,15 @@ int rsi_send_mgmt_pkt(struct rsi_common *common, struct sk_buff *skb) { struct rsi_hw *adapter = common->priv; - struct ieee80211_hdr *wh = NULL; + struct ieee80211_hdr *wh; struct ieee80211_tx_info *info; - struct ieee80211_bss_conf *bss = NULL; + struct ieee80211_bss_conf *bss; struct ieee80211_hw *hw = adapter->hw; struct ieee80211_conf *conf = &hw->conf; struct skb_info *tx_params; - int status = -E2BIG; - __le16 *msg = NULL; - u8 extnd_size = 0; + int status; + __le16 *msg; + u8 extnd_size; u8 vap_id = 0; info = IEEE80211_SKB_CB(skb);