From patchwork Sat Jan 2 14:44:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 7940711 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 622A59F1C0 for ; Sat, 2 Jan 2016 14:44:35 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A4304203ED for ; Sat, 2 Jan 2016 14:44:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D01AE203B7 for ; Sat, 2 Jan 2016 14:44:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751880AbcABOod (ORCPT ); Sat, 2 Jan 2016 09:44:33 -0500 Received: from mout.web.de ([212.227.15.3]:51044 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751591AbcABOoa (ORCPT ); Sat, 2 Jan 2016 09:44:30 -0500 Received: from [192.168.1.2] ([77.181.40.156]) by smtp.web.de (mrweb003) with ESMTPSA (Nemesis) id 0LqDTc-1ZkSWA0EUK-00dnrm; Sat, 02 Jan 2016 15:44:26 +0100 Subject: [PATCH 2/3] rsi: Delete unnecessary variable initialisations in rsi_send_data_pkt() To: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Kalle Valo References: <566ABCD9.1060404@users.sourceforge.net> <5687E169.4070704@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <5687E248.8040902@users.sourceforge.net> Date: Sat, 2 Jan 2016 15:44:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <5687E169.4070704@users.sourceforge.net> X-Provags-ID: V03:K0:zIym9SOdz/jntfQz589xJW5oN1c5RgqksJ+LMFKPBth+IyV10EX wNpACOwyRHY1MtGi1omPVZ6pAOWZwz606QYaHSNh1PsUIaVa5gpYFxpXecnYrouFPk/Beik mBY4goOEJg6C/kpHmFMdyRIZTGv1Db17+e2HQGXEUv8LoHG1ge5ohAmmsxr5+W3c/qwgqbd la4qMCgSXkHNPvvoaFQNQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:jBlam69ldGM=:YBmGM81OldgKBXrhNVC20a BOL9V5kaT8sRvzNdm7CTyVG+u5LLrPzy3I9sL2WBv27b72IJf1Z5xVXffQkA19Rgg5ELJyLYa JVOcF0lbgWOIJAOaIX/dPXscXSWPZnIzB6O686nJEiL8cHyawlIJVtLNOfhbDCcmcxVg2w3gW ueEzAQuY/T0hVwVuo7CiVP7w4SHzJrcmJptghtpSDgO4Yc8IphU1AMxk7HTWMsD2USTQ7Lqg5 tG/mNGQdCymgR6/Fk+c/AAcp9bmad2YZb95SZYibEHKFFGuIY+biFoaMzLcuttzQHkSCn1mAq W4BqbxsNu7L9vdUIjiYSha1bJBTJ3cU6Juttymuj5DvvQjlbH7ZAnFrr/IcxIKl7i8etiEiYq M989Y2QhN8vNni9qIkCLKDkKOznOBgm7IwNmYLgO9EajbXNz8/wmI+OtkFnubNW8n662J7nYV 6az5nnKFurf9B7ZOeivjiBupmcyHQaidW+9DOO74tnpd34IsnPGFjNUNZXiwjxjC8lTuVww1z z4FIzhrfWFZndXDjnJzMfFEBHDB5CdG6ZKQj4b6RBp1PdmnhCyKQmsgS1uVaPuV+xsQhBN8Vk 7AyuzhAehhT7WttznVFhm6GBZOCfnH8hByZrakfeRYmy9UryuMkjQNpbuYWxbcEfjemT6iRHX eH79l3JGFOzECB6pMlFM8DcBIaGGaBzTcw2fmkcdjbyroAaif6/bzvV8B3xM9saU/pMh7BqCw j4D3N6XtS/xuGTtWRVXucp5nXFGz/JvmkhIsozjliHCMsABdIcs+DplKBzHDSKXx9SgVvsluU jZDRT3t Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Sat, 2 Jan 2016 15:15:12 +0100 Omit explicit initialisation at the beginning for four local variables which are redefined before their first use. Signed-off-by: Markus Elfring --- drivers/net/wireless/rsi/rsi_91x_pkt.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/rsi/rsi_91x_pkt.c b/drivers/net/wireless/rsi/rsi_91x_pkt.c index ee98f5b..ec65e1c 100644 --- a/drivers/net/wireless/rsi/rsi_91x_pkt.c +++ b/drivers/net/wireless/rsi/rsi_91x_pkt.c @@ -27,15 +27,15 @@ int rsi_send_data_pkt(struct rsi_common *common, struct sk_buff *skb) { struct rsi_hw *adapter = common->priv; - struct ieee80211_hdr *tmp_hdr = NULL; + struct ieee80211_hdr *tmp_hdr; struct ieee80211_tx_info *info; struct skb_info *tx_params; - struct ieee80211_bss_conf *bss = NULL; + struct ieee80211_bss_conf *bss; int status = -EINVAL; u8 ieee80211_size = MIN_802_11_HDR_LEN; - u8 extnd_size = 0; + u8 extnd_size; __le16 *frame_desc; - u16 seq_num = 0; + u16 seq_num; info = IEEE80211_SKB_CB(skb); bss = &info->control.vif->bss_conf;