From patchwork Sat Jan 2 18:27:33 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 7940901 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 74A06BEEE5 for ; Sat, 2 Jan 2016 18:28:09 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 99A5C203EC for ; Sat, 2 Jan 2016 18:28:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C0B02203E6 for ; Sat, 2 Jan 2016 18:28:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752052AbcABS1r (ORCPT ); Sat, 2 Jan 2016 13:27:47 -0500 Received: from mout.web.de ([212.227.15.14]:58709 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751818AbcABS1q (ORCPT ); Sat, 2 Jan 2016 13:27:46 -0500 Received: from [192.168.1.2] ([77.181.40.156]) by smtp.web.de (mrweb001) with ESMTPSA (Nemesis) id 0M1noI-1ZwOe22JAY-00tnG9; Sat, 02 Jan 2016 19:27:36 +0100 Subject: [PATCH v2 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt() References: <201601030008.47CwzW9c%fengguang.wu@intel.com> Cc: kbuild-all@01.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall To: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Kalle Valo From: SF Markus Elfring Message-ID: <56881695.4030308@users.sourceforge.net> Date: Sat, 2 Jan 2016 19:27:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <201601030008.47CwzW9c%fengguang.wu@intel.com> X-Provags-ID: V03:K0:Fizeu26NqaQH1qbBH1gpfFqVka9V+AHU5xMAYaRT90/fpf7gDOm L+RHK+YIzHMf7/5BP14xERbfzfXqKF4RKzRpapc59ta6Aa692bxeiSJWyWkRFIBbwogm9+I CT+OyuaubKJlieuD4KzzFzxVWIHSKgbkh87V4C/e27RZ8w4TcBmj3oFNQtcmn22E1A4M882 3sgH+Yfq2vyL1Toq95lAw== X-UI-Out-Filterresults: notjunk:1; V01:K0:Hq/re8t6RDw=:vZ5kwhP6PRPB9PSDBi2p20 C//A+SjAorb0SKCfJUPgu0rnWI3F9uCn8fljmg9LJzV7tJxG7DhUHtHDCsS4aAB97JzgOQ31K 8I27myz/LlpwHV6reybhQwQqf0Ihj3VWbllckj9tLZHM2C4k1Y4Jjj2ElXrWG2Oss20Lv9st0 pqpwQob78AMlWgAXHYYzcFsurlG+amJRhtvS8I8j9+5i5rXGQuXC1FK5aQoSuQFQMAxeYhZQD 1NLtf0mZekUV4D5wEHDvmJ8H4gFHHBEKaYNOey99QhQL/T6DDXK+cHCPpreL1RryqW7dqtYVb NzMY1l0MeQKTfkWfXAey/+bKLECcVKIymSuAKH8yl3JkRmxF+YiPlR/vkvFsgVmiR1no8AG1N Ci3suZrthA9R3piR4JR8veUURc0Q2TG/UD+5u3PCqInMICjSYsfjrKJoMoyLLIcDYniiRUxt+ ZxMRB6ppPuC9crP0SOLnDK7wuh7RqtzS7Sx6QVartQ9BbeB6Jb2wzVc6lmEVx1mfeFWMbHGyJ 1qxOAWysLAD4jsywBe3d/X7TyqrBi1fXyThvgBg0uyj8sZ5JM/ABUSNGo540xDppvqsoAf5ax M+3rQxkaAkG9yi0x3HzeekvxAtzn0xnVirHFvY8m5l9rHjRIfTjsqCj8tCLBisWjb4/jmRUpQ MF6JDyXW4zL1cRQxeUf9Lae9TY5+VCehVdMQB2w3qWEy2fFKd08PuT4gVVW/B57BlAnJ1sQkK 7Y+UPaLcQrFayr/4Yp8OyzQBeC6WDfMRoGXs7ROzx7PICubDnpefMCbIo3Me+c6WNjTg4mtn6 psOQASO Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Sat, 2 Jan 2016 19:22:36 +0100 Omit explicit initialisation at the beginning for four local variables which are redefined before their first use. Signed-off-by: Markus Elfring --- drivers/net/wireless/rsi/rsi_91x_pkt.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/rsi/rsi_91x_pkt.c b/drivers/net/wireless/rsi/rsi_91x_pkt.c index 702593f..571eaba 100644 --- a/drivers/net/wireless/rsi/rsi_91x_pkt.c +++ b/drivers/net/wireless/rsi/rsi_91x_pkt.c @@ -123,15 +123,15 @@ int rsi_send_mgmt_pkt(struct rsi_common *common, struct sk_buff *skb) { struct rsi_hw *adapter = common->priv; - struct ieee80211_hdr *wh = NULL; + struct ieee80211_hdr *wh; struct ieee80211_tx_info *info; - struct ieee80211_bss_conf *bss = NULL; + struct ieee80211_bss_conf *bss; struct ieee80211_hw *hw = adapter->hw; struct ieee80211_conf *conf = &hw->conf; struct skb_info *tx_params; int status = -E2BIG; - __le16 *msg = NULL; - u8 extnd_size = 0; + __le16 *msg; + u8 extnd_size; u8 vap_id = 0; info = IEEE80211_SKB_CB(skb);