From patchwork Mon Jan 8 09:31:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arend van Spriel X-Patchwork-Id: 10149183 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 75B4260210 for ; Mon, 8 Jan 2018 09:31:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6831021BED for ; Mon, 8 Jan 2018 09:31:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5CF232847B; Mon, 8 Jan 2018 09:31:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5C28B21BED for ; Mon, 8 Jan 2018 09:31:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756177AbeAHJbz (ORCPT ); Mon, 8 Jan 2018 04:31:55 -0500 Received: from mail-wm0-f48.google.com ([74.125.82.48]:34149 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755900AbeAHJby (ORCPT ); Mon, 8 Jan 2018 04:31:54 -0500 Received: by mail-wm0-f48.google.com with SMTP id y82so14963745wmg.1 for ; Mon, 08 Jan 2018 01:31:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=MCF6nfbTxBXAJMQb6GVgrra5YfZXr1vSs0lN35EFgOo=; b=aFE4LdRDyJJoHWaCOAPnLMg5mW5CKIBx8r1Ps/AvdfDDgV8h+817cjmj5IWhCpOBLY wDHyi7OLERGT/FtnHWcMxF2rZTxgFjsGawiK1Nfsr076sbuVyXsObK32/9KAXgTSlgYV c9ER5VgYjl7Uo9Zz2+FYw6cYottJhyCKErKos= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=MCF6nfbTxBXAJMQb6GVgrra5YfZXr1vSs0lN35EFgOo=; b=Z8a6LLF8WpK32PWMqjX1EvBtsia03sXdXcODo5ZJTaguB8v7AEFKVd0r3V2Gu4nA7d iFmb905VL2iK4+skE0m3gF7WRhkfVEfG06YpT+p+bTjCrJuhHqddgCFIw0sPKdlwsXX4 5NkuL4ZRD+4Kng6eudu4C0h7w8Yr+agBcgweIZ52Kms3xlAXZwHdh2BtJlwiEo1LZ5Ka nGVd3ghoF6JAGq0Bit63g2g1eCMf6bDzEF+BW6VVIx9+G4qZyiWn4s9EjGMC0YPJkqDt ngkA54STSr6vXzqLPqrEPvoMR3AjDp673tv30dUrqGfMcECK3OwfMluvWSOUq87GTcvZ gjKw== X-Gm-Message-State: AKGB3mKGwcQHoVh+me57ZSjp6Jo31S2Puwm6hLAOGcFrfiuKvNxc7O32 ONf36aXrjMlmIMLpf0RhJaRoRIMR X-Google-Smtp-Source: ACJfBoviUAA6PFAXU5ad+yMnaxAEIzMQXlAyuBRmfVdOBpdCI+1tCh0ljnShoxzHhqf9ghYrNQNSCA== X-Received: by 10.28.87.146 with SMTP id l140mr7922559wmb.86.1515403913318; Mon, 08 Jan 2018 01:31:53 -0800 (PST) Received: from [10.176.68.125] ([192.19.248.250]) by smtp.gmail.com with ESMTPSA id r68sm14186934wmd.47.2018.01.08.01.31.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Jan 2018 01:31:52 -0800 (PST) Subject: Re: brcmfmac: set p2p_disc error on BCM4350 To: William Dauchy , linux-wireless@vger.kernel.org References: From: Arend van Spriel Message-ID: <5A533A88.1000804@broadcom.com> Date: Mon, 8 Jan 2018 10:31:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 1/8/2018 12:49 AM, William Dauchy wrote: > Hello, > > Using the last v4.14.x I am getting this error at each boot, on my > BCM4350 802.11ac Wireless Network Adapter: > > brcmfmac: brcmf_p2p_create_p2pdev: set p2p_disc error > brcmfmac: brcmf_cfg80211_add_iface: add iface p2p-dev-wlp58s0 type 10 > failed: err=-16 > > The firmware used is: > brcmfmac: brcmf_c_preinit_dcmds: Firmware version = wl0: Oct 22 2015 > 06:16:26 version 7.35.180.119 (r594535) FWID 01-e791c176 > > I was wondering if this error could be fixed? This has been reported before, but not been able to look into it. Diving into firmware it seems that error can only occur if the mac address for the p2pdev interface is already used. So if possible can you rebuild the driver with the patch below applied and provide dmesg output and output of 'ifconfig -a'. Regards, Arend ---8<---------------------------------------------------------------- diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/n index 2ee5413..f96ad37 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c @@ -2065,6 +2065,7 @@ static struct wireless_dev *brcmf_p2p_create_p2pdev(struc int err; u32 bsscfgidx; + brcmf_err("enter: mac=%pM\n", addr); if (p2p->bss_idx[P2PAPI_BSSCFG_DEVICE].vif) return ERR_PTR(-ENOSPC);