From patchwork Fri Feb 23 09:54:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arend van Spriel X-Patchwork-Id: 10237185 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B1AF6602DC for ; Fri, 23 Feb 2018 09:54:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A879329044 for ; Fri, 23 Feb 2018 09:54:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9CE022918F; Fri, 23 Feb 2018 09:54:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E715C29044 for ; Fri, 23 Feb 2018 09:54:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751422AbeBWJyh (ORCPT ); Fri, 23 Feb 2018 04:54:37 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:53382 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751383AbeBWJyg (ORCPT ); Fri, 23 Feb 2018 04:54:36 -0500 Received: by mail-wm0-f53.google.com with SMTP id t74so3542773wme.3 for ; Fri, 23 Feb 2018 01:54:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=c+fPjNcXhpKGeQyRXuHZDQ2/lYVCeO70n+pvpkNl82Q=; b=TM742n+QZSkYjS2MHZIu4mwUAD++X9JYo4BmW4IvXCUI8SNST6EJ2xatrH/ETFWhXq O5q3H+Tb7fa///Vk3lcKN9aSot8el5vwZyZQSopiEk2bxYo+JeFOMvLXRKLoORjadrEY 1wynJ4emUZSf8KbnM6Z6hvJUgq7H+ST5YB3TU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=c+fPjNcXhpKGeQyRXuHZDQ2/lYVCeO70n+pvpkNl82Q=; b=leGx4ufwccvaZG/ZScS/Jz7vIHszYKHF5O3qbWEjIMIeFYiw5GZIjeVKUa5dwnEn25 AJ6RDK9cR6KX2Nd03zJ7LRSnj4ZaZq2QDosEjflaN+QttfneYA+DskDZZLvVYPhkJIqe b3WJX1bRq88ewBDDJX5ea3HtApXoWyrUSTEK1lsH3prKGatvuIAh3rt8FWhl2TOPg/NE u7c1RSLiMjSL6SY+mR1fIHmALwHg4TXFmJ2vUbeznGFRwu0rl7ifpAZdjzVQ5qiWxTSY rG1IsLqTpzHxIRy5I1BKLSK1gLakXVf/PKphk7Z6odBSYPG0v6w9egZuMNAly4215D6G MgTw== X-Gm-Message-State: APf1xPA9TPQnFVlhTbWL25qyZLd6IezCu8IpWqeM326+zNustWjq8bZA P+5dcljKd7QIX+M1Nsg4k/82og== X-Google-Smtp-Source: AH8x224mcVERZxqNccFgdmIwL1mn+kta/fSA31pjNl8w9Z/oA/mJ8lhqN3idvIV4zS6lhiBwV86bdg== X-Received: by 10.80.168.6 with SMTP id j6mr2034112edc.67.1519379674659; Fri, 23 Feb 2018 01:54:34 -0800 (PST) Received: from [192.168.178.129] (f140230.upc-f.chello.nl. [80.56.140.230]) by smtp.gmail.com with ESMTPSA id y17sm1837666edl.67.2018.02.23.01.54.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Feb 2018 01:54:34 -0800 (PST) Subject: Re: brcmfmac signal/interference issues To: Daniel Drake References: <5A8D36B7.1010201@broadcom.com> Cc: franky.lin@broadcom.com, hante.meuleman@broadcom.com, chi-hsien.lin@cypress.com, wright.feng@cypress.com, linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, Linux Upstreaming Team From: Arend van Spriel Message-ID: <5A8FE4D9.80608@broadcom.com> Date: Fri, 23 Feb 2018 10:54:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 2/23/2018 9:26 AM, Daniel Drake wrote: > Hi, > > On Wed, Feb 21, 2018 at 12:39 PM, Daniel Drake wrote: >> Thanks for looking into this. Here is the brcmfmac43455-sdio.txt file >> we are using: >> https://gist.github.com/dsd/d7ee3caa6dfd77f0bcd16cf272b20298 >> This is identical to the 4345r6nvram.txt file from windows. > > I checked Windows again and it seems to be using a firmware file > 4345r6rtecdc.bin alongside this nvram data. > This firmware is different from the one in linux-firmware. I've > uploaded it here: > https://drive.google.com/open?id=1MUsiaoozslJb8SCYOR-FNbJFuD-h4PY_ > > I was hoping to try this on Linux to see if it makes any difference to > the issue seen here. > However, with thisi firmware in place, I can't connect to the network > at all. It associates, wpa_supplicant never sees the first WPA2 key > message sent from the AP - even though wireshark on a separate monitor > shows that the key message was sent, and that the STA acked it. > > I turned off WPA2 to make it an open network instead, and now I am > unable to complete the DHCP conversation. According to the monitor > station, the STA succesfully transmits DHCPDISCOVER and the AP > responds with DHCPOFFER. The offer is acked, but dhclient never sees > it, and eventually times out. > > Any ideas why this firmware may not be working at all on linux? Yup. Windows firmware talks NDIS. If you run 'strings 4345r6rtecdc.bin | tail -1' you can see the firmware build target and it likely has 'ndis' in it. Now are you using BT as well on this device? Another suggestion I got is to disable transmit beamforming which brcmfmac enables by default. Not sure if this device supports it, but could you try the patch below. Regards, Arend diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c index 9be0b05..512ea57 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c @@ -363,9 +363,6 @@ int brcmf_c_preinit_dcmds(struct brcmf_if *ifp) goto done; } - /* Enable tx beamforming, errors can be ignored (not supported) */ - (void)brcmf_fil_iovar_int_set(ifp, "txbf", 1); - /* do bus specific preinit here */ err = brcmf_bus_preinit(ifp->drvr->bus_if); done: