From patchwork Mon May 7 15:44:34 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Larry Finger X-Patchwork-Id: 10384409 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3A96660236 for ; Mon, 7 May 2018 15:44:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 299E528B35 for ; Mon, 7 May 2018 15:44:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1BF2228B3E; Mon, 7 May 2018 15:44:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D1DF928B35 for ; Mon, 7 May 2018 15:44:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752174AbeEGPoi (ORCPT ); Mon, 7 May 2018 11:44:38 -0400 Received: from mail-ot0-f196.google.com ([74.125.82.196]:39615 "EHLO mail-ot0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751913AbeEGPog (ORCPT ); Mon, 7 May 2018 11:44:36 -0400 Received: by mail-ot0-f196.google.com with SMTP id l12-v6so32505725oth.6; Mon, 07 May 2018 08:44:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:to:cc:from:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=xp74QvXQNs8uxLCNbigEQshjHDU7VlJAUuW8a2n+B58=; b=dQZlQEXuixAnBOogS6o3ouRx3GK793k8sAEf0bGWbgKpGKlTVIW6u///iZL1GyNRnC pBdkt4bGR58n/RIvDHXdWZbM5rQ6rQtl9S5imeALmt6z4EIvSE489d3qpcq5M9QT5Jen RhdR3hLtKRpsmTEQp6GV8F5nyq+ZIQfKNUQFjekSz6YQdPcGxJdo6PqiidAEoS45FSbB Zj4F1C8SX8RQibu6SZgu5ZsV9xB7BFRnnKPwIGiTcft/26WeapQWqnNunpxaCWckJGJa gv+btu2RIqfn29H8aK+6NM/OKAd8dPFODNHpyz0+yLJ0+0dVfOEZmy3PeKAok8ZsR12x atsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:to:cc:from:subject:message-id:date :user-agent:mime-version:content-language:content-transfer-encoding; bh=xp74QvXQNs8uxLCNbigEQshjHDU7VlJAUuW8a2n+B58=; b=TCg3iQ0KIW16AAEBUbPqVVzzJIYaxVKOPQngWoJ5Qh5A8dVvG0CvK2/v0k/GdK/w7k nheC7COEc57LsuujSp1UF/zO0fqzMRVCc6hVZe9WX+DmoEtdHQBQ/g4DDQjtVj8mvsNu dMhbkcwe+DE/czaPqESaRJMpdygDtCQqSzd426yQ1jibCnQN1DmMLO3ah+ubHnmk+rCS 7TX6ce0lhFkk2xaUBcL+CtnZxXuNDjNttBhO1n7DwTn9ckjnhlaxsbxb9QmLExFfdFkC cuXHRXcJLhEYuhyn79Nlx18xvACmEspger4vYB/p7x30VszihtIx6azQ4URR7YbWLfl4 Lx7Q== X-Gm-Message-State: ALQs6tBKbEt8XGOC8KptPkAwPATMinzfmaEZtYPFNgvwkHXyV9EbJl1R pwAw+t0e0gz7sc1HwmlR3ECmSA== X-Google-Smtp-Source: AB8JxZrethJj8GojzIfpUBOuN451/QzXPiP1vag5gTeEby+WLEq8ZqmsfFNGlTh18EkLx/YIc2PJpQ== X-Received: by 2002:a9d:b75:: with SMTP id p50-v6mr25567597otd.277.1525707876134; Mon, 07 May 2018 08:44:36 -0700 (PDT) Received: from Larrylap.localdomain (cpe-24-31-253-228.kc.res.rr.com. [24.31.253.228]) by smtp.gmail.com with ESMTPSA id 89-v6sm13905299ote.71.2018.05.07.08.44.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 May 2018 08:44:35 -0700 (PDT) To: Matt Redfearn , =?UTF-8?Q?Michael_B=c3=bcsch?= , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Kalle Valo , linux-wireless , LKML From: Larry Finger Subject: Regression caused by commit 882164a4a928 Message-ID: <7bbc067a-c412-3d2e-174a-abc31b46e246@lwfinger.net> Date: Mon, 7 May 2018 10:44:34 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 Content-Language: en-US Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Matt, Although commit 882164a4a928 ("ssb: Prevent build of PCI host features in module") appeared to be harmless, it leads to complete failure of drivers b43. and b43legacy, and likely affects b44 as well. The problem is that CONFIG_SSB_PCIHOST is undefined, which prevents the compilation of the code that controls the PCI cores of the device. See https://bugzilla.redhat.com/show_bug.cgi?id=1572349 for details. As the underlying errors ("pcibios_enable_device" undefined, and "register_pci_controller" undefined) do not appear on the architectures that I have tested (x86_64, x86, and ppc), I suspect something in the arch-specific code for your setup (MIPS?). As I have no idea on how to fix that problem, would the following patch work for you? Thanks, Larry Tested-by: Matt Redfearn diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig index 9371651d8017..3743533c8057 100644 --- a/drivers/ssb/Kconfig +++ b/drivers/ssb/Kconfig @@ -117,7 +117,7 @@ config SSB_SERIAL config SSB_DRIVER_PCICORE_POSSIBLE bool - depends on SSB_PCIHOST && SSB = y + depends on SSB_PCIHOST && (SSB = y || !MIPS) default y config SSB_DRIVER_PCICORE