Message ID | 87a8hlz91i.fsf@kamboji.qca.qualcomm.com (mailing list archive) |
---|---|
State | Not Applicable |
Delegated to: | Kalle Valo |
Headers | show |
From: Kalle Valo <kvalo@codeaurora.org> Date: Wed, 13 Jul 2016 21:29:13 +0300 > here's a pull request for net-next. This time there are few conflicts > due to the cfg80211 scan API changes, and one of them is easy to miss, > so please pay extra attention to them. Otherwise there's not nothing > really out of ordinary. Please note that I also pulled wireless-drivers > to wireless-drivers-next to reduce the amount of conflicts. > > So about the conflicts, the obvious are notified by git: ... > I have attached the output from git diff as an example how to resolve > this, hopefully that helps. Please let me know if there are any problems > or if you want to handle these differently. Thanks for all of the conflict resolution info, it really helped. I pushed this all out, please double check my work. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, [auto build test ERROR on wireless-drivers-next/master] [cannot apply to v4.7-rc7 next-20160714] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Kalle-Valo/pull-request-wireless-drivers-next-2016-07-13/20160714-023750 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: sparc64-allmodconfig (attached as .config) compiler: sparc64-linux-gnu-gcc (Debian 5.3.1-8) 5.3.1 20160205 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=sparc64 All error/warnings (new ones prefixed by >>): drivers/net/wireless/marvell/mwifiex/scan.c: In function 'mwifiex_cancel_scan': >> drivers/net/wireless/marvell/mwifiex/scan.c:2024:12: error: variable 'info' has initializer but incomplete type struct cfg80211_scan_info info = { ^ >> drivers/net/wireless/marvell/mwifiex/scan.c:2025:6: error: unknown field 'aborted' specified in initializer .aborted = true, ^ >> drivers/net/wireless/marvell/mwifiex/scan.c:2025:17: warning: excess elements in struct initializer .aborted = true, ^ drivers/net/wireless/marvell/mwifiex/scan.c:2025:17: note: (near initialization for 'info') >> drivers/net/wireless/marvell/mwifiex/scan.c:2024:31: error: storage size of 'info' isn't known struct cfg80211_scan_info info = { ^ >> drivers/net/wireless/marvell/mwifiex/scan.c:2024:31: warning: unused variable 'info' [-Wunused-variable] vim +/info +2024 drivers/net/wireless/marvell/mwifiex/scan.c 2018 spin_unlock_irqrestore(&adapter->mwifiex_cmd_lock, cmd_flags); 2019 for (i = 0; i < adapter->priv_num; i++) { 2020 priv = adapter->priv[i]; 2021 if (!priv) 2022 continue; 2023 if (priv->scan_request) { > 2024 struct cfg80211_scan_info info = { > 2025 .aborted = true, 2026 }; 2027 2028 mwifiex_dbg(adapter, INFO, --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
kbuild test robot <lkp@intel.com> writes: > Hi, > > [auto build test ERROR on wireless-drivers-next/master] > [cannot apply to v4.7-rc7 next-20160714] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Kalle-Valo/pull-request-wireless-drivers-next-2016-07-13/20160714-023750 > base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master > config: sparc64-allmodconfig (attached as .config) > compiler: sparc64-linux-gnu-gcc (Debian 5.3.1-8) 5.3.1 20160205 > reproduce: > wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > make.cross ARCH=sparc64 > > All error/warnings (new ones prefixed by >>): > > drivers/net/wireless/marvell/mwifiex/scan.c: In function 'mwifiex_cancel_scan': >>> drivers/net/wireless/marvell/mwifiex/scan.c:2024:12: error: variable 'info' has initializer but incomplete type > struct cfg80211_scan_info info = { The diff was just an example to help Dave fix few conflicts in my pull request, it was not meant to be applied directly.
David Miller <davem@davemloft.net> writes: > From: Kalle Valo <kvalo@codeaurora.org> > Date: Wed, 13 Jul 2016 21:29:13 +0300 > >> here's a pull request for net-next. This time there are few conflicts >> due to the cfg80211 scan API changes, and one of them is easy to miss, >> so please pay extra attention to them. Otherwise there's not nothing >> really out of ordinary. Please note that I also pulled wireless-drivers >> to wireless-drivers-next to reduce the amount of conflicts. >> >> So about the conflicts, the obvious are notified by git: > ... >> I have attached the output from git diff as an example how to resolve >> this, hopefully that helps. Please let me know if there are any problems >> or if you want to handle these differently. > > Thanks for all of the conflict resolution info, it really helped. > > I pushed this all out, please double check my work. Looks good, thanks!
--- a/drivers/net/wireless/marvell/mwifiex/scan.c +++ b/drivers/net/wireless/marvell/mwifiex/scan.c @@ -2029,9 +2029,13 @@ void mwifiex_cancel_scan(struct mwifiex_adapter *adapter) if (!priv) continue; if (priv->scan_request) { + struct cfg80211_scan_info info = { + .aborted = true, + }; + mwifiex_dbg(adapter, INFO, "info: aborting scan\n"); - cfg80211_scan_done(priv->scan_request, 1); + cfg80211_scan_done(priv->scan_request, &info); priv->scan_request = NULL; priv->scan_aborting = false; }