From patchwork Thu Dec 3 06:54:16 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kalle Valo X-Patchwork-Id: 7756661 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id CCFF1BEEE1 for ; Thu, 3 Dec 2015 06:54:26 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 03402204D3 for ; Thu, 3 Dec 2015 06:54:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2DAC3204D2 for ; Thu, 3 Dec 2015 06:54:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756954AbbLCGyX (ORCPT ); Thu, 3 Dec 2015 01:54:23 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:52026 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751837AbbLCGyW (ORCPT ); Thu, 3 Dec 2015 01:54:22 -0500 Received: from smtp.codeaurora.org (localhost [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 19173141089; Thu, 3 Dec 2015 06:54:22 +0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 486) id 0BB3F141095; Thu, 3 Dec 2015 06:54:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from potku.adurom.net (a88-115-185-251.elisa-laajakaista.fi [88.115.185.251]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 0F3F4141090; Thu, 3 Dec 2015 06:54:20 +0000 (UTC) From: Kalle Valo To: "John W. Linville" Cc: linux-wireless@vger.kernel.org Subject: wireless-testing regression: Could not configure driver mode Date: Thu, 03 Dec 2015 08:54:16 +0200 Message-ID: <87fuzkf2ef.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi John, with latest wireless-testing[1] I noticed that I cannot start AP mode anymore with ath10k: nl80211: Subscribe to mgmt frames with AP handle 0x9e5b410 nl80211: Register frame type=0xb0 nl_handle=0x9e5b410 match= nl80211: Register frame command failed (type=176): ret=-95 (Operation not supported) nl80211: Register frame match - hexdump(len=0): [NULL] nl80211: Could not configure driver mode With help of Johannes we find out that there are odd changes in wireless-testing[2]. Reverting the change in cfg.c fixed my regression, but I don't know really know what has happened. Kalle [1] To be exact I was using ath.git master branch but that's just wireless-testing plus latest ath patches so should affect here. [2] $ git diff master-2015-11-27..master-2015-11-30 -- net/mac80211 --- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c index 2d1c4c35186d..b3a708366a5a 100644 --- a/net/mac80211/cfg.c +++ b/net/mac80211/cfg.c @@ -3384,8 +3384,6 @@ const struct cfg80211_ops mac80211_config_ops = { .set_bitrate_mask = ieee80211_set_bitrate_mask, .remain_on_channel = ieee80211_remain_on_channel, .cancel_remain_on_channel = ieee80211_cancel_remain_on_channel, - .mgmt_tx = ieee80211_mgmt_tx, - .mgmt_tx_cancel_wait = ieee80211_mgmt_tx_cancel_wait, .set_cqm_rssi_config = ieee80211_set_cqm_rssi_config, .mgmt_frame_register = ieee80211_mgmt_frame_register, .set_antenna = ieee80211_set_antenna, diff --git a/net/mac80211/offchannel.c b/net/mac80211/offchannel.c index ce8e1a6c7281..cfd3356e26fd 100644 --- a/net/mac80211/offchannel.c +++ b/net/mac80211/offchannel.c @@ -916,6 +916,13 @@ int ieee80211_mgmt_tx(struct wiphy *wiphy, struct wireless_dev *wdev, kfree_skb(skb); goto out_unlock; } + } else { + /* Assign a dummy non-zero cookie, it's not sent to + * userspace in this case but we rely on its value + * internally in the need_offchan case to distinguish + * mgmt-tx from remain-on-channel. + */ + *cookie = 0xffffffff; } if (!need_offchan) {