From patchwork Thu Jan 29 12:44:49 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kalle Valo X-Patchwork-Id: 5742021 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 2A6AF9F358 for ; Thu, 29 Jan 2015 12:45:10 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6B44A2022D for ; Thu, 29 Jan 2015 12:45:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7531320222 for ; Thu, 29 Jan 2015 12:45:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753049AbbA2MpF (ORCPT ); Thu, 29 Jan 2015 07:45:05 -0500 Received: from sabertooth01.qualcomm.com ([65.197.215.72]:16081 "EHLO sabertooth01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751793AbbA2MpE (ORCPT ); Thu, 29 Jan 2015 07:45:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=qca.qualcomm.com; i=@qca.qualcomm.com; q=dns/txt; s=qcdkim; t=1422535504; x=1454071504; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=RQCDxFcULpbwQW3O2cN5EhlLxdcLwCymWEuAtLBg72E=; b=ScdwVYa1slctEJOhqx8cG5BdXXsIC+ltOHZoeJ6HHvPzbEQW5SYhtMu6 fGbLvHk4IWC/72YdgqO1xZ00iBK9wCTL/lGUvdjlVdsmjQpiiT8wUhgwt 7s3Y9fvCgq2Yl3ZdsUuy+nzPfqHtq4AnhGjWneLYLz5GtCJhIJMzjMfX4 E=; X-IronPort-AV: E=McAfee;i="5600,1067,7695"; a="82326298" Received: from ironmsg02-lv.qualcomm.com ([10.47.202.183]) by sabertooth01.qualcomm.com with ESMTP; 29 Jan 2015 04:45:03 -0800 X-IronPort-AV: E=Sophos;i="5.09,485,1418112000"; d="scan'208";a="31613777" Received: from nalasexr01g.na.qualcomm.com ([10.49.56.53]) by ironmsg02-lv.qualcomm.com with ESMTP/TLS/RC4-SHA; 29 Jan 2015 04:45:03 -0800 Received: from potku.adurom.net (10.80.80.8) by NALASEXR01G.na.qualcomm.com (10.49.56.53) with Microsoft SMTP Server (TLS) id 15.0.995.29; Thu, 29 Jan 2015 04:45:00 -0800 From: Kalle Valo To: Michal Kazior CC: , Subject: Re: [PATCH] ath10k: enable qca6174 hw3.2 References: <1422534273-18427-1-git-send-email-michal.kazior@tieto.com> Date: Thu, 29 Jan 2015 14:44:49 +0200 In-Reply-To: <1422534273-18427-1-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Thu, 29 Jan 2015 13:24:33 +0100") Message-ID: <87r3ud21tq.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: NASANEXM01H.na.qualcomm.com (10.85.0.34) To NALASEXR01G.na.qualcomm.com (10.49.56.53) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Michal Kazior writes: > The 3.2 revision has a different target BMI > version so it wasn't recognized by ath10k (despite > the chip_id rev being on the supported list > already). > > Signed-off-by: Michal Kazior But uses the same binaries as hw3.0? > + { > + .id = QCA6174_HW_3_2_VERSION, > + .name = "qca6174 hw3.2", > + .patch_load_addr = QCA6174_HW_3_0_PATCH_LOAD_ADDR, > + .uart_pin = 6, > + .fw = { > + .dir = QCA6174_HW_3_0_FW_DIR, > + .fw = QCA6174_HW_3_0_FW_FILE, > + .otp = QCA6174_HW_3_0_OTP_FILE, > + .board = QCA6174_HW_3_0_BOARD_DATA_FILE, > + .board_size = QCA6174_BOARD_DATA_SZ, > + .board_ext_size = QCA6174_BOARD_EXT_DATA_SZ, > + }, > + }, > }; I added this in pending branch to avoid people wondering why it uses 3.0 binaries: diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c index 36a8fcf349fa..310e12bc078a 100644 --- a/drivers/net/wireless/ath/ath10k/core.c +++ b/drivers/net/wireless/ath/ath10k/core.c @@ -91,6 +91,7 @@ static const struct ath10k_hw_params ath10k_hw_params_list[] = { .patch_load_addr = QCA6174_HW_3_0_PATCH_LOAD_ADDR, .uart_pin = 6, .fw = { + /* uses same binaries as hw3.0 */ .dir = QCA6174_HW_3_0_FW_DIR, .fw = QCA6174_HW_3_0_FW_FILE, .otp = QCA6174_HW_3_0_OTP_FILE,