From patchwork Mon Jan 12 11:43:46 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kalle Valo X-Patchwork-Id: 5609611 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 41D14C058D for ; Mon, 12 Jan 2015 11:44:03 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 84FDB20608 for ; Mon, 12 Jan 2015 11:44:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4EDD205E4 for ; Mon, 12 Jan 2015 11:44:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752215AbbALLn7 (ORCPT ); Mon, 12 Jan 2015 06:43:59 -0500 Received: from wolverine01.qualcomm.com ([199.106.114.254]:14785 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751707AbbALLn6 (ORCPT ); Mon, 12 Jan 2015 06:43:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=qca.qualcomm.com; i=@qca.qualcomm.com; q=dns/txt; s=qcdkim; t=1421063039; x=1452599039; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=c+etuVpP28MUpT75Vzo5c9+tmvvfUm9b9rlfNxBiU8o=; b=DVODZIIBb5WJEyuqvYWp/FmnOyKd7gh5WT9Lyrrnq2wGZP3SckDtkLvS EDPTV5JUu2za5pYrg1vlqzwD7mnGol2V8hgAbCsQ3YURpkDem5tzsNarI 3dPyPtvFb8VBktd3XeveN5tPquhPqYSNSEaGuyJhDh3/ep82NUEOAwqvJ g=; X-IronPort-AV: E=McAfee;i="5600,1067,7678"; a="97734234" Received: from ironmsg03-lv.qualcomm.com ([10.47.202.181]) by wolverine01.qualcomm.com with ESMTP; 12 Jan 2015 03:43:59 -0800 X-IronPort-AV: E=Sophos;i="5.07,743,1413270000"; d="scan'208";a="25675893" Received: from nalasexr01g.na.qualcomm.com ([10.49.56.53]) by ironmsg03-lv.qualcomm.com with ESMTP/TLS/RC4-SHA; 12 Jan 2015 03:43:57 -0800 Received: from potku.adurom.net.qca.qualcomm.com (10.80.80.8) by NALASEXR01G.na.qualcomm.com (10.49.56.53) with Microsoft SMTP Server (TLS) id 15.0.995.29; Mon, 12 Jan 2015 03:43:55 -0800 From: Kalle Valo To: Rajkumar Manoharan CC: , Subject: Re: [PATCH v2 7/8] ath10k: add support to send addba response References: <1419407949-32367-1-git-send-email-rmanohar@qti.qualcomm.com> <1419407949-32367-8-git-send-email-rmanohar@qti.qualcomm.com> Date: Mon, 12 Jan 2015 13:43:46 +0200 In-Reply-To: <1419407949-32367-8-git-send-email-rmanohar@qti.qualcomm.com> (Rajkumar Manoharan's message of "Wed, 24 Dec 2014 13:29:08 +0530") Message-ID: <87y4p8dy19.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: NASANEXM01C.na.qualcomm.com (10.85.0.83) To NALASEXR01G.na.qualcomm.com (10.49.56.53) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Rajkumar Manoharan writes: > This per-station debugfs entry helps to send addba response in > manual mode for debugging purpose. It accepts tid and status code > as input arguments. > > To send addba response, > > echo 0 25 >/sys/kernel/debug/ieee80211/phyX/netdev:wlanX/ > stations/XX:XX:XX:XX:XX:XX/addba_resp > > Signed-off-by: Rajkumar Manoharan Same here: --- a/drivers/net/wireless/ath/ath10k/debugfs_sta.c +++ b/drivers/net/wireless/ath/ath10k/debugfs_sta.c @@ -148,16 +148,12 @@ static ssize_t ath10k_dbg_sta_write_addba_resp(struct file *file, buf[sizeof(buf) - 1] = '\0'; ret = sscanf(buf, "%u %u", &tid, &status); - if (ret != 2) { - ath10k_warn(ar, "ex: echo >addba_resp\n"); + if (ret != 2) return -EINVAL; - } /* Valid TID values are 0 through 15 */ - if (tid > HTT_DATA_TX_EXT_TID_MGMT - 2) { - ath10k_warn(ar, "Invalid TID %u\n", tid); + if (tid > HTT_DATA_TX_EXT_TID_MGMT - 2) return -EINVAL; - } mutex_lock(&ar->conf_mutex); if ((ar->state != ATH10K_STATE_ON) ||