From patchwork Sun Jul 24 20:20:08 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 9245033 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 68D3F60757 for ; Sun, 24 Jul 2016 20:20:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 56F822521F for ; Sun, 24 Jul 2016 20:20:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4A834262FF; Sun, 24 Jul 2016 20:20:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E053E2521F for ; Sun, 24 Jul 2016 20:20:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752157AbcGXUU0 (ORCPT ); Sun, 24 Jul 2016 16:20:26 -0400 Received: from mout.web.de ([212.227.15.4]:55873 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751449AbcGXUUY (ORCPT ); Sun, 24 Jul 2016 16:20:24 -0400 Received: from [192.168.1.2] ([78.48.64.218]) by smtp.web.de (mrweb004) with ESMTPSA (Nemesis) id 0MQt6E-1btVdh3s6w-00UMG1; Sun, 24 Jul 2016 22:20:16 +0200 Subject: [PATCH 1/3] staging: wilc1000: Delete an unnecessary check before the function call "release_firmware" To: linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, Austin Shin , Chris Park , Glen Lee , Greg Kroah-Hartman , Johnny Kim , Leo Kim , Tony Cho References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <558EB32E.6090003@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <97d9e92f-ae7a-1161-c9a2-cb19fb2f2b55@users.sourceforge.net> Date: Sun, 24 Jul 2016 22:20:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: X-Provags-ID: V03:K0:/Rixq1lX/jqh86fahamgjufuXf3JNU+WMY1lw6suZEWpqmTKD65 RWFEfpFpIG2sMvbF0y4NRINth4jb9U7Sm6Z3p59uxqZsKGf8Ok9DH8DouaPim0/esSPyzUB Ock5SgnzBDR9/6PafcMUZuZC1TiUUl8xCKC3osOTBzcFxQfNWksDQKZnTClQlAwQTXvQzCo 27BQc6SgrwPwa/bwvfsxA== X-UI-Out-Filterresults: notjunk:1; V01:K0:0a/uPEb1hzI=:MxBsPYb2H73pF7Jf63gz+B 6Bo3WBO09JeH4pNSQ/7inR9YI69r7bVbnfcWLcrlBKJORHDN+ViXE3gcxNV6cXCaDbK+FE4rI p4MFjAuHXvnwI4XpMmjq4NN8c5ZWw1H6pTpQUezHh6KIAsLhPGxg9ITXgakSf8XdAJhAaCKDy vaftAHSnbo6KIWmRaWyB0SvzZxqdry0LUy3x3/m1kCcQvkrlDbds5Cu+wVEGC9rWnIqmrCqjP nr4BupXoWksH/o0WYQIdy+5a8r0eeyZHRVbedT2fjqeLWDrmgZ8R4HUvIcH/FsGEqkj3dglc+ BnMAEf1YbIeoC9RvMJA7oUfNx7Kw5bRNLVnmfhu6C9q0Ptfd8PQxJo0YWsxafYEEy0Fn+ClS3 U0sdf8khgHO3ZwAi2L0+DQWX0D4Hgar9IorGAQsZ3C2F53WaExG6joelTv5aFZYthowRtOG93 NTSTLQXdMBwtngDVONje5raOxvJnBrBL61kLBl5qfkhejOAR3PL2luriGEIJfFdOlaPdHqded QenLYEI6rOR21hyavslBZjZBPtLZhQDiH0s2LUNu7R9sGmKk4LSGBhUMUrRbcTRhrdLFB78Ar 92tIFfvAVYJac1wZuENBIwdWm/9f9MO/RcYS7JSuCQeIQZ/Btr//58fR46I5t6/OPeVMQ/tUb 4AOW3BpBKuCMogqnUV/uHGeWvLfDmxzKIiYWgA5fAHXR9vOf810S24lfPdw7gFZzJibaCD5gU WU17fV0TpwiBZywvnYyevrd+E/C4FiORkB2LxccJnYOLmx+aSWB/N0raGech+5sWPQZgUPKwo Ro0fyfP Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Sun, 24 Jul 2016 21:00:20 +0200 The release_firmware() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/staging/wilc1000/linux_wlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c index 3a66255..cdef645 100644 --- a/drivers/staging/wilc1000/linux_wlan.c +++ b/drivers/staging/wilc1000/linux_wlan.c @@ -1223,7 +1223,7 @@ void wilc_netdev_cleanup(struct wilc *wilc) vif[i] = netdev_priv(wilc->vif[i]->ndev); } - if (wilc && wilc->firmware) { + if (wilc) { release_firmware(wilc->firmware); wilc->firmware = NULL; }