From patchwork Fri Jun 5 09:46:03 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 6552321 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id D4B31C0020 for ; Fri, 5 Jun 2015 09:46:09 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0C28720766 for ; Fri, 5 Jun 2015 09:46:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E7E5920762 for ; Fri, 5 Jun 2015 09:46:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754035AbbFEJqG (ORCPT ); Fri, 5 Jun 2015 05:46:06 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:37733 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751700AbbFEJqE convert rfc822-to-8bit (ORCPT ); Fri, 5 Jun 2015 05:46:04 -0400 Received: by wifx6 with SMTP id x6so14680451wif.0 for ; Fri, 05 Jun 2015 02:46:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=aa8CpzThHalyDFGSP7dEuYqPST7n2XhuyvwbnbA2n1g=; b=ET0ucNglpsVwLJIxHtKJYVh4lJ6SuSpU2qLS5MAbcqkB5aIAzOqY/cuCImfq7iD4Tb DWs6g86IWi6Z0sK6CN5M3cqGWOKEOLmEJZeqfrjS8fe74fdo1Z8VWZTKsCwVY8uDBNtX 1GfgOOhQFmJe9EZ8OkSlmKAXCDnT5o2ZejoBc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=aa8CpzThHalyDFGSP7dEuYqPST7n2XhuyvwbnbA2n1g=; b=bgYP7PaKN4cqtkmTbA2hSLhsuBh7mRZWq5jc+Vuh4G0oLWewF/kNQUdXwf0uAeo+W0 Jzd1I44LQ2qFrIbvHxIJkDsOZ9714lEkCTPisIe7SffZKOC3F1ax+Y1evw73o7dU2wVp t6JW8dOcvjXL/6BnG53NqnX6uqodXpDqKYvSuOtyyhaHuAXRdd8cMv+vTcH+vmdySq6B 9qN7VUYnbStR6ASb2ZyOdcgDtCf50/FrxCHctZMDm7AIqR5669mGy0lzhEfD23YWdD3t 4ud6s78pmZcpUa34mUY4O3FfLy3tGuqtQNxXCjDvfWu3an7o0AYzAeFP9RI10YloFB49 bXlA== X-Gm-Message-State: ALoCoQlqi7u3D5qCI8CQ5J5mp8YXWfgJmfSF9+Me+E9Ngz5obaiQg8yndGqDRpEJt4A+0/8nI8bzGLvcMpqI50uFSi9mPzRRRU0Ydrz3tm6cDjXCVzlH4+1Xg0zSkDHDPlpqCKPVT1ZT MIME-Version: 1.0 X-Received: by 10.194.84.179 with SMTP id a19mr4785917wjz.29.1433497563436; Fri, 05 Jun 2015 02:46:03 -0700 (PDT) Received: by 10.27.227.8 with HTTP; Fri, 5 Jun 2015 02:46:03 -0700 (PDT) In-Reply-To: <01f701d09f71$47ae9910$d70bcb30$@acksys.fr> References: <01eb01d09f64$fd522730$f7f67590$@acksys.fr> <01f701d09f71$47ae9910$d70bcb30$@acksys.fr> Date: Fri, 5 Jun 2015 11:46:03 +0200 Message-ID: Subject: Re: ATH10K and VLAN : Frame with VLAN tag are not sent From: Michal Kazior To: voncken Cc: linux-wireless , "ath10k@lists.infradead.org" X-DomainID: tieto.com Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 5 June 2015 at 11:23, voncken wrote: [...] >> I see no reason why this should fail. The dot1q encapsulation shouldn't >> influence how firmware behaves.. but maybe I'm wrong. >> >> It's still unclear to me what your topology looks like. Perhaps you're >> having problem with environmental configuration itself? Did you try other >> Wi-Fi device (e.g. ath9k) instead of ath10k? > Yes I tested with ath9k wireless card, the same configuration works. > > I did an interesting test. With ostinato software I generate an ICMP frame without vlan tag. I changed the ethertype in the frame. > I tried with the ethertype 0x800 (IP), 0x801, 0x8892 (PROFINET), 0x8100 (dot1q), 0x0600. All frames are sent except when the ethertype is set to 0x8100. It seems the firmware do not accept the ethertype 0x8100. Interesting. This may suggest firmware actually doesn't handle dot1q VLAN tagging properly in NWifi Tx encap mode. Can you try changing it to 802.3 encap and re-test, please? Note: Your backports may not have the necessary code.. In which case it'll be difficult to do this the easy way. If that's the case I suggest you get latest backports or generate them yourself from the latest kvalo/ath master. Micha? --- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -3172,7 +3172,7 @@ ath10k_tx_h_get_txmode(struct ath10k *ar, struct ieee80211_vif *vif, if (ieee80211_is_data_present(fc) && sta && sta->tdls) return ATH10K_HW_TXRX_ETHERNET; - return ATH10K_HW_TXRX_NATIVE_WIFI; + return ATH10K_HW_TXRX_ETHERNET; }