diff mbox

[RFC] crda: Fix the linking order to avoid compilation error

Message ID CABPxzY+CnnssaZpqgWuJ=QH-k=zJbHpLaGkJXAQSWSxq7kKa6Q@mail.gmail.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Krishna Chaitanya Dec. 16, 2013, 4:27 p.m. UTC
While linking the crda.o and libreg.so, first put crda.o
and then -lreg. This fixed the below error:

# make
  GEN  keys-gcrypt.c
  Trusted pubkeys: pubkeys/linville.key.pub.pem
  CC   libreg.so
  CC   crda.o
  LD   crda
crda.o: In function `main':
crda/crda.c:196: undefined reference to `reglib_get_rd_alpha2'
collect2: ld returned 1 exit status
make: *** [crda] Error 1

Note: This still doesn't fix the below error (will send another mail)

  CHK  /usr/lib/crda/regulatory.bin
Database signature verification failed.
Invalid or empty regulatory file, note: a binary regulatory file should be used.
make: *** [verify] Error 234

Signed-off-by: Chaitanya T K <chaitanya.mgit@gmail.com>
---
 Makefile |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Kalle Valo Feb. 14, 2014, 9:05 a.m. UTC | #1
Krishna Chaitanya <chaitanya.mgit@gmail.com> writes:

> While linking the crda.o and libreg.so, first put crda.o
> and then -lreg. This fixed the below error:
>
> # make
>   GEN  keys-gcrypt.c
>   Trusted pubkeys: pubkeys/linville.key.pub.pem
>   CC   libreg.so
>   CC   crda.o
>   LD   crda
> crda.o: In function `main':
> crda/crda.c:196: undefined reference to `reglib_get_rd_alpha2'
> collect2: ld returned 1 exit status
> make: *** [crda] Error 1

[...]

> Signed-off-by: Chaitanya T K <chaitanya.mgit@gmail.com>
> ---
>  Makefile |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 4a351c6..0b2f0d7 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -28,10 +28,11 @@ RUNTIME_PUBKEY_DIR?=/etc/wireless-regdb/pubkeys
>  CFLAGS += -O2 -fpic
>  CFLAGS += -std=gnu99 -Wall -Werror -pedantic
>  CFLAGS += -Wall -g
> -LDLIBS += -lm
>  LDLIBREG += -lreg
> +LDLIBS += $(LDLIBREG)
> +LDLIBS += -lm
>  LIBREG += libreg.so
> -LDFLAGS += -L ./ $(LDLIBREG)
> +LDFLAGS += -L ./
>
>  all: all_noverify verify

Without this patch crda didn't compile on my Ubuntu 12.04 box. IMHO this
should be applied.
Luis R. Rodriguez Feb. 19, 2014, 9:55 p.m. UTC | #2
On Mon, Dec 16, 2013 at 8:27 AM, Krishna Chaitanya
<chaitanya.mgit@gmail.com> wrote:
> While linking the crda.o and libreg.so, first put crda.o
> and then -lreg. This fixed the below error:
>
> # make
>   GEN  keys-gcrypt.c
>   Trusted pubkeys: pubkeys/linville.key.pub.pem
>   CC   libreg.so
>   CC   crda.o
>   LD   crda
> crda.o: In function `main':
> crda/crda.c:196: undefined reference to `reglib_get_rd_alpha2'
> collect2: ld returned 1 exit status
> make: *** [crda] Error 1
>
> Note: This still doesn't fix the below error (will send another mail)
>
>   CHK  /usr/lib/crda/regulatory.bin
> Database signature verification failed.
> Invalid or empty regulatory file, note: a binary regulatory file should be used.
> make: *** [verify] Error 234
>
> Signed-off-by: Chaitanya T K <chaitanya.mgit@gmail.com>

Applied and pushed, thanks!

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Makefile b/Makefile
index 4a351c6..0b2f0d7 100644
--- a/Makefile
+++ b/Makefile
@@ -28,10 +28,11 @@  RUNTIME_PUBKEY_DIR?=/etc/wireless-regdb/pubkeys
 CFLAGS += -O2 -fpic
 CFLAGS += -std=gnu99 -Wall -Werror -pedantic
 CFLAGS += -Wall -g
-LDLIBS += -lm
 LDLIBREG += -lreg
+LDLIBS += $(LDLIBREG)
+LDLIBS += -lm
 LIBREG += libreg.so
-LDFLAGS += -L ./ $(LDLIBREG)
+LDFLAGS += -L ./

 all: all_noverify verify
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in