From patchwork Wed Dec 5 09:13:09 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krishna Chaitanya X-Patchwork-Id: 1840571 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 43011DF266 for ; Wed, 5 Dec 2012 09:13:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752109Ab2LEJNb (ORCPT ); Wed, 5 Dec 2012 04:13:31 -0500 Received: from mail-ie0-f174.google.com ([209.85.223.174]:40919 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751710Ab2LEJNa (ORCPT ); Wed, 5 Dec 2012 04:13:30 -0500 Received: by mail-ie0-f174.google.com with SMTP id c11so7732788ieb.19 for ; Wed, 05 Dec 2012 01:13:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:cc:content-type; bh=5Ke0/SaaVEA504R9PjxdCACsSsOxlN09xI8vZkBPsLA=; b=XtlH1oYsW0rxgwGwrQYq0mvXEpFWJhkwI0gN0TXsON9jHMUPW1jNoOHfd8mqOM8JVj /xwuVYchlgNrgb0WlxMaYZhxVoaSVp2ThM8Sc6PZDextI+CY/IkmjbUWMSOkgZfhUMW0 Dp4mbRz72Kj9sJHZeLJlTXyPqMAP+Ux0qPdPS0KEB7WwtHIkzEaU4wmx/bp+/yRBeb4X MH9Z2eawOC1f4fh1lC5EI/KWuqEpZqYDVtnk7LYPPCg6bB6ZCVkXRXYZFS3gFf3Fkxln 002zJt+7cvN3cNNzLZxSxIH5l40SErNodwEdCe4w54wreSctiee+pz6nYzDMAhulL6oj dp8w== Received: by 10.50.197.194 with SMTP id iw2mr1136762igc.64.1354698809715; Wed, 05 Dec 2012 01:13:29 -0800 (PST) MIME-Version: 1.0 Received: by 10.64.35.138 with HTTP; Wed, 5 Dec 2012 01:13:09 -0800 (PST) From: Krishna Chaitanya Date: Wed, 5 Dec 2012 14:43:09 +0530 Message-ID: Subject: [PATCH] mac80211: fixing the warning storm for budding chipsets without ampdu_action defined To: Johannes Berg Cc: linux-wireless Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Warn once should suffice. Eg: our driver doesn't support the ampdu_action yet, so seeing a lot of warnings, hence the check for any new drivers to avoid messing the kernel log. Signed-off-by: Chaitanya T K --- net/mac80211/agg-tx.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) if ((tid >= IEEE80211_NUM_TIDS) || -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/mac80211/agg-tx.c b/net/mac80211/agg-tx.c index 4152ed1..eb9df22 100644 --- a/net/mac80211/agg-tx.c +++ b/net/mac80211/agg-tx.c @@ -445,7 +445,7 @@ int ieee80211_start_tx_ba_session(struct ieee80211_sta *pubsta, u16 tid, trace_api_start_tx_ba_session(pubsta, tid); - if (WARN_ON(!local->ops->ampdu_action)) + if (WARN_ON_ONCE(!local->ops->ampdu_action)) return -EINVAL;