From patchwork Tue Jan 20 15:22:59 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 5669841 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id F1E0FC058D for ; Tue, 20 Jan 2015 15:23:23 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1174E20458 for ; Tue, 20 Jan 2015 15:23:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 42A8A2044B for ; Tue, 20 Jan 2015 15:23:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752322AbbATPXD (ORCPT ); Tue, 20 Jan 2015 10:23:03 -0500 Received: from mail-lb0-f174.google.com ([209.85.217.174]:39991 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751592AbbATPXB (ORCPT ); Tue, 20 Jan 2015 10:23:01 -0500 Received: by mail-lb0-f174.google.com with SMTP id 10so34030836lbg.5; Tue, 20 Jan 2015 07:23:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=pSC7UVMFKR5Yw+iErEMs7rhptgap5BkltePVXmvD3MQ=; b=aOvLl6doBiQij7eTIlmaroTsB5D9T8C0WHpqySCxCsWyMIqHrSRzkaQ1Kiulky7GSQ LzUeXGdKJFjWYRsku313vBU/LeahX0svZVPlofgXZZf3SrX1v2Qk+Rg2X/432jUwggeg WDF+VvNGFMZywX1ILTSnsXWKUzUtw23MGPKN6fVytw1njwqjyldCbrgvYt93RrFwFx7Q 4dyvK3dpd7RMd0mfQtgWl9U9isZ/b7FAn8ErqiY8WzFxcWl/QogtYpXZj7mTBiFXwTQb BCnW7YM0vRrFz3wncwXNiHMmCsgP7j4nfQ1zxbCAr9A9bWZZyavd5xkvhCyY6pXTAo47 6qyQ== MIME-Version: 1.0 X-Received: by 10.112.38.4 with SMTP id c4mr39204879lbk.46.1421767380062; Tue, 20 Jan 2015 07:23:00 -0800 (PST) Received: by 10.152.179.137 with HTTP; Tue, 20 Jan 2015 07:22:59 -0800 (PST) In-Reply-To: <20141209102904.GJ11285@n2100.arm.linux.org.uk> References: <5481794E.4050406@broadcom.com> <2863746.4sUSEYqahB@wuerfel> <20141208160316.GM16185@e104818-lin.cambridge.arm.com> <5485D97D.1040404@broadcom.com> <5486CCBC.3@broadcom.com> <20141209102904.GJ11285@n2100.arm.linux.org.uk> Date: Tue, 20 Jan 2015 13:22:59 -0200 Message-ID: Subject: Re: using DMA-API on ARM From: Fabio Estevam To: Russell King - ARM Linux Cc: Arend van Spriel , brcm80211-dev-list , Arnd Bergmann , Catalin Marinas , linux-wireless , "linux-kernel@vger.kernel.org" , Will Deacon , Hante Meuleman , "hauke@hauke-m.de" , David Miller , "linux-arm-kernel@lists.infradead.org" , Marek Szyprowski Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Russell, On Tue, Dec 9, 2014 at 8:29 AM, Russell King - ARM Linux wrote: > On Tue, Dec 09, 2014 at 11:19:40AM +0100, Arend van Spriel wrote: >> The issue did not trigger overnight so it seems setting bit 22 > Attribute _Override_ Enable> solves the issue over here. Now the question is >> how to move forward with this. As I understood from Catalin this patch was >> not included as it was not considered responsibility of the linux kernel. > > It is preferable for firmware to configure the L2 cache appropriately, > which includes things like the prefetch offsets as well as feature bits > like bit 22. > > I think what I'll do is queue up a patch which adds a warning if bit 22 > is not set, suggesting that firmware is updated to set this bit. Do you mean something like this? } --- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/arch/arm/mm/cache-l2x0.c +++ b/arch/arm/mm/cache-l2x0.c @@ -943,6 +943,10 @@ static int __init __l2c_init(const struct l2c_init_data *data, pr_info("%s: CACHE_ID 0x%08x, AUX_CTRL 0x%08x\n", data->type, cache_id, aux); + if (!(aux & L2C_AUX_CTRL_SHARED_OVERRIDE)) + pr_warn("%s: L2C_AUX_CTRL_SHARED_OVERRIDE needs to be set by the bootloader\n", + data->type); + return 0;