diff mbox

ACS ACR122U not working: pn533_usb 1-1:1.0: NFC: fix memdup.cocci warnings

Message ID alpine.DEB.2.20.1805180811210.2323@hadrien (mailing list archive)
State Deferred
Delegated to: Samuel Ortiz
Headers show

Commit Message

Julia Lawall May 18, 2018, 6:13 a.m. UTC 
From: kbuild test robot <fengguang.wu@intel.com>

 Use kmemdup rather than duplicating its implementation

Generated by: scripts/coccinelle/api/memdup.cocci

Fixes: fe1c559e1567 ("ACS ACR122U not working: pn533_usb 1-1:1.0: NFC: Couldn't poweron...")
CC: Greg KH <gregkh@linuxfoundation.org>
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>

---

url:
https://github.com/0day-ci/linux/commits/Greg-KH/NFC-pn533-don-t-send-USB-data-off-of-the-stack/20180518-100416
:::::: branch date: 54 minutes ago
:::::: commit date: 54 minutes ago

 usb.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff mbox

Patch

--- a/drivers/nfc/pn533/usb.c
+++ b/drivers/nfc/pn533/usb.c
@@ -153,10 +153,9 @@  static int pn533_usb_send_ack(struct pn5
 	char *buffer;
 	int rc;

-	buffer = kmalloc(sizeof(ack), GFP_KERNEL);
+	buffer = kmemdup(ack, sizeof(ack), GFP_KERNEL);
 	if (!buffer)
 		return -ENOMEM;
-	memcpy(buffer, ack, sizeof(ack));

 	phy->out_urb->transfer_buffer = (u8 *)ack;
 	phy->out_urb->transfer_buffer_length = sizeof(ack);
@@ -390,10 +389,9 @@  static int pn533_acr122_poweron_rdr(stru

 	dev_dbg(&phy->udev->dev, "%s\n", __func__);

-	buffer = kmalloc(sizeof(cmd), GFP_KERNEL);
+	buffer = kmemdup(cmd, sizeof(cmd), GFP_KERNEL);
 	if (!buffer)
 		return -ENOMEM;
-	memcpy(buffer, cmd, sizeof(cmd));

 	init_completion(&arg.done);
 	cntx = phy->in_urb->context;  /* backup context */