diff mbox series

ath11k: fix bugon.cocci warnings

Message ID alpine.DEB.2.21.1903072247110.2558@hadrien (mailing list archive)
State Not Applicable
Delegated to: Kalle Valo
Headers show
Series ath11k: fix bugon.cocci warnings | expand

Commit Message

Julia Lawall March 7, 2019, 9:48 p.m. UTC 
From: kbuild test robot <lkp@intel.com>

Use BUG_ON instead of if condition followed by BUG.

Generated by: scripts/coccinelle/misc/bugon.cocci

Fixes: c105b7abf400 ("ath11k: collect DDR dump after fw crash")
CC: Venkateswara Naralasetty <vnaralas@codeaurora.org>
Signed-off-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath11k-bringup
head:   e7daa3ec639f390e383dae0db9e6b143bcc7b5bc
commit: c105b7abf400972ee661efe18b4ca11adfd137cd [28/42] ath11k: collect DDR dump after fw crash
:::::: branch date: 5 hours ago
:::::: commit date: 5 hours ago

Please take the patch only if it's a positive warning. Thanks!

 ahb.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Kalle Valo March 8, 2019, 12:49 p.m. UTC | #1 
Julia Lawall <julia.lawall@lip6.fr> writes:

> From: kbuild test robot <lkp@intel.com>
>
> Use BUG_ON instead of if condition followed by BUG.
>
> Generated by: scripts/coccinelle/misc/bugon.cocci
>
> Fixes: c105b7abf400 ("ath11k: collect DDR dump after fw crash")
> CC: Venkateswara Naralasetty <vnaralas@codeaurora.org>
> Signed-off-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>

Applied, thanks.
diff mbox series

Patch

--- a/drivers/net/wireless/ath/ath11k/ahb.c
+++ b/drivers/net/wireless/ath/ath11k/ahb.c
@@ -954,8 +954,7 @@  static int ath11k_subsys_notifier_cb(str
 		sc->target_restarted = 0;
 		break;
 	case SUBSYS_BEFORE_POWERUP:
-		if (sc->target_restarted)
-			BUG();
+		BUG_ON(sc->target_restarted);
 		break;
 	default:
 		return NOTIFY_OK;