From patchwork Fri Mar 18 02:25:33 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julian Calaby X-Patchwork-Id: 8615851 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 4B9D4C0553 for ; Fri, 18 Mar 2016 02:25:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6C15920306 for ; Fri, 18 Mar 2016 02:25:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 90F8B202FE for ; Fri, 18 Mar 2016 02:25:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752647AbcCRCZl (ORCPT ); Thu, 17 Mar 2016 22:25:41 -0400 Received: from mail-pf0-f174.google.com ([209.85.192.174]:33445 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751361AbcCRCZj (ORCPT ); Thu, 17 Mar 2016 22:25:39 -0400 Received: by mail-pf0-f174.google.com with SMTP id 4so15145407pfd.0 for ; Thu, 17 Mar 2016 19:25:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=/lQovcCa4Yh7n7hQM+01A6Vi//q8r2hJX33EEo1LXpc=; b=x/aaFCCNbCKaep7cpKm9o0tJRGx9Q8gqdEE5Rub5ZpYGMkxPC/G9f6VD6xvsgkXaA/ Z2sZj1hbxEYfY1nXmJRYHVTMDUl28d/JpqcE43/YnbagbuQGk6rN9BAV9JggiOSiJftG VrM9xaZ0JY1hohEfUn0P4xiuSYnsJWeDcXcONhob9PGrfaa3y4XJcga9iJSEQRFG5Y+N k8w6R91lsBtogHiJwgRF+lbeSn1XQqNUkA1uA7Z28A87pGZ6IPUZMVoW/xpvmMiQRImO jBNVYOQ/14GWmRv6UjWBQNGuKO+GIrNutoyTiJeGExSR0rPNpyqvG/pYnBv84CQdJntR WqIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=/lQovcCa4Yh7n7hQM+01A6Vi//q8r2hJX33EEo1LXpc=; b=PBsjE9mSk5NC33TKImjvZmi5nQg+0pLXqEv1p5Lbc1KNU0GmOd9wEhnge2zc+ZZa0s cBdaKK0oKtLq6UbEiW/vWcBlCbDr3knVKRyMTcVsSpetiFpnVVmLY3e8zLuXbIcb4kR5 aOA6vbPvBgXHUCQoFA3xjCUlWS08kpZhvWPp/+Ic+s4cWCsjVXZpjIGIAxnoL38mS66l nR6P6pijWmlSVUlGbatppmviVaO4QDKZP986f4cY6ixxEYh1+r3MXV51/C7tPFL3M+i7 QidiC+HtDETgwdp7/vTQk3ntjTfS/QhtwHtNcMKveX4DpUahFqZnyqNjKOz8sV1MbzEN rOyw== X-Gm-Message-State: AD7BkJJuLBLw0qSjMLgKsrO2/hYcTFojM8INR7lCIkSOL5ybiR9NNHAEYrdqRiN3j5SWiw== X-Received: by 10.66.157.161 with SMTP id wn1mr19947630pab.146.1458267938886; Thu, 17 Mar 2016 19:25:38 -0700 (PDT) Received: from multimedia.lan (C-59-101-14-180.hay.connect.net.au. [59.101.14.180]) by smtp.gmail.com with ESMTPSA id n19sm16380237pfi.53.2016.03.17.19.25.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 17 Mar 2016 19:25:38 -0700 (PDT) From: Julian Calaby To: Kalle Valo Cc: Markus Elfring , linux-wireless@vger.kernel.org Subject: [PATCH DETAIL 13/19] rsi: Delete unnecessary variable initialisation Date: Fri, 18 Mar 2016 13:25:33 +1100 Message-Id: X-Mailer: git-send-email 2.7.0 In-Reply-To: References: Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring In rsi_send_data_pkt(), the following variables are assigned to before they're used: * tmp_hdr - Assigned on line 47, first used on line 48 * bss - Assigned on line 41, first used on line 44 * extnd_size - Assigned on line 50, first used on line 52 * seq_num - Assigned on line 48, first used on line 96 Signed-off-by: Markus Elfring [Rewrote commit message] Signed-off-by: Julian Calaby --- drivers/net/wireless/rsi/rsi_91x_pkt.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/rsi/rsi_91x_pkt.c b/drivers/net/wireless/rsi/rsi_91x_pkt.c index 571eaba..4322df1 100644 --- a/drivers/net/wireless/rsi/rsi_91x_pkt.c +++ b/drivers/net/wireless/rsi/rsi_91x_pkt.c @@ -27,15 +27,15 @@ int rsi_send_data_pkt(struct rsi_common *common, struct sk_buff *skb) { struct rsi_hw *adapter = common->priv; - struct ieee80211_hdr *tmp_hdr = NULL; + struct ieee80211_hdr *tmp_hdr; struct ieee80211_tx_info *info; struct skb_info *tx_params; - struct ieee80211_bss_conf *bss = NULL; + struct ieee80211_bss_conf *bss; int status = -EINVAL; u8 ieee80211_size = MIN_802_11_HDR_LEN; - u8 extnd_size = 0; + u8 extnd_size; __le16 *frame_desc; - u16 seq_num = 0; + u16 seq_num; info = IEEE80211_SKB_CB(skb); bss = &info->control.vif->bss_conf;