| Message ID | cc2633a981be777e631da2bd3d32781690db910f.1515503003.git.lorenzo.bianconi@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8c9f6491a313b5b83f6f395b5cd195f261124fe5 |
| Delegated to: | Kalle Valo |
| Headers | show |
Lorenzo Bianconi <lorenzo.bianconi@redhat.com> wrote: > Substitute tasklet_kill with tasklet_disable/tasklet_enable in order to > guarantee dfs tasklet can not be executed during dfs parameter > initialization > > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com> 3 patches applied to wireless-drivers-next.git, thanks. 8c9f6491a313 mt76x2: dfs: avoid tasklet scheduling during mt76x2_dfs_init_params() 2070f3cc2c2c mt76x2: dfs: add set_domain handler 634e99f0d4da mt76x2: dfs: take into account dfs region in mt76x2_dfs_init_params()
diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2_dfs.c b/drivers/net/wireless/mediatek/mt76/mt76x2_dfs.c index 5b452a596016..1a6282a8b64b 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76x2_dfs.c +++ b/drivers/net/wireless/mediatek/mt76/mt76x2_dfs.c @@ -460,7 +460,6 @@ void mt76x2_dfs_init_params(struct mt76x2_dev *dev) { struct cfg80211_chan_def *chandef = &dev->mt76.chandef; - tasklet_kill(&dev->dfs_pd.dfs_tasklet); if (chandef->chan->flags & IEEE80211_CHAN_RADAR) { mt76x2_dfs_set_bbp_params(dev); /* enable debug mode */ diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2_main.c b/drivers/net/wireless/mediatek/mt76/mt76x2_main.c index 963aea9e8801..c96e9348d3a9 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76x2_main.c +++ b/drivers/net/wireless/mediatek/mt76/mt76x2_main.c @@ -127,6 +127,7 @@ mt76x2_set_channel(struct mt76x2_dev *dev, struct cfg80211_chan_def *chandef) mt76_set_channel(&dev->mt76); tasklet_disable(&dev->pre_tbtt_tasklet); + tasklet_disable(&dev->dfs_pd.dfs_tasklet); cancel_delayed_work_sync(&dev->cal_work); mt76x2_mac_stop(dev, true); @@ -139,6 +140,7 @@ mt76x2_set_channel(struct mt76x2_dev *dev, struct cfg80211_chan_def *chandef) mt76x2_dfs_init_params(dev); mt76x2_mac_resume(dev); + tasklet_enable(&dev->dfs_pd.dfs_tasklet); tasklet_enable(&dev->pre_tbtt_tasklet); return ret;
Substitute tasklet_kill with tasklet_disable/tasklet_enable in order to guarantee dfs tasklet can not be executed during dfs parameter initialization Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com> --- drivers/net/wireless/mediatek/mt76/mt76x2_dfs.c | 1 - drivers/net/wireless/mediatek/mt76/mt76x2_main.c | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-)