From patchwork Sun Oct 29 20:12:41 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 10031643 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 86BC6600C5 for ; Sun, 29 Oct 2017 20:13:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7AF5328754 for ; Sun, 29 Oct 2017 20:13:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6FA2828756; Sun, 29 Oct 2017 20:13:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 291B928754 for ; Sun, 29 Oct 2017 20:13:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751907AbdJ2UM7 (ORCPT ); Sun, 29 Oct 2017 16:12:59 -0400 Received: from mout.web.de ([212.227.15.4]:53527 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751378AbdJ2UM5 (ORCPT ); Sun, 29 Oct 2017 16:12:57 -0400 Received: from [192.168.1.2] ([78.49.32.239]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MUnqm-1dfE070x2K-00YCmV; Sun, 29 Oct 2017 21:12:43 +0100 Subject: [PATCH 2/5] wlcore: Delete an unnecessary check statement in wlcore_set_beacon_template() From: SF Markus Elfring To: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Arend Van Spriel , Eyal Reizer , Iain Hunter , James Minor , Johannes Berg , Kalle Valo , Maxim Altshul , Pieter-Paul Giesberts Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: Date: Sun, 29 Oct 2017 21:12:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-Provags-ID: V03:K0:k2Rlnbcd5ie2+9wn/ePNGZcnsKtq99B5U4IPJCmEHF+LdpyxSOC 9axyphOin2nl8Zq21wdXgZ1MRyBioDPodEa8jz5fKDVZ/LgGCKu9fFU5C9Ulgk8rTaIgd1s VVWBTuld7XII5odHmt4Tt9XJoCxqhfi2huWwnv29NijkygJpEJsWsBKUtK2nqSOTeEjXJGM D6JEMco0MwVEdexgxOcGA== X-UI-Out-Filterresults: notjunk:1; V01:K0:GVSea4tw0rg=:ka72cFHlLqXYefMvNZsT4f /r5S344IR4fk6yvp+BvSCRdzwA6rOcd5Tl2GKnMgFcq0D+nMWMYoQUbmwK2f7glVmT/2rslU4 5dh9YDR+sDpyOO1w+aMK5mJxgr1nsQUCyS2ed76UWspH5uO55Vla/MI0PVRNbXzPOuBriLCTk jYQJV/PbEQBOMCeOndct6Wn8Y98tqGGxqQJMKHko+L+wta6Lwqi/TOsvg4xz75taCmwMIQC/Z h1CjqborT4cU0fzHd0oI7ci591xEWk7Szqs9xBahU3dR0PFDwqPzE4YrcvOc4V7vKAzsxBleJ 82pkIhsAbB4b1mcFpN+H6mPWUyt9wzTqAhzFsaVSCjbtduNK4emUZTNmsCmWbtWA3S2ezJRU4 rwmK9QubI6FsliOdlGZeD7+cgxxSlusteYHwm4DeqrnPWJUrZWmM3QiSNLCEv8yht45mZ256c KtOt86r6IldCNuDSa/HvmWj14wmXRs1ec2CrEAlbalF5+SX3d+eHMIt3H6nlLoD9ruYy5iVUp M9f4oXkrszn/u1AqDn66fPpPXv27FIipCJKj8NDXZK3iTa20aEC4dknQYVs6REc8QWH3CBuWJ JRTt78HO1QevYMDkt6CRf9wMEk2XWVZnq8vxLy/BPSeLDbaU6E0b6tKnsKD9ww3iNGVVfCGKs im8pib7NJrtrGNUccXHytn9Zd0FX0RE912MY6tfni4F3gwQfUE7qnHBvGntxUNYZmgb5QXN0i cOt/Rd3h5CX5rgV/5lcABH+JnZ3W0Sw20m3UwIEohBs24rIEgO7WTM3/1cTMqTfPo2AIjLMlt QN42jnBCOK9eHPfZNEAna79LQWQke026Ql/+MAqNF/+aVBVB4U= Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Sun, 29 Oct 2017 19:45:07 +0100 A goto statement jumped to a target which followed a condition check immediately without the specification of useful actions between. Thus remove such unnecessary source code at the end of this function. Signed-off-by: Markus Elfring Reviewed-by: Julian Calaby --- drivers/net/wireless/ti/wlcore/main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c index 48380d48ef09..efea811c1c83 100644 --- a/drivers/net/wireless/ti/wlcore/main.c +++ b/drivers/net/wireless/ti/wlcore/main.c @@ -4085,9 +4085,6 @@ static int wlcore_set_beacon_template(struct wl1271 *wl, min_rate); end_bcn: dev_kfree_skb(beacon); - if (ret < 0) - goto out; - out: return ret; }