From patchwork Thu Apr 17 13:27:09 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gang ZHAO X-Patchwork-Id: 4008221 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 323539F336 for ; Thu, 17 Apr 2014 13:27:48 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2EE33201B9 for ; Thu, 17 Apr 2014 13:27:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 495552018E for ; Thu, 17 Apr 2014 13:27:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755177AbaDQN1o (ORCPT ); Thu, 17 Apr 2014 09:27:44 -0400 Received: from mail-pb0-f53.google.com ([209.85.160.53]:61355 "EHLO mail-pb0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751516AbaDQN1n (ORCPT ); Thu, 17 Apr 2014 09:27:43 -0400 Received: by mail-pb0-f53.google.com with SMTP id rp16so375923pbb.40 for ; Thu, 17 Apr 2014 06:27:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=IPvr4+uLr5nODrJI1WvsCwwG+SajllcEsiLzEFD8RX8=; b=WdSXbHGf2qnTvOvsnzAjadOX42FYO+VJZaWnl/gmY6oTQZIVTtIQOmOJ9/9Ga9AHtK d8NPKOiIxHxANngI8szNZMO4r14/RPkiFnUDOUlHevPX9qUmCsns6vpgzEynZUHXAvXO vEXEB/ljqSXLPuLkaUYWZfuJ+Q+IQfz4hf0KQdYSCaLM+vpphYDafBvcXGgOqsuwWtTa y935JAKTcSbD9UK6HSD9xqF3uLycbIo+RCjQpfX3lgTy2N55KjuCb2aNBOQIG1T4NWDM /JlU1NKuyEyU8WMrFSf0v6SmEAT3ZHitk1SQNoGhVvkLy0KcBqUsT2X1Gy9ZgtKP+dtO Q7Vw== X-Received: by 10.66.148.98 with SMTP id tr2mr15612741pab.33.1397741262848; Thu, 17 Apr 2014 06:27:42 -0700 (PDT) Received: from localhost.localdomain ([175.153.40.25]) by mx.google.com with ESMTPSA id ir10sm53596895pbc.59.2014.04.17.06.27.38 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Apr 2014 06:27:41 -0700 (PDT) From: "Zhao, Gang" To: Cc: "John W. Linville" , Christian Lamparter Subject: [PATCH 1/6] p54: replace wiphy_debug() with wiphy_dbg() Date: Thu, 17 Apr 2014 21:27:09 +0800 Message-Id: X-Mailer: git-send-email 1.9.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Dynamic debug function wiphy_dbg() is more convenient for debugging, and if user doesn't enable CONFIG_DYNAMIC_DEBUG, it will fall back to normal static debug, just as what wiphy_debug() does. When all the users of wiphy_debug() are gone, wiphy_debug() can be removed. Cc: Christian Lamparter Signed-off-by: Zhao, Gang --- drivers/net/wireless/p54/txrx.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/net/wireless/p54/txrx.c b/drivers/net/wireless/p54/txrx.c index 153c615..2212e99 100644 --- a/drivers/net/wireless/p54/txrx.c +++ b/drivers/net/wireless/p54/txrx.c @@ -39,8 +39,8 @@ static void p54_dump_tx_queue(struct p54_common *priv) u32 largest_hole = 0, free; spin_lock_irqsave(&priv->tx_queue.lock, flags); - wiphy_debug(priv->hw->wiphy, "/ --- tx queue dump (%d entries) ---\n", - skb_queue_len(&priv->tx_queue)); + wiphy_dbg(priv->hw->wiphy, "/ --- tx queue dump (%d entries) ---\n", + skb_queue_len(&priv->tx_queue)); prev_addr = priv->rx_start; skb_queue_walk(&priv->tx_queue, skb) { @@ -49,23 +49,23 @@ static void p54_dump_tx_queue(struct p54_common *priv) hdr = (void *) skb->data; free = range->start_addr - prev_addr; - wiphy_debug(priv->hw->wiphy, - "| [%02d] => [skb:%p skb_len:0x%04x " - "hdr:{flags:%02x len:%04x req_id:%04x type:%02x} " - "mem:{start:%04x end:%04x, free:%d}]\n", - i++, skb, skb->len, - le16_to_cpu(hdr->flags), le16_to_cpu(hdr->len), - le32_to_cpu(hdr->req_id), le16_to_cpu(hdr->type), - range->start_addr, range->end_addr, free); + wiphy_dbg(priv->hw->wiphy, + "| [%02d] => [skb:%p skb_len:0x%04x " + "hdr:{flags:%02x len:%04x req_id:%04x type:%02x} " + "mem:{start:%04x end:%04x, free:%d}]\n", + i++, skb, skb->len, + le16_to_cpu(hdr->flags), le16_to_cpu(hdr->len), + le32_to_cpu(hdr->req_id), le16_to_cpu(hdr->type), + range->start_addr, range->end_addr, free); prev_addr = range->end_addr; largest_hole = max(largest_hole, free); } free = priv->rx_end - prev_addr; largest_hole = max(largest_hole, free); - wiphy_debug(priv->hw->wiphy, - "\\ --- [free: %d], largest free block: %d ---\n", - free, largest_hole); + wiphy_dbg(priv->hw->wiphy, + "\\ --- [free: %d], largest free block: %d ---\n", + free, largest_hole); spin_unlock_irqrestore(&priv->tx_queue.lock, flags); } #endif /* P54_MM_DEBUG */ @@ -657,9 +657,9 @@ static int p54_rx_control(struct p54_common *priv, struct sk_buff *skb) p54_rx_eeprom_readback(priv, skb); break; default: - wiphy_debug(priv->hw->wiphy, - "not handling 0x%02x type control frame\n", - le16_to_cpu(hdr->type)); + wiphy_dbg(priv->hw->wiphy, + "not handling 0x%02x type control frame\n", + le16_to_cpu(hdr->type)); break; } return 0;