From patchwork Wed May 17 20:33:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 9731877 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 89F6D601BC for ; Wed, 17 May 2017 20:33:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 54C79287BD for ; Wed, 17 May 2017 20:33:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 494EE287E0; Wed, 17 May 2017 20:33:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E7E42287BD for ; Wed, 17 May 2017 20:33:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752053AbdEQUd2 (ORCPT ); Wed, 17 May 2017 16:33:28 -0400 Received: from mout.web.de ([212.227.15.3]:52446 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750944AbdEQUd0 (ORCPT ); Wed, 17 May 2017 16:33:26 -0400 Received: from [192.168.1.3] ([78.48.117.83]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0M8L3a-1dxwrf1ARe-00vyW2; Wed, 17 May 2017 22:33:17 +0200 To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org, Aditya Shankar , Ganesh Krishna , Greg Kroah-Hartman Cc: LKML , kernel-janitors@vger.kernel.org, Wolfram Sang From: SF Markus Elfring Subject: [PATCH] staging: wilc1000: Delete an error message for a failed memory allocation in Handle_Key() Message-ID: Date: Wed, 17 May 2017 22:33:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 Content-Language: en-US X-Provags-ID: V03:K0:pBELgw55LQfwZRhhR0P4cYBroraJxfrg3eByvvU+49TPlbavFwn 4z98WgiOuZdXs0ebeRD2M9ajA1xwCSYfio7+FHMyyzTRbawsxD0K33XRy+apcEoHGcXKHQA yuI2Qbbrr5SuyUR1F7CgEFOiwsVxVvxFTAXwUEDQS4TpcgUA81hV0GvoF/N+A2jeoOiYyAo HokfSqgZb94JmmByjAfxg== X-UI-Out-Filterresults: notjunk:1; V01:K0:1r+gbHF0l0c=:z8cnmzpZsohSHBDNlMs3Cx 2TSPykxzb2QeNNldwd8v6wYRbX2CFulqc4303Hz6ItlJ43xYNNhxoZu7kuK6a9s+X3YcDtljQ m8Ay8V3fvAxyndi97V8qDS484K0LmyFN1ccWccEYdY7wFjqUYr9dFrrmKX7dhhEouJG1Y1WGp xHOnr93IGXmmfph6USWNFQsQakjjCt7CnSwtaVBBU1fe+zrMp6mFSKnIkO+30QjSwTw0c6IQN 1m8Rb+l9Mosswg0AsAde4kfGAa6AhxBrhcYWEL7mPBRYETwBD9FeVbFsiUbFZTbwm3sGZnCR+ ASEvdOcI524cnsj2VJSrpHdocjfkw3AaDdshPcv+LkBwU9/ok27Fp/T5uXJ8zTDgpIpSHsKK7 oigzD4jpdjuEh+SODjTkYNnf4BmDWy4UOJ8fahHl4LC9bZjXIGaDeJkrWi10qR+gBKy0TheIH zHJbxnprIkYrxjJtS6AJz9HEkFe+JgQ9StinYOMwDFD77dt9v7jnZFNzepePcpt1Dj+i+2a6e Vc8TYyAqd/eAPoHJT5nyzD+xjMxC3eWUsl96YCkciDxuBKW0Hdkct2tdKkARngCU0L7ON4KSw Ex0OjXTh2dXG57maLo8OitqMhyYNSQL0/MxF6wGHGCZcJFId1fKGyfeHRAXveKJgF3pepVt68 hnIjca3hmT2WNnUZuZ3hS+LSfo7nPpPGxr94dy8JKn7LviiVR//eaUuP0za8ukJ3edukkJpSO zhPbE6n2/mOMG8f6HOAV5/uBvJ/c7RzcipSVBVlTm15DZcWIRR7z3umK6DyF0Zv2jww9tcygP +KVks0v Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Wed, 17 May 2017 22:26:07 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/staging/wilc1000/host_interface.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index c3a8af081880..17a31bbd3665 100644 --- a/drivers/staging/wilc1000/host_interface.c +++ b/drivers/staging/wilc1000/host_interface.c @@ -1688,7 +1688,6 @@ static int Handle_Key(struct wilc_vif *vif, } else if (pstrHostIFkeyAttr->action & ADDKEY) { pu8keybuf = kmalloc(PTK_KEY_MSG_LEN, GFP_KERNEL); if (!pu8keybuf) { - netdev_err(vif->ndev, "No buffer send PTK\n"); ret = -ENOMEM; goto _WPAPtk_end_case_; }