From patchwork Fri Nov 10 00:32:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Greear X-Patchwork-Id: 10052175 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 226966035D for ; Fri, 10 Nov 2017 00:32:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 14BE72B21F for ; Fri, 10 Nov 2017 00:32:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 095E22B221; Fri, 10 Nov 2017 00:32:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 677BC2B21F for ; Fri, 10 Nov 2017 00:32:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755317AbdKJAcF (ORCPT ); Thu, 9 Nov 2017 19:32:05 -0500 Received: from mail2.candelatech.com ([208.74.158.173]:47266 "EHLO mail2.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755308AbdKJAcF (ORCPT ); Thu, 9 Nov 2017 19:32:05 -0500 Received: from [192.168.100.149] (firewall.candelatech.com [50.251.239.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail2.candelatech.com (Postfix) with ESMTPSA id AD8A940A539; Thu, 9 Nov 2017 16:32:02 -0800 (PST) To: "linux-wireless@vger.kernel.org" , erik.stromdahl@gmail.com, ath10k From: Ben Greear Subject: ath10k targaddrs issue Organization: Candela Technologies Message-ID: Date: Thu, 9 Nov 2017 16:32:02 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP While poking around in the firmware, I noticed what appears to be an ath10k driver issue, which came in with this commit below. commit 01d6fd6965eaf8d4b3aab681d30e77c53a834162 Author: Erik Stromdahl Date: Wed Apr 26 12:17:55 2017 +0300 ath10k: various sdio related definitions Debug masks for SDIO HIF layer. Address definitions for SDIO/mbox based chipsets. Augmented struct host_interest with more members. Signed-off-by: Erik Stromdahl Signed-off-by: Kalle Valo ... Those variables above may be correct for some firmware, but they are not correct for at least some versions of 10.4, which have this instead: ... A_UINT32 hi_fw_swap; /* 0x104 */ /* host side need to support tx/rx data packet swap */ A_UINT32 hi_txrx_dataswap; /* 0x108 */ /* enable allocram statistics gathering (set to an integer, which * is the number of tracking records that allocram will allocate). */ A_UINT32 hi_allocram_track_max; /* 0x108 */ } I guess this may not be an issue as long as zero'd values are sent to the 10.4 nics, but it is confusing at best. Eric, where did you get these values from? Thanks, Ben diff --git a/drivers/net/wireless/ath/ath10k/targaddrs.h b/drivers/net/wireless/ath/ath10k/targaddrs.h index cbac9e42..8bded5d 100644 --- a/drivers/net/wireless/ath/ath10k/targaddrs.h +++ b/drivers/net/wireless/ath/ath10k/targaddrs.h @@ -205,6 +205,24 @@ struct host_interest { */ /* Bit 1 - unused */ u32 hi_fw_swap; /* 0x104 */ + + /* global arenas pointer address, used by host driver debug */ + u32 hi_dynamic_mem_arenas_addr; /* 0x108 */ + + /* allocated bytes of DRAM use by allocated */ + u32 hi_dynamic_mem_allocated; /* 0x10C */ + + /* remaining bytes of DRAM */ + u32 hi_dynamic_mem_remaining; /* 0x110 */ + + /* memory track count, configured by host */ + u32 hi_dynamic_mem_track_max; /* 0x114 */ + + /* minidump buffer */ + u32 hi_minidump; /* 0x118 */ + + /* bdata's sig and key addr */ + u32 hi_bd_sig_key; /* 0x11c */ } __packed;