| Message ID | dfda6343781ae3d50cd2ec7bbdcf76a489b6922a.1722839425.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Johannes Berg |
| Headers | show |
| Series | Constify struct lib80211_crypto_ops | expand |
On Mon, Aug 05, 2024 at 08:40:39AM +0200, Christophe JAILLET wrote: > Now that functions in lib80211 handle "const struct lib80211_crypto_ops", > some structure can be constified as well. > > Constifying these structures moves some data to a read-only section, so > increase overall security. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Reviewed-by: Simon Horman <horms@kernel.org>
On 8/5/24 08:40, Christophe JAILLET wrote: > Now that functions in lib80211 handle "const struct lib80211_crypto_ops", > some structure can be constified as well. > > Constifying these structures moves some data to a read-only section, so > increase overall security. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > Compile tested only. > > Changes in v2: > - No changes > > v1: https://lore.kernel.org/all/81be9eb42a2339eaa7466578773945a48904d3b5.1715443223.git.christophe.jaillet@wanadoo.fr/ > --- > drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 2 +- > drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 2 +- > drivers/staging/rtl8192e/rtllib_crypt_wep.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c > index 639877069fad..138733cb00e2 100644 > --- a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c > +++ b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c > @@ -378,7 +378,7 @@ static void rtllib_ccmp_print_stats(struct seq_file *m, void *priv) > ccmp->dot11rsna_stats_ccmp_decrypt_errors); > } > > -static struct lib80211_crypto_ops rtllib_crypt_ccmp = { > +static const struct lib80211_crypto_ops rtllib_crypt_ccmp = { > .name = "R-CCMP", > .init = rtllib_ccmp_init, > .deinit = rtllib_ccmp_deinit, > diff --git a/drivers/staging/rtl8192e/rtllib_crypt_tkip.c b/drivers/staging/rtl8192e/rtllib_crypt_tkip.c > index dc0917b03511..74dc8326c886 100644 > --- a/drivers/staging/rtl8192e/rtllib_crypt_tkip.c > +++ b/drivers/staging/rtl8192e/rtllib_crypt_tkip.c > @@ -678,7 +678,7 @@ static void rtllib_tkip_print_stats(struct seq_file *m, void *priv) > tkip->dot11RSNAStatsTKIPLocalMICFailures); > } > > -static struct lib80211_crypto_ops rtllib_crypt_tkip = { > +static const struct lib80211_crypto_ops rtllib_crypt_tkip = { > .name = "R-TKIP", > .init = rtllib_tkip_init, > .deinit = rtllib_tkip_deinit, > diff --git a/drivers/staging/rtl8192e/rtllib_crypt_wep.c b/drivers/staging/rtl8192e/rtllib_crypt_wep.c > index 10092f6884ff..aa18c060d727 100644 > --- a/drivers/staging/rtl8192e/rtllib_crypt_wep.c > +++ b/drivers/staging/rtl8192e/rtllib_crypt_wep.c > @@ -209,7 +209,7 @@ static void prism2_wep_print_stats(struct seq_file *m, void *priv) > seq_printf(m, "key[%d] alg=WEP len=%d\n", wep->key_idx, wep->key_len); > } > > -static struct lib80211_crypto_ops rtllib_crypt_wep = { > +static const struct lib80211_crypto_ops rtllib_crypt_wep = { > .name = "R-WEP", > .init = prism2_wep_init, > .deinit = prism2_wep_deinit, Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
On Mon, Aug 05, 2024 at 08:40:39AM +0200, Christophe JAILLET wrote: > Now that functions in lib80211 handle "const struct lib80211_crypto_ops", > some structure can be constified as well. > > Constifying these structures moves some data to a read-only section, so > increase overall security. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > Compile tested only. Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c index 639877069fad..138733cb00e2 100644 --- a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c +++ b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c @@ -378,7 +378,7 @@ static void rtllib_ccmp_print_stats(struct seq_file *m, void *priv) ccmp->dot11rsna_stats_ccmp_decrypt_errors); } -static struct lib80211_crypto_ops rtllib_crypt_ccmp = { +static const struct lib80211_crypto_ops rtllib_crypt_ccmp = { .name = "R-CCMP", .init = rtllib_ccmp_init, .deinit = rtllib_ccmp_deinit, diff --git a/drivers/staging/rtl8192e/rtllib_crypt_tkip.c b/drivers/staging/rtl8192e/rtllib_crypt_tkip.c index dc0917b03511..74dc8326c886 100644 --- a/drivers/staging/rtl8192e/rtllib_crypt_tkip.c +++ b/drivers/staging/rtl8192e/rtllib_crypt_tkip.c @@ -678,7 +678,7 @@ static void rtllib_tkip_print_stats(struct seq_file *m, void *priv) tkip->dot11RSNAStatsTKIPLocalMICFailures); } -static struct lib80211_crypto_ops rtllib_crypt_tkip = { +static const struct lib80211_crypto_ops rtllib_crypt_tkip = { .name = "R-TKIP", .init = rtllib_tkip_init, .deinit = rtllib_tkip_deinit, diff --git a/drivers/staging/rtl8192e/rtllib_crypt_wep.c b/drivers/staging/rtl8192e/rtllib_crypt_wep.c index 10092f6884ff..aa18c060d727 100644 --- a/drivers/staging/rtl8192e/rtllib_crypt_wep.c +++ b/drivers/staging/rtl8192e/rtllib_crypt_wep.c @@ -209,7 +209,7 @@ static void prism2_wep_print_stats(struct seq_file *m, void *priv) seq_printf(m, "key[%d] alg=WEP len=%d\n", wep->key_idx, wep->key_len); } -static struct lib80211_crypto_ops rtllib_crypt_wep = { +static const struct lib80211_crypto_ops rtllib_crypt_wep = { .name = "R-WEP", .init = prism2_wep_init, .deinit = prism2_wep_deinit,
Now that functions in lib80211 handle "const struct lib80211_crypto_ops", some structure can be constified as well. Constifying these structures moves some data to a read-only section, so increase overall security. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- Compile tested only. Changes in v2: - No changes v1: https://lore.kernel.org/all/81be9eb42a2339eaa7466578773945a48904d3b5.1715443223.git.christophe.jaillet@wanadoo.fr/ --- drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 2 +- drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 2 +- drivers/staging/rtl8192e/rtllib_crypt_wep.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)