From patchwork Thu Jan 24 07:52:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 10778467 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4D69E1399 for ; Thu, 24 Jan 2019 07:53:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 43D842E339 for ; Thu, 24 Jan 2019 07:53:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 41EBA2E3B4; Thu, 24 Jan 2019 07:53:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E4F7D2E3A0 for ; Thu, 24 Jan 2019 07:53:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726089AbfAXHxP (ORCPT ); Thu, 24 Jan 2019 02:53:15 -0500 Received: from mout.web.de ([212.227.15.14]:36515 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725931AbfAXHxP (ORCPT ); Thu, 24 Jan 2019 02:53:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1548316356; bh=0C21Px0xhO2cGTCG5vcSul9J7C/dR+7Ye8nZmkgibig=; h=X-UI-Sender-Class:From:Subject:To:Cc:Date; b=kTSyNkSC+rEPKzlFE4T/Uzed9AxCHpDD+NkMWqCAZwQVqQ2zgjoncsjxtlJFm4rrr GMx3Fi/GRg8m+KwrMT1oSBYzVk0du0WSs559LBMsrtQc8aAA7Nvpg1+8VW5t9iMuyE mMnXHf1E7V9CmjUvy15anfel6xBnRmwMKl11tpyA= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.10] ([95.157.57.47]) by smtp.web.de (mrweb003 [213.165.67.108]) with ESMTPSA (Nemesis) id 0LqlRS-1hQsNi1o7W-00eP7w; Thu, 24 Jan 2019 08:52:36 +0100 From: Jan Kiszka Subject: [PATCH v2] arm64: dts: hikey: Give wifi some time after power-on To: Linux Kernel Mailing List , linux-arm-kernel , Wei Xu Cc: Ryan Grachek , John Stultz , linux-wireless@vger.kernel.org, "Reizer, Eyal" , Valentin Schneider , Ulf Hansson , Kalle Valo , Tony Lindgren Message-ID: Date: Thu, 24 Jan 2019 08:52:33 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 Content-Language: en-US X-Provags-ID: V03:K1:E2H/xh7CJnHSKb0B4o6Q6pkAHqkZhOJMLpP6LghUaS5BIzd+nzA C6SwVXJ6/++jJlJfe6X2LlzxvVOpKQagdItdmQa+PwI1rP3B3k+K8jZk5CUoTlRgeGDUfHc 8FzqFX7wOMlEHIOJBD7Ye4Qu7mBR7RhCA+9tLlnzjVi1VSA5ZOPYNm0Gcr3wglOuyjppCyk NRFFLVdqRv/JRKfxmX9pw== X-UI-Out-Filterresults: notjunk:1;V03:K0:YICEqmHhATs=:yuiHNaZsJHXLq1GAdWDuvG yQfWKaVaISC0nesuiAO+Yz5uI6ri2KusxFc5psdlHoLWTJ6KQWeAaxcCdPTP1sfnLvO4QMjl4 PopC8DzNWYkphwod42Z97UZJ6PHO1kg4qwia29h4nXdOp2Xc4XB4GJaKBybjeuJNr9okruqcd Ym5X+aFPIcNEb4GeWKGmRjHhXdZNpmFMGcxsH1JT2ivWkg4Y9uX+Kpy+bW5R+qsB0RnmHpcQ6 eXcLdoAfyzMoXchs2yiXS7jxcWtHtSUV4B1GHFa2DvfxaKClqN1rUDL+01Dhp36+vTRefJWBl ZsObgYpo5gESGx9OrT1sqzGBKmCTDYZ18Ko2f9S9UUK4oofUT376OC7ACVWCYI8V0L8BdWvRN xJikMbebW9FPm1nji8RUwnTexpoGv+iGA34BGWaos5kgM/wi5p4S+0aHczrAwdKXNz71/eFJj 9K8VYVRZiOcLBP9tmqM7Nc2HHXstXlGFOCZe5w4znwnsKcj8q1VXhKCKG8e1Ujty5vaKpOx2R b+vzCjHvkw8EHVr7Y7xFg6qzv04MnI1fFm4eDmVv0zKIbfx+Ib2zdU9Q9NNoBilsg3NZULUhZ JMMNMC/GSvFjxwDk49SOXXBELh1M6d7WE0ZwpoBhIqZBLhYbRZchmf6HJW7F5lpyflQePzvz+ A8cnzz+zI7v5fOnLUpqwrhaCi045InIkuz6q/EdTVd5JluuvIwYhjlZDMaHWX1UfG54t0rApf k0zJd/iDN/ntdLdQR+Yln1HwXmCGFyZsKmPxcZvdJhRVuenkKyCCaO4GwtgqwdWsQAxp/mQ6g XvqbKur0Ta47PGjF0eIQ4/StmEbf0sjfNT58oJd1Bqp+mTDnlbgy69aJdwdRLWTHAV4CD8yjp D2lO9D/AlwJ3/acjYvgxKgvJ4OrafO5f1vpE4lxA+QTrxtr24uY4FiaykmdWnBsdy03eWambR f1yFtc+VcBg== Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Jan Kiszka Somewhere along recent changes to power control of the wl1835, power-on became very unreliable on the hikey, failing like this: wl1271_sdio: probe of mmc2:0001:1 failed with error -16 wl1271_sdio: probe of mmc2:0001:2 failed with error -16 After playing with some dt parameters and comparing to other users of this chip, it turned out we need some power-on delay to make things stable again. In contrast to those other users which define 200 ms, the hikey would already be happy with 1 ms. Still, we use the safer 10 ms, like on the Ultra96. Fixes: ea452678734e ("arm64: dts: hikey: Fix WiFi support") Signed-off-by: Jan Kiszka Acked-by: Ulf Hansson --- Changes in v2: - set delay to 10 ms - updated changelog Who will take care of updating also the Hikey firmware dts with this change? arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 + 1 file changed, 1 insertion(+) -- 2.16.4 diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts index 610235028cc7..ba946543dd0a 100644 --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts @@ -118,6 +118,7 @@ reset-gpios = <&gpio0 5 GPIO_ACTIVE_LOW>; clocks = <&pmic>; clock-names = "ext_clock"; + post-power-on-delay-ms = <10>; power-off-delay-us = <10>; };