| Message ID | f30552d1bfdb4c56f99ca79d8fbf52d3fcf71686.1686331623.git.chunkeey@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [v1] dt-bindings: net: wireless: ath10k: add ieee80211-freq-limit property | expand |
On Fri, 09 Jun 2023 19:27:23 +0200, Christian Lamparter wrote: > This is an existing optional property that ieee80211.yaml/cfg80211 > provides. It's useful to further restrict supported frequencies > for a specified device through device-tree. > > The driver supported this since ~2018 by > commit 34d5629d2ca8 ("ath10k: limit available channels via DT ieee80211-freq-limit") > > Signed-off-by: Christian Lamparter <chunkeey@gmail.com> > --- > > Note: this is for ath10k. The other patch is for a different driver (ath11k). > --- > .../devicetree/bindings/net/wireless/qcom,ath10k.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml:171:1: [error] duplication of key "allOf" in mapping (key-duplicates) dtschema/dtc warnings/errors: make[1]: *** Deleting file 'Documentation/devicetree/bindings/net/wireless/qcom,ath10k.example.dts' Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml:171:1: found duplicate key "allOf" with value "[]" (original value: "[]") make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/net/wireless/qcom,ath10k.example.dts] Error 1 make[1]: *** Waiting for unfinished jobs.... ./Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml:171:1: found duplicate key "allOf" with value "[]" (original value: "[]") Traceback (most recent call last): File "/usr/local/bin/dt-doc-validate", line 62, in <module> ret |= check_doc(f) File "/usr/local/bin/dt-doc-validate", line 31, in check_doc for error in sorted(dtschema.DTValidator.iter_schema_errors(testtree), key=lambda e: e.linecol): File "/usr/local/lib/python3.10/dist-packages/dtschema/lib.py", line 736, in iter_schema_errors cls.annotate_error(error, meta_schema, error.schema_path) File "/usr/local/lib/python3.10/dist-packages/dtschema/lib.py", line 712, in annotate_error schema = schema[p] KeyError: 'type' /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml: ignoring, error parsing file make: *** [Makefile:1512: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/f30552d1bfdb4c56f99ca79d8fbf52d3fcf71686.1686331623.git.chunkeey@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml index c85ed330426d..99db442cef92 100644 --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml @@ -12,6 +12,9 @@ maintainers: description: Qualcomm Technologies, Inc. IEEE 802.11ac devices. +allOf: + - $ref: ieee80211.yaml# + properties: compatible: enum: @@ -84,6 +87,8 @@ properties: required: - iommus + ieee80211-freq-limit: true + qcom,ath10k-calibration-data: $ref: /schemas/types.yaml#/definitions/uint8-array description:
This is an existing optional property that ieee80211.yaml/cfg80211 provides. It's useful to further restrict supported frequencies for a specified device through device-tree. The driver supported this since ~2018 by commit 34d5629d2ca8 ("ath10k: limit available channels via DT ieee80211-freq-limit") Signed-off-by: Christian Lamparter <chunkeey@gmail.com> --- Note: this is for ath10k. The other patch is for a different driver (ath11k). --- .../devicetree/bindings/net/wireless/qcom,ath10k.yaml | 5 +++++ 1 file changed, 5 insertions(+)