[v2,2/4] brcmfmac: p2p and normal ap access are not always possible at the same time

Commit Message

Arend van Spriel March 10, 2017, 9:35 a.m. UTC

On 10-3-2017 9:08, Hans de Goede wrote:
> Hi,
> 
> On 08-03-17 12:16, Hans de Goede wrote:
>> Hi,
>>
>> On 08-03-17 11:15, Arend Van Spriel wrote:
>>> On 8-3-2017 10:26, Arend Van Spriel wrote:
>>>> On 8-3-2017 9:24, Hans de Goede wrote:
>>>>> Hi,
>>>>>
>>>>> On 07-03-17 11:03, Arend Van Spriel wrote:
>>>>>>
>>>>>>
>>>>>> On 27-2-2017 22:45, Hans de Goede wrote:
>>>>>>> The firmware responding with -EBUSY when trying to add an extra
>>>>>>> virtual-if
>>>>>>> is a normal thing, do not print an error for this.
>>>>>>
>>>>>> This may be something we need to look into. It seems to me the
>>>>>> interface
>>>>>> combinations needs to be fixed so we do not try to provision
>>>>>> firmware.
>>>>>> Can you explain the scenario here?
>>>>>
>>>>> I'm not doing anything special just connecting to my isp provided
>>>>> accesspoint
>>>>> using NetworkManager.
>>>>
>>>> Ok. So it is probably the P2P_DEVICE interface as that is the only
>>>> interface being created in that scenario. Can you provide a log with
>>>> brcmfmac driver debug=0x1416.
>>>
>>> I guess you are seeing this with 43362. Is that correct?
> 
> Attached is a dmesg log from the brcmfmac driver build with debugging
> enabled and brcmfmac.debug set to 0x1416.

I suspect the P2P_DEVICE interface is assigned the same address as
wlp1s0. Can you apply the change below and create the log again.

Regards,
Arend

        switch (type) {
        case NL80211_IFTYPE_P2P_CLIENT:

Comments

Hans de Goede March 16, 2017, 11:51 a.m. UTC | #1

Hi,

On 10-03-17 10:35, Arend Van Spriel wrote:
> On 10-3-2017 9:08, Hans de Goede wrote:
>> Hi,
>>
>> On 08-03-17 12:16, Hans de Goede wrote:
>>> Hi,
>>>
>>> On 08-03-17 11:15, Arend Van Spriel wrote:
>>>> On 8-3-2017 10:26, Arend Van Spriel wrote:
>>>>> On 8-3-2017 9:24, Hans de Goede wrote:
>>>>>> Hi,
>>>>>>
>>>>>> On 07-03-17 11:03, Arend Van Spriel wrote:
>>>>>>>
>>>>>>>
>>>>>>> On 27-2-2017 22:45, Hans de Goede wrote:
>>>>>>>> The firmware responding with -EBUSY when trying to add an extra
>>>>>>>> virtual-if
>>>>>>>> is a normal thing, do not print an error for this.
>>>>>>>
>>>>>>> This may be something we need to look into. It seems to me the
>>>>>>> interface
>>>>>>> combinations needs to be fixed so we do not try to provision
>>>>>>> firmware.
>>>>>>> Can you explain the scenario here?
>>>>>>
>>>>>> I'm not doing anything special just connecting to my isp provided
>>>>>> accesspoint
>>>>>> using NetworkManager.
>>>>>
>>>>> Ok. So it is probably the P2P_DEVICE interface as that is the only
>>>>> interface being created in that scenario. Can you provide a log with
>>>>> brcmfmac driver debug=0x1416.
>>>>
>>>> I guess you are seeing this with 43362. Is that correct?
>>
>> Attached is a dmesg log from the brcmfmac driver build with debugging
>> enabled and brcmfmac.debug set to 0x1416.
>
> I suspect the P2P_DEVICE interface is assigned the same address as
> wlp1s0. Can you apply the change below and create the log again.
>
> Regards,
> Arend
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
> b/drivers/ne
> index de19c7c..43fa9f45 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
> @@ -2158,7 +2158,8 @@ struct wireless_dev *brcmf_p2p_add_vif(struct
> wiphy *wiphy
>         if (brcmf_cfg80211_vif_event_armed(cfg))
>                 return ERR_PTR(-EBUSY);
>
> -       brcmf_dbg(INFO, "adding vif \"%s\" (type=%d)\n", name, type);
> +       brcmf_dbg(INFO, "adding vif \"%s\" (type=%d, addr=%pM)\n", name,
> type,
> +                 params->macaddr);
>
>         switch (type) {
>         case NL80211_IFTYPE_P2P_CLIENT:
>

Ok, new log attached.

Regards,

Hans

Patch

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
b/drivers/ne
index de19c7c..43fa9f45 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
@@ -2158,7 +2158,8 @@  struct wireless_dev *brcmf_p2p_add_vif(struct
wiphy *wiphy
        if (brcmf_cfg80211_vif_event_armed(cfg))
                return ERR_PTR(-EBUSY);

-       brcmf_dbg(INFO, "adding vif \"%s\" (type=%d)\n", name, type);
+       brcmf_dbg(INFO, "adding vif \"%s\" (type=%d, addr=%pM)\n", name,
type,
+                 params->macaddr);