From patchwork Fri Mar 10 09:35:32 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arend van Spriel X-Patchwork-Id: 9615691 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CD40460414 for ; Fri, 10 Mar 2017 09:48:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B2212286E7 for ; Fri, 10 Mar 2017 09:48:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A57792870D; Fri, 10 Mar 2017 09:48:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 41813286E7 for ; Fri, 10 Mar 2017 09:48:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935686AbdCJJsu (ORCPT ); Fri, 10 Mar 2017 04:48:50 -0500 Received: from mail-qk0-f178.google.com ([209.85.220.178]:35670 "EHLO mail-qk0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964814AbdCJJfr (ORCPT ); Fri, 10 Mar 2017 04:35:47 -0500 Received: by mail-qk0-f178.google.com with SMTP id v125so155851288qkh.2 for ; Fri, 10 Mar 2017 01:35:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=e4r5K1ZaRQ/en1KTZc8LNTaeeyTLbXOevzqBgp/WxdU=; b=X7G8GH5Y5/RIbcabvyN5vqlUGuLe1J6Y1rnTxEbl7eXefDDDpC1mr9ukEp7eZ93CR7 Qki6LfZ6gl08pvU1LyWtB7R6bmOo1BFJIDoohTsUd8Xd1ajuAV2K4cVuBDgEUs19NQ6P 934uOxuNEu/oMWUnCZTPN1dZej5n0YHKVtRDg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=e4r5K1ZaRQ/en1KTZc8LNTaeeyTLbXOevzqBgp/WxdU=; b=t/eFOXs0gU5VBs6My/FFz/iG/4JFQpFa5qdhlDbva8LHQ8Uggnst+qF2sgEYGqPUM3 Tfli2+lL9BTpgNuiMYMj/yUq+EFLtCPZQKcdSR81gJo+zCd/J9ZRgY30vb0fmbtfybLH siuao7gRQmopu9x8i95YAykzEUTo7MfskDYAOSWMhYh0Rp+gO7kiXDOqpXn0A2hpdeNs dyh9Zk7rBJcQYtKQpFkCijgUYtbWkhhDEziVPhgz0vQsbLhPyoQ9Wuap7gXFFGdqrd0T aWHH6wtDydJQoFFO+xRRH3uf+olsgDEYNu/KSGNiEsHesxBa9RRlciokOegsLdJe+rew 730w== X-Gm-Message-State: AMke39nzpQX2ZLyLAsZsIebXNjMFy/lJXKKtQbErdpdcx1N25jfgoYBf5XlggsKPPt17IA1P X-Received: by 10.200.51.84 with SMTP id u20mr19801169qta.133.1489138536295; Fri, 10 Mar 2017 01:35:36 -0800 (PST) Received: from [10.176.68.139] ([192.19.213.250]) by smtp.gmail.com with ESMTPSA id 126sm6035033qkl.24.2017.03.10.01.35.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Mar 2017 01:35:35 -0800 (PST) Subject: Re: [PATCH v2 2/4] brcmfmac: p2p and normal ap access are not always possible at the same time To: Hans de Goede , Franky Lin , Hante Meuleman , Kalle Valo References: <20170227214539.16422-1-hdegoede@redhat.com> <20170227214539.16422-2-hdegoede@redhat.com> <33689f32-1bf8-98f8-df65-278de097e435@broadcom.com> <738d049d-4e90-8a5d-e5c0-d037085a064c@redhat.com> <51624320-cbde-65e4-ee24-a4df8c7935d6@redhat.com> Cc: Takashi Iwai , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com From: Arend Van Spriel Message-ID: Date: Fri, 10 Mar 2017 10:35:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <51624320-cbde-65e4-ee24-a4df8c7935d6@redhat.com> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 10-3-2017 9:08, Hans de Goede wrote: > Hi, > > On 08-03-17 12:16, Hans de Goede wrote: >> Hi, >> >> On 08-03-17 11:15, Arend Van Spriel wrote: >>> On 8-3-2017 10:26, Arend Van Spriel wrote: >>>> On 8-3-2017 9:24, Hans de Goede wrote: >>>>> Hi, >>>>> >>>>> On 07-03-17 11:03, Arend Van Spriel wrote: >>>>>> >>>>>> >>>>>> On 27-2-2017 22:45, Hans de Goede wrote: >>>>>>> The firmware responding with -EBUSY when trying to add an extra >>>>>>> virtual-if >>>>>>> is a normal thing, do not print an error for this. >>>>>> >>>>>> This may be something we need to look into. It seems to me the >>>>>> interface >>>>>> combinations needs to be fixed so we do not try to provision >>>>>> firmware. >>>>>> Can you explain the scenario here? >>>>> >>>>> I'm not doing anything special just connecting to my isp provided >>>>> accesspoint >>>>> using NetworkManager. >>>> >>>> Ok. So it is probably the P2P_DEVICE interface as that is the only >>>> interface being created in that scenario. Can you provide a log with >>>> brcmfmac driver debug=0x1416. >>> >>> I guess you are seeing this with 43362. Is that correct? > > Attached is a dmesg log from the brcmfmac driver build with debugging > enabled and brcmfmac.debug set to 0x1416. I suspect the P2P_DEVICE interface is assigned the same address as wlp1s0. Can you apply the change below and create the log again. Regards, Arend switch (type) { case NL80211_IFTYPE_P2P_CLIENT: diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/ne index de19c7c..43fa9f45 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c @@ -2158,7 +2158,8 @@ struct wireless_dev *brcmf_p2p_add_vif(struct wiphy *wiphy if (brcmf_cfg80211_vif_event_armed(cfg)) return ERR_PTR(-EBUSY); - brcmf_dbg(INFO, "adding vif \"%s\" (type=%d)\n", name, type); + brcmf_dbg(INFO, "adding vif \"%s\" (type=%d, addr=%pM)\n", name, type, + params->macaddr);