From patchwork Wed Apr 6 15:34:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miquel Raynal X-Patchwork-Id: 12803890 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53642C433F5 for ; Wed, 6 Apr 2022 17:29:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238957AbiDFRbg (ORCPT ); Wed, 6 Apr 2022 13:31:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239131AbiDFRbW (ORCPT ); Wed, 6 Apr 2022 13:31:22 -0400 Received: from relay12.mail.gandi.net (relay12.mail.gandi.net [IPv6:2001:4b98:dc4:8::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C07E282514; Wed, 6 Apr 2022 08:34:45 -0700 (PDT) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 9DE6B200005; Wed, 6 Apr 2022 15:34:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1649259283; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eFko5NX97m4muugeqnROyi5azqJxgV0f4MAyTkyBg8A=; b=pYmUmwlYVj8lMczX9nkXhgi59o41A64KRAuWi2kWQfqNUWukWJ++QfbhIXwJuPIMy3ZsB0 YOVJh/buGokeEwVqMzWkNIP4Sqm7AB6Kk5cCKGuVz3gxAnsRj2SU+3qbO22UUozouKNoCG +BjcSUPsMU+qdvVLSw7pmBlyrdEz0ewQVjc7bAx4i2EsP7RmPKPxzSHSc7oYDr5ywL86fs eWdOVyJyzAd3H4/B8f3jD/+cqF8lyGozOvCSpIoCn8ZLP8dfCHlevMMDPh7zNiUGaPtCS3 W59mCJbTxpVfcCoXU7lZ18keumCatZEUbiMESV+4k05FCqXi77k7T2c91fIMIQ== From: Miquel Raynal To: Alexander Aring , Stefan Schmidt , linux-wpan@vger.kernel.org Cc: "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, David Girault , Romuald Despres , Frederic Blain , Nicolas Schodet , Thomas Petazzoni , Miquel Raynal Subject: [PATCH v5 00/11] ieee802154: Better Tx error handling Date: Wed, 6 Apr 2022 17:34:30 +0200 Message-Id: <20220406153441.1667375-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wpan@vger.kernel.org The idea here is to provide a fully synchronous Tx API and also be able to be sure that a transfer has finished. This will be used later by another series. However, while working on this task, it appeared necessary to first rework the way MLME errors were (not) propagated to the upper layers. This small series tries to tackle exactly that, before introducing the synchronous API. Changes in v5: * Introduced a new helper which should be used upon bus errors. We don't ask users to provide an error code (which would be misleading) and instead forward IEEE802154_SYSTEM_ERROR which is our generic code. * Dropped most of my changes in the at86rf320 driver in ordre to do things a little bit differently: - the existing error path is renamed to clearly identify that it handles bus errors. - trac errors are handled in a separate path and the core helper is used to return the trac value. * Merged the revert commit with the following commit forwarding trac errors to the core. Changes in v4: * Reverted the at86rf320 patch introducing trac values for debugfs purposes as suggested by Alex. Reintroduced some of its content in a subsequent patch to filter out offloaded transmission error cases. * Used IEEE802154_SYSTEM_ERROR as a non specific error code. Changes in v3: * Split the series into two parts, this is the "error handling" halve. * Reworked the error path to not handle the ifs_handling situation anymore. * Enhanced the list of MLME status codes available. * Improved the error handling by collecting the error codes, somethimes by changing device drivers directly to propagate these MLME statuses. Then, once in the core, save one global Tx status value so that in the case of synchronous transfers we can check the return value and eventually error out. * Prevented the core to stop the device before the end of the last transmission to avoid deadlocks by just sync'ing the last Tx transfer. Changes in v2: * Adapted with the changes already merged/refused. Miquel Raynal (11): net: ieee802154: Enhance/fix the names of the MLME return codes net: ieee802154: Fill the list of MLME return codes net: mac802154: Save a global error code on transmissions net: mac802154: Create a transmit error helper net: mac802154: Create a transmit bus error helper net: ieee802154: at86rf230: Rename the asynchronous error helper net: ieee802154: at86rf230: Call _xmit_bus_error() when a bus error occurs net: ieee802154: at86rf230: Drop debugfs support net: ieee802154: atusb: Call _xmit_error() when a transmission fails net: ieee802154: ca8210: Use core return codes instead of hardcoding them net: ieee802154: ca8210: Call _xmit_error() when a transmission fails drivers/net/ieee802154/Kconfig | 7 -- drivers/net/ieee802154/at86rf230.c | 154 ++++++------------------ drivers/net/ieee802154/atusb.c | 5 +- drivers/net/ieee802154/ca8210.c | 182 +++++++++++------------------ include/linux/ieee802154.h | 81 +++++++++++-- include/net/mac802154.h | 19 +++ net/mac802154/ieee802154_i.h | 2 + net/mac802154/util.c | 26 ++++- 8 files changed, 225 insertions(+), 251 deletions(-)